[Differential] [Accepted] D3287: Make sure we don't break compilation with past broken units

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. The error message is a bit confusing, it sounds like the right file is ${_tmp_FILE}. So I would suggest this instead message(WARNING "${_tmp_FILE}: Broken \"File\" field, make sure

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 82 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/82/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 07 Nov 2016 07:33:48 + Build duration: 1 min 45 sec CHANGE SET Revision 2472c

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 82 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/82/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 07 Nov 2016 07:33:48 + Build duration: 1 min 45 sec CHANGE SET Revision 2472c

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 83 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/83/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 07 Nov 2016 07:33:48 + Build duration: 1 min 43 sec CHANGE SET Revisio

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 83 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/83/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 07 Nov 2016 07:33:48 + Build duration: 1 min 43 sec CHANGE SET Revisio

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 82 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/82/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 07 Nov 2016 06:45:51 + Build duration: 1 min 44 sec CHANGE SET No cha

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 81 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/81/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 07 Nov 2016 06:41:01 + Build duration: 1 min 40 sec CHANGE SET No cha

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 80 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/80/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 07 Nov 2016 06:29:07 + Build duration: 8 min 48 sec CHANGE SET Revisi

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 81 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/81/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 07 Nov 2016 06:29:07 + Build duration: 1 min 46 sec CHANGE SET Revision ebba

Re: Review Request 129327: Expose desktopFileName in KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129327/ --- (Updated Nov. 7, 2016, 7:29 a.m.) Status -- This change has been mar

Review Request 129348: [htmlcreator] Port to QtWebEngine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129348/ --- Review request for KDE Frameworks, Christoph Feck and David Faure. Summar

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 262 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/262/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 07 Nov 2016 02:43:20 + Build duration: 11 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 265 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/265/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 07 Nov 2016 02:26:09 + Build duration: 12 min CHANGE SET No changes JUNIT RESULTS Name: (root)

[Differential] [Request, 8 lines] D3287: Make sure we don't break compilation with past broken units

apol created this revision. apol added reviewers: Frameworks, dfaure. REVISION SUMMARY Show a warning together with the old broken behavior BRANCH master REVISION DETAIL https://phabricator.kde.org/D3287 AFFECTED FILES KF5ConfigMacros.cmake EMAIL PREFERENCES https://phabricator.kde.o

[Differential] [Closed] D3251: Properly parse function keywords

apol closed this revision. REVISION DETAIL https://phabricator.kde.org/D3251 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, dfaure

Re: Review Request 129335: Fix cmake warking

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129335/ --- (Updated Nov. 6, 2016, 11:27 p.m.) Status -- This change has been ma

Re: Review Request 129356: kdesignerplugin - add overrides to the generated source

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129356/#review100672 --- Ship it! Ship It! - David Faure On Nov. 6, 2016, 10:30

Jenkins-kde-ci: kunitconversion master stable-kf5-qt5 » Linux,gcc - Build # 86 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kunitconversion%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Nov 2016 23:01:48 + Build duration: 56 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kunitconversion master stable-kf5-qt5 » Linux,gcc - Build # 86 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kunitconversion%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Nov 2016 23:01:48 + Build duration: 56 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kunitconversion master kf5-qt5 » Linux,gcc - Build # 90 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kunitconversion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/90/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Nov 2016 23:01:27 + Build duration: 59 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kunitconversion master kf5-qt5 » Linux,gcc - Build # 90 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kunitconversion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/90/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Nov 2016 23:01:27 + Build duration: 59 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kunitconversion master stable-kf5-qt5 » Linux,gcc - Build # 85 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kunitconversion%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/85/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Nov 2016 22:35:09 + Build duration: 8.3 sec CHANGE SET Revision 8bf303250a58ae4bb682851a97549

Jenkins-kde-ci: kunitconversion master kf5-qt5 » Linux,gcc - Build # 89 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kunitconversion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Nov 2016 22:35:09 + Build duration: 8.8 sec CHANGE SET Revision 8bf303250a58ae4bb682851a97549f6d040b

Re: Review Request 129355: kparts add overrides

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129355/ --- (Updated Nov. 6, 2016, 11:35 p.m.) Status -- This change has been ma

Re: Review Request 129354: kunitconversion - add overrides

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129354/ --- (Updated Nov. 6, 2016, 10:34 p.m.) Status -- This change has been ma

Review Request 129356: kdesignerplugin - add overrides to the generated source

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129356/ --- Review request for KDE Frameworks. Repository: kdesignerplugin Descript

Re: Review Request 129355: kparts add overrides

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129355/#review100671 --- Ship it! Ship It! - David Faure On Nov. 6, 2016, 9:06

Re: Review Request 129354: kunitconversion - add overrides

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129354/#review100670 --- Ship it! Ship It! - David Faure On Nov. 6, 2016, 8:52

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

> On Nov. 6, 2016, 7:36 p.m., David Faure wrote: > > src/codecs/coding.cpp, line 177 > > > > > > remove space before auto; make it "const auto" while at it? ignore the const bit, that was nonsense. - David -

Review Request 129355: kparts add overrides

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129355/ --- Review request for KDE Frameworks. Repository: kparts Description -

Review Request 129354: kunitconversion - add overrides

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129354/ --- Review request for KDE Frameworks. Repository: kunitconversion Descript

Re: Review Request 129283: kwidgetaddons - add overrides

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129283/ --- (Updated Nov. 6, 2016, 8:42 p.m.) Status -- This change has been mar

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129281/ --- (Updated Nov. 6, 2016, 9:40 p.m.) Review request for KDE Frameworks and K

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

> On Nov. 6, 2016, 2:35 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > src/TerminalDisplay.cpp, line 859 > > > > > > Minor nitpick: is there any reason not to unconditionally add the > > LTR_OVERRIDE_CHAR? >

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100660 --- Fix it, then Ship it! src/codecs/coding.cpp (line 160) <

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 139 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/139/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Nov 2016 19:17:05 + Build duration: 6 min 40 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 139 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/139/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Nov 2016 19:17:05 + Build duration: 6 min 40 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Re: Review Request 129283: kwidgetaddons - add overrides

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129283/#review100658 --- Ship it! Merci :) - Christoph Feck On Nov. 6, 2016, 7:

Re: Review Request 129351: Only search for a avatar if loginName isn't empty

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129351/ --- (Updated Nov. 6, 2016, 7:06 p.m.) Status -- This change has been mar

Re: Review Request 129351: Only search for a avatar if loginName isn't empty

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129351/#review100656 --- Ship it! Ship It! - David Edmundson On Nov. 6, 2016, 6

Review Request 129351: Only search for a avatar if loginName isn't empty

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129351/ --- Review request for KDE Frameworks, David Edmundson and Michael Pyne. Repo

Re: Review Request 129283: kwidgetaddons - add overrides

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129283/ --- (Updated Nov. 6, 2016, 6:26 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 129283: kwidgetaddons - add overrides

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129283/ --- (Updated Nov. 6, 2016, 6:18 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100652 --- Ship it! Ship It! - Michael Stemle On Nov. 6, 2016, 12

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

> On Nov. 6, 2016, 1:35 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > src/TerminalDisplay.cpp, line 859 > > > > > > Minor nitpick: is there any reason not to unconditionally add the > > LTR_OVERRIDE_CHAR? >

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129281/#review100648 --- src/TerminalDisplay.cpp (line 859)

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/ --- (Updated Nov. 6, 2016, 12:58 p.m.) Review request for Baloo, KDE Framewor

[Differential] [Accepted] D3251: Properly parse function keywords

dfaure accepted this revision. dfaure added a reviewer: dfaure. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D3251 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, dfaure

Re: Review Request 129315: Don't install plasmoid desktop files as services

> On Nov. 3, 2016, 12:53 p.m., Marco Martin wrote: > > I'm in favor of this, let's wait to 5.29 tough 5.28 RC is tagged, you can now push commits for 5.29. - David --- This is an automatically generated e-mail. To reply, visit: https://

Re: Review Request 129335: Fix cmake warking

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129335/#review100640 --- Ship it! Ship It! - David Faure On Nov. 4, 2016, 11:39

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/#review100639 --- Fix it, then Ship it! src/kstandardaction.cpp (line 201)

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100638 --- src/codecs/coding.cpp (line 114)

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 280 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/280/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Nov 2016 11:14:13 + Build duration: 1 min 7 sec CHANGE SET No changes JUNIT RESULTS N

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 280 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/280/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Nov 2016 11:14:13 + Build duration: 1 min 7 sec CHANGE SET No changes JUNIT RESULTS N

Re: KStandardAction::showMenubar and native menubars

El diumenge, 6 de novembre de 2016, a les 10:43:42 CET, David Faure va escriure: > On mercredi 12 octobre 2016 00:05:30 CET Albert Astals Cid wrote: > > My current (yet to implement/test) idea is have > > KStandardAction::showMenubar check all the menubars of the top level > > windows of the app a

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

> On Nov. 6, 2016, 5:40 a.m., Michael Stemle wrote: > > src/codecs/coding.cpp, line 186 > > > > > > PEDANTIC QUESTION: Why do we `resize()` rather than just using > > `QByteArray((values.size() + 1) * 5, '\0')`?

Re: Please add consistency in naming of (noK)Syntax(-)Highlighting library

On Friday 04 November 2016 14:54:25 Volker Krause wrote: > Hi, > > On Thursday 03 November 2016 11:38:21 Friedrich W. H. Kossebau wrote: > > one of the things we praise about Qt is the predictability of class names > > and methods names. Because the patterns used with them decrease the amount > >

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 279 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/279/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Nov 2016 10:07:36 + Build duration: 2 min 11 sec CHANGE SET No changes

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

> On Oct. 30, 2016, 10:38 p.m., David Faure wrote: > > KCoreDirLister is complex enough, I'd rather not add features to it. > > > > Let's take a step back. > > > > This looks like an already solved problem to me, if I understand it > > correctly: > > - a kioslave creates a virtual filesystem

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/#review100629 --- Ship it! Looks ok now, except for the ATime/MTime/CTime b

Re: KStandardAction::showMenubar and native menubars

On mercredi 12 octobre 2016 00:05:30 CET Albert Astals Cid wrote: > My current (yet to implement/test) idea is have KStandardAction::showMenubar > check all the menubars of the top level windows of the app and if they are > all marked as native, then return a dummy QAction that is not inserted in >

Re: Review Request 129133: Silent warning of unused variable in lamda function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129133/#review100628 --- src/runtime/kwalletd/migrationwizard.cpp (line 37)

Re: KIO, proxies, libproxy and OS X/MSWin

On jeudi 22 septembre 2016 13:20:35 CET René J.V. Bertin wrote: > Hi, > > Can someone provide a synthetic resume of how KIO handles proxies Via QNetworkProxy it seems, in the slaves themselves. See kio/src/ioslaves/http/http.cpp > I observe that > - KIO doesn't link to libproxy and doesn't requ