[Differential] [Request, 21 lines] D3251: Properly parse function keywords

apol created this revision. apol added a reviewer: Frameworks. REVISION SUMMARY Use cmake_parse_arguments() instead of roughly implementing it locally CCBUG: 371562 TEST PLAN recompiled everything, nothing broke BRANCH master REVISION DETAIL https://phabricator.kde.org/D3251 AFFEC

[Differential] [Closed] D3234: Separate sort roles and filters

apol closed this revision. REVISION DETAIL https://phabricator.kde.org/D3234 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, mart, leinir

[Differential] [Accepted] D3234: Separate sort roles and filters

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Looks good to me! :) BRANCH master REVISION DETAIL https://phabricator.kde.org/D3234 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #framew

[Differential] [Closed] D3226: Don't be fatal on File field not being properly parsed

apol closed this revision. REVISION DETAIL https://phabricator.kde.org/D3226 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, davidedmundson Cc: aacid, kfunk

[Differential] [Updated, 128 lines] D3234: Separate sort roles and filters

apol updated this revision to Diff 7864. apol added a comment. Update enum entry name CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3234?vs=7838&id=7864 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3234 AFFECTED FILES src/attica/atticaprovider.cpp src/core/e

[Differential] [Updated] D3234: Separate sort roles and filters

leinir added a comment. It would make fine sense to merge this in already (i'll merge it into the branch), as this is, of course, fairly important to get in, and there are things in my branch which may need some further discussions before a final merge (though i hope it's more a case of "woo

Re: Review Request 129321: Don't redeclare signal and then not use it anyway

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129321/#review100538 --- Ship it! Ship It! - Marco Martin On Nov. 3, 2016, 1:48

Review Request 129321: Don't redeclare signal and then not use it anyway

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129321/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 129315: Don't install plasmoid desktop files as services

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129315/#review100537 --- I'm in favor of this, let's wait to 5.29 tough - Marco Mart

[Differential] [Updated] D3234: Separate sort roles and filters

mart added a comment. to me looks good, is probably better to wait the merge by dan? INLINE COMMENTS > provider_p.h:63 > +Updates, > +ExactId > +}; EntryId? REVISION DETAIL https://phabricator.kde.org/D3234 EMAIL PREFERENCES https://phabricator.kde.org/settings/pane

Stepping down as KGlobalAccel maintainer

Hi frameworks developers, I decided to step down as the maintainer of KGlobalAccel. I haven't done any work on KGlobalAccel this year and bug reports just linger. A big problem for me maintaining KGlobalAccel is that most work is needed in the X11 implementation. As I no longer use X11 and cann

Jenkins-kde-ci: oxygen Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 13 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/oxygen%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 03 Nov 2016 11:02:31 + Build duration: 1 min 52 sec CHANGE SET Revision eb6ba888913283f74de5e2172e872

Jenkins-kde-ci: oxygen Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 13 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/oxygen%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 03 Nov 2016 11:02:31 + Build duration: 1 min 52 sec CHANGE SET Revision eb6ba888913283f74de5e2172e872

[Differential] [Accepted] D3226: Don't be fatal on File field not being properly parsed

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D3226 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol,

Please add consistency in naming of (noK)Syntax(-)Highlighting library

Hi, one of the things we praise about Qt is the predictability of class names and methods names. Because the patterns used with them decrease the amount of knowledge one needs to have, as things can be derived. No need to look up in a dictionary, just take the base name and apply a common patte

Jenkins-kde-ci: oxygen Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 12 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/oxygen%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 03 Nov 2016 10:30:55 + Build duration: 49 sec CHANGE SET No changes