Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

2016-10-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/#review100456 --- How about putting it in QDebug? Message boxes could make us

Re: Review Request 129298: RFC: supporting dependencies on KPackage

2016-10-31 Thread Aleix Pol Gonzalez
> On Oct. 31, 2016, 6:19 p.m., Marco Martin wrote: > > autotests/data/testpackagesdep/metadata.json, line 14 > > > > > > if kns ends up using ids, maybe the server should be specified as well, > > as the id would

Jenkins-kde-ci: knotifyconfig master kf5-qt5 » Linux,gcc - Build # 247 - Failure!

2016-10-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knotifyconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/247/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 21:16:36 + Build duration: 1 min 4 sec CHANGE SET No changes

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 254 - Still Unstable!

2016-10-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/254/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 20:57:58 + Build duration: 14 min CHANGE SET Revision a2aef4c9b3d43ffc45019f6cccb40721e0594aae by cfe

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 256 - Still Unstable!

2016-10-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/256/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 20:57:58 + Build duration: 8 min 37 sec CHANGE SET Revision a2aef4c9b3d43ffc45019f6cccb40721e0

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 253 - Unstable!

2016-10-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/253/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 20:38:18 + Build duration: 12 min CHANGE SET Revision af0105c22ec80e411bf226e77f40987464e478d3 by Ant

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 255 - Still Unstable!

2016-10-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/255/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 20:38:18 + Build duration: 6 min 56 sec CHANGE SET Revision af0105c22ec80e411bf226e77f40987464

Re: Review Request 129280: Fix editing autostart items

2016-10-31 Thread Antonio Rojas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129280/ --- (Updated Oct. 31, 2016, 8:37 p.m.) Status -- This change has been ma

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

2016-10-31 Thread Albert Astals Cid
> On Oct. 31, 2016, 6:50 p.m., Elvis Angelaccio wrote: > > src/kxmlguiwindow.cpp, line 327 > > > > > > I think it would be better if this were not blocking (i.e. creating the > > QMessageBox manually and showing

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

2016-10-31 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/ --- (Updated Oct. 31, 2016, 7:18 p.m.) Review request for KDE Frameworks, Dav

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

2016-10-31 Thread Albert Astals Cid
> On Oct. 31, 2016, 6:50 p.m., Elvis Angelaccio wrote: > > +1, fixes the Gwenview case. I get a warning with Dolphin, but it looks > > unrelated: http://i.imgur.com/ZF454gn.png No, that's actually a problem with my code being too strict, dolphin alternates the enabledness of the actions that s

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

2016-10-31 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/#review100448 --- +1, fixes the Gwenview case. I get a warning with Dolphin, b

Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

2016-10-31 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/ --- Review request for KDE Frameworks, David Faure and Elvis Angelaccio. Repo

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

2016-10-31 Thread Albert Astals Cid
> On Oct. 30, 2016, 10:27 a.m., David Faure wrote: > > Right. We have Shift+Del as an alternate shortcut for cut because when I > > switched from Windows to Linux (last millenium!), I had taken the habit to > > use Ctrl+Insert, Shift+Del, and Shift+Insert for copy/cut/paste (these are > > cert

Re: Review Request 129298: RFC: supporting dependencies on KPackage

2016-10-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129298/#review100442 --- yep, that's pretty much what i had in mind. it's early stage

Review Request 129298: RFC: supporting dependencies on KPackage

2016-10-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129298/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 269 - Fixed!

2016-10-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/269/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 16:52:39 + Build duration: 56 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 269 - Fixed!

2016-10-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/269/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 16:52:39 + Build duration: 56 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: knotifyconfig master stable-kf5-qt5 » Linux,gcc - Build # 250 - Fixed!

2016-10-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifyconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/250/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 16:50:49 + Build duration: 1 min 1 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: knotifyconfig master stable-kf5-qt5 » Linux,gcc - Build # 250 - Fixed!

2016-10-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifyconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/250/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 16:50:49 + Build duration: 1 min 1 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 268 - Failure!

2016-10-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/268/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 16:49:34 + Build duration: 11 sec CHANGE SET No changes

Jenkins-kde-ci: knotifyconfig master stable-kf5-qt5 » Linux,gcc - Build # 249 - Failure!

2016-10-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knotifyconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/249/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 16:49:35 + Build duration: 1 min 8 sec CHANGE SET No changes

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 254 - Still Unstable!

2016-10-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/254/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 16:35:36 + Build duration: 12 min CHANGE SET Revision b4fe6cdd7f76d280e77d7ee0da52ed975f65950d

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 251 - Fixed!

2016-10-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/251/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 16:37:50 + Build duration: 4 min 56 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 251 - Fixed!

2016-10-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/251/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 16:37:50 + Build duration: 4 min 56 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kactivities master kf5-qt5 » Linux,gcc - Build # 268 - Fixed!

2016-10-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kactivities%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/268/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 16:37:50 + Build duration: 4 min 42 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: kactivities master kf5-qt5 » Linux,gcc - Build # 268 - Fixed!

2016-10-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kactivities%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/268/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 16:37:50 + Build duration: 4 min 42 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: kactivities master kf5-qt5 » Linux,gcc - Build # 267 - Failure!

2016-10-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kactivities%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/267/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 16:34:06 + Build duration: 2 min 31 sec CHANGE SET No changes

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 250 - Failure!

2016-10-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/250/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 16:34:06 + Build duration: 2 min 2 sec CHANGE SET No changes

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 253 - Still Unstable!

2016-10-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/253/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 16:21:08 + Build duration: 11 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Review Request 129271: [KOpenWithDialog] Hide TreeView header

2016-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129271/ --- (Updated Oct. 31, 2016, 4:26 p.m.) Status -- This change has been ma

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

2016-10-31 Thread Anthony Fieroni
> On Oct. 31, 2016, 12:38 a.m., David Faure wrote: > > src/core/kcoredirlister.h, line 429 > > > > > > You can't add virtual methods to a public class, this is not binary > > compatible. > > Anthony Fieroni wro

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

2016-10-31 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129205/ --- (Updated Oct. 31, 2016, 5:53 p.m.) Status -- This change has been di

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 234 - Unstable!

2016-10-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/234/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 31 Oct 2016 13:46:05 + Build duration: 2 min 36 sec CHANGE SE

Re: Review Request 129296: Drop unused KConfig dependency

2016-10-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129296/ --- (Updated Oct. 31, 2016, 1:02 p.m.) Status -- This change has been ma

Re: Review Request 129296: Drop unused KConfig dependency

2016-10-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129296/#review100435 --- Ship it! Ship It! - Marco Martin On Oct. 31, 2016, 12:

Review Request 129296: Drop unused KConfig dependency

2016-10-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129296/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

2016-10-31 Thread Albert Astals Cid
> On Oct. 30, 2016, 10:38 p.m., David Faure wrote: > > KCoreDirLister is complex enough, I'd rather not add features to it. > > > > Let's take a step back. > > > > This looks like an already solved problem to me, if I understand it > > correctly: > > - a kioslave creates a virtual filesystem

Re: Review Request 129103: Generate metadata.json file at build time

2016-10-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129103/ --- (Updated Oct. 31, 2016, 11:10 a.m.) Status -- This change has been m

Re: Review Request 129279: Make sure we're looking both for json and desktop metadata

2016-10-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129279/ --- (Updated Oct. 31, 2016, 12:08 p.m.) Status -- This change has been m

Re: Review Request 129279: Make sure we're looking both for json and desktop metadata

2016-10-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129279/#review100429 --- Ship it! Ship It! - Marco Martin On Oct. 28, 2016, 5:3

Re: Review Request 129278: Don't reparse the metadata file if it's already loaded

2016-10-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129278/ --- (Updated Oct. 31, 2016, 12:05 p.m.) Status -- This change has been m

Re: Review Request 129278: Don't reparse the metadata file if it's already loaded

2016-10-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129278/#review100426 --- Fix it, then Ship it! src/plasma/package.h (line 350)

Re: Review Request 129244: Make UDisks2 backend compile on FreeBSD (and, possibly, other UNIXes).

2016-10-31 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129244/ --- (Updated Oct. 31, 2016, 11:49 a.m.) Status -- This change has been m

Re: Review Request 129244: Make UDisks2 backend compile on FreeBSD (and, possibly, other UNIXes).

2016-10-31 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129244/#review100423 --- Ship it! Ship It! - Albert Astals Cid On Oct. 31, 2016

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

2016-10-31 Thread David Faure
> On Oct. 30, 2016, 10:38 p.m., David Faure wrote: > > KCoreDirLister is complex enough, I'd rather not add features to it. > > > > Let's take a step back. > > > > This looks like an already solved problem to me, if I understand it > > correctly: > > - a kioslave creates a virtual filesystem

Re: Review Request 129197: Fix tests on FreeBSD

2016-10-31 Thread Gleb Popov
> On Oct. 16, 2016, 4:12 p.m., Tobias Berner wrote: > > I'm kind of unsure if this is right. Yes, the tests run now, but isn't the > > issue rather in the way kpty works (or fails to work on FreeBSD)? > > Gleb Popov wrote: > From what i've understood, this boils down to > `KPtyDevicePrivat

Re: Review Request 129244: Make UDisks2 backend compile on FreeBSD (and, possibly, other UNIXes).

2016-10-31 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129244/ --- (Updated Oct. 31, 2016, 10:03 a.m.) Review request for KDE Frameworks and