Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-27 Thread taro yamada
> On Oct. 27, 2016, 7:13 p.m., Andreas Hartmetz wrote: > > Taro, do you have push rights? Otherwise I or somebody else can push it for > > you. Ah, I was misunderstanding the use of reviewboard. I'll try to push, thank you very much! - taro --

Re: Review Request 129267: [OS X] emulate posix_fallocate()

2016-10-27 Thread Michael Pyne
> On Oct. 27, 2016, 1:55 a.m., Michael Pyne wrote: > > src/lib/caching/posix_fallocate_mac.h, line 97 > > > > > > Given that the user has some input into the size of the cache I'd > > prefer to have some kind of

Re: ABI break checking in frameworks

2016-10-27 Thread Albert Astals Cid
El dijous, 27 d’octubre de 2016, a les 9:20:29 CEST, Jaroslaw Staniek va escriure: > On 26 October 2016 at 23:54, Albert Astals Cid wrote: > > Does anyone have other ideas or thoughts on it? > > ​Three things: > - the Qt project has own solution for the checks, maybe worth looking > - try to con

Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-27 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129259/#review100338 --- Ship it! Taro, do you have push rights? Otherwise I or so

Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-27 Thread taro yamada
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129259/ --- (Updated Oct. 27, 2016, 3:02 p.m.) Review request for KDE Frameworks. C

Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-27 Thread taro yamada
> On Oct. 27, 2016, 12:57 p.m., Andreas Hartmetz wrote: > > src/ioslaves/file/file.cpp, line 791 > > > > > > You can use qMin() here. As is the compiler would complain about the > > different types (off_t and in

[Differential] [Request, 70 lines] D3178: Make kconfig_compiler autotests use the KCONFIG_ADD_KCFG_FILES

2016-10-27 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added a reviewer: Frameworks. REVISION SUMMARY Instead of having an odd fake of it. Will help some required refactorings and already showed some issues, fixed by this patch, namely: - don't use string(regex replace) to extract a string from another

Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-27 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129259/#review100334 --- Ship it! In any case this is good enough already. src/i

Re: Review Request 129267: [OS X] emulate posix_fallocate()

2016-10-27 Thread René J . V . Bertin
> On Oct. 27, 2016, 3:55 a.m., Michael Pyne wrote: > > src/lib/caching/posix_fallocate_mac.h, line 97 > > > > > > Given that the user has some input into the size of the cache I'd > > prefer to have some kind of

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

2016-10-27 Thread Kai Uwe Broulik
> On Okt. 27, 2016, 10:38 vorm., Kai Uwe Broulik wrote: > > The problem with isNativeMenuBar() is that it returns true if the window > > *may* be a native menu bar, for example when the platform theme removes the > > AA_DontUseNativeMenuBar qApp flag. This does not mean that the platform > > t

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

2016-10-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/#review100331 --- The problem with isNativeMenuBar() is that it returns true i

Re: Review Request 126028: Add support for desktopFileName to NETWinInfo

2016-10-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126028/ --- (Updated Oct. 27, 2016, 9:33 a.m.) Status -- This change has been ma

Re: ABI break checking in frameworks

2016-10-27 Thread Jaroslaw Staniek
On 26 October 2016 at 23:54, Albert Astals Cid wrote: > > > > Does anyone have other ideas or thoughts on it? > > ​Three things: - the Qt project has own solution for the checks, maybe worth looking - try to convert the compiler-specific decorated symbols to some uniform notation and compare just

Re: Review Request 129262: Properly finish DropJobs when triggered is not emitted

2016-10-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129262/#review100324 --- Ship it! Thanks for the fix. Given that there is no "canc