vonreth added a comment.
Looks good to me.
But just to be 1000% correct please delete the new operator.
REVISION DETAIL
https://phabricator.kde.org/D3091
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, #frameworks, brauch
Cc: vonreth, nalvarez,
brauch added a comment.
The user who originally reported the issue confirms that this patch fixes it.
REVISION DETAIL
https://phabricator.kde.org/D3091
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, #frameworks, brauch
Cc: nalvarez, broulik
kfunk added a comment.
In https://phabricator.kde.org/D3091#57279, @nalvarez wrote:
> Meanwhile I'm skeptical of the need to "set it back". Is there any case
where such error dialog boxes would be desirable? It seems like their existence
is an ancient-app-compatibility thing. The documen
kfunk added a comment.
In https://phabricator.kde.org/D3091#57277, @broulik wrote:
> Can't really comment on this, though.
> While I'm a huge fan of RAII you don't seem to be returning early from that
function
RAII is not only useful for cases where you return early.
kfunk updated this revision to Diff 7476.
kfunk added a comment.
SetErrorMode -> SetThreadErrorMode (thread-safe)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3091?vs=7475&id=7476
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3091
AFFECTED FILES
src/solid/devi
brauch added a comment.
The other interesting question is why we even query for free disk space on
all drives, but I guess this patch still makes sense in any case.
REVISION DETAIL
https://phabricator.kde.org/D3091
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefere
nalvarez added a comment.
Meanwhile I'm skeptical of the need to "set it back". Is there any case where
such error dialog boxes would be desirable? It seems like their existence is an
ancient-app-compatibility thing. The documentation for `SetErrorMode`
recommends setting `SEM_FAILCRITICALER
broulik added a comment.
Can't really comment on this, though.
While I'm a huge fan of RAII you don't seem to be returning early from that
function, can't you just set the value and set it back at the end without this
new class?
REVISION DETAIL
https://phabricator.kde.org/D3091
EMAIL PR
kfunk added reviewers: Frameworks, brauch.
REVISION DETAIL
https://phabricator.kde.org/D3091
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, #frameworks, brauch
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/226/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 16:18:31 +
Build duration: 4 min 14 sec
CHANGE SET
Revisi
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/226/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 16:18:31 +
Build duration: 1 min 53 sec
CHANGE SET
Revision a
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/226/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 16:18:31 +
Build duration: 1 min 44 sec
CHANGE SET
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/226/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 16:18:31 +
Build duration: 1 min 42 sec
CHANGE SET
Rev
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129210/
---
(Updated Oct. 17, 2016, 6:18 p.m.)
Status
--
This change has been ma
> On Oct. 17, 2016, 4:07 p.m., David Edmundson wrote:
> > Though in future, I wouldn't bother putting a logging category on an
> > autotest.
that was done because the aytotest statically links to a model from imports, so
it needs it in order to still link correctly
- Marco
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129210/#review100103
---
Ship it!
Though in future, I wouldn't bother putting a lo
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129209/#review100102
---
Fine by me. As discussed on IRC, we need to keep track of th
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129065/
---
(Updated Oct. 17, 2016, 3:46 p.m.)
Status
--
This change has been ma
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129104/
---
(Updated Oct. 17, 2016, 3:45 p.m.)
Status
--
This change has been ma
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129210/
---
Review request for KDE Frameworks and Plasma.
Repository: plasma-framewor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129209/
---
Review request for Documentation and KDE Frameworks.
Repository: kdelibs4
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 9 min 14 sec
CHANGE SET
Revision 2
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 9 min 14 sec
CHANGE SET
Revision 2
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 8 min 11 sec
CHANGE SET
Revisi
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 8 min 11 sec
CHANGE SET
Revisi
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 9 min 27 sec
CHANGE SET
Rev
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 9 min 27 sec
CHANGE SET
Rev
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 2 min 22 sec
CHANGE SET
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/223/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:58:49 +
Build duration: 2 min 22 sec
CHANGE SET
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129205/
---
(Updated Oct. 17, 2016, 3:25 p.m.)
Review request for KDE Frameworks and
On Sun, Oct 16, 2016 at 2:16 PM, Christoph Cullmann wrote:
> Hi,
>
> (evil top posting)
>
> given the silence, I assume any interest in baloo has stopped once more, or?
> Or are there any plans how to fixup the current situation?
I'm not going to be very involved with this.
I've already expresse
On Fri, Oct 7, 2016 at 8:08 PM, Christoph Cullmann wrote:
>
> I did experiments and search works with tracker, but yes, a problem is
> tagging,+
> which ATM doesn't work. Nor do I say that is a ready solution now, just a
> possibility
> to avoid having to maintain low level code with at most 1 p
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/222/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 11:48:36 +
Build duration: 5 min 48 sec
CHANGE SET
Revision 9
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/222/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 11:48:36 +
Build duration: 5 min 39 sec
CHANGE SET
Revisi
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/222/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 11:48:36 +
Build duration: 3 min 8 sec
CHANGE SET
Revi
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/222/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 11:48:36 +
Build duration: 2 min 46 sec
CHANGE SET
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129150/
---
(Updated Oct. 17, 2016, 11:48 a.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129103/#review100089
---
Ship it!
Ship It!
- Marco Martin
On Oct. 4, 2016, 11:3
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129065/#review100087
---
Ship it!
Ship It!
- Marco Martin
On Sept. 29, 2016, 11
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129150/#review100081
---
Ship it!
Ship It!
- Marco Martin
On Oct. 11, 2016, 1:4
> On Sept. 15, 2016, 9:28 a.m., Luigi Toscano wrote:
> > Can they be made co-installable with the ones with kde-runtime, as both
> > modules can be available at the same time? This is the problem of the
> > missing support for kcontrol5
> >
> > It was already done some time ago and I had to re
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review100078
---
Ship it!
Ship It!
- Marco Martin
On Sept. 15, 2016, 9:
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/339/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 17 Oct 2016 09:30:01 +
Build duration: 7 min 1 sec
CHANGE SET
Revision f946dfdd83a6ebf6cb45c8add1
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/221/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 09:30:41 +
Build duration: 6 min 45 sec
CHANGE SET
Rev
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/221/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 17 Oct 2016 09:30:41 +
Build duration: 2 min 23 sec
CHANGE SET
Revision 0
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/341/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 17 Oct 2016 09:30:01 +
Build duration: 6 min 50 sec
CHANGE SET
Revision f946dfdd83a6ebf6cb45c8add1975818
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/221/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 09:30:41 +
Build duration: 2 min 12 sec
CHANGE SET
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/221/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 17 Oct 2016 09:30:41 +
Build duration: 1 min 11 sec
CHANGE SET
Revisi
> On Sept. 15, 2016, 7:28 vorm., Luigi Toscano wrote:
> > Can they be made co-installable with the ones with kde-runtime, as both
> > modules can be available at the same time? This is the problem of the
> > missing support for kcontrol5
> >
> > It was already done some time ago and I had to r
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129205/
---
Review request for KDE Frameworks and David Faure.
Repository: kio
Desc
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129202/#review100066
---
+1 LGTM, unsure of the implications.
- Aleix Pol Gonzalez
51 matches
Mail list logo
