Re: Review Request 128831: Check whether kwallet is enabled in Wallet::isOpen(name)

2016-09-24 Thread Elvis Angelaccio
> On Sept. 24, 2016, 12:40 p.m., Elvis Angelaccio wrote: > > src/api/KWallet/kwallet.cpp, line 366 > > > > > > You should probably use isEnabled() instead, in case someone is using > > ksecretservice (though m_w

Re: Review Request 128831: Check whether kwallet is enabled in Wallet::isOpen(name)

2016-09-24 Thread Wolfgang Bauer
> On Sept. 24, 2016, 2:40 p.m., Elvis Angelaccio wrote: > > src/api/KWallet/kwallet.cpp, line 366 > > > > > > You should probably use isEnabled() instead, in case someone is using > > ksecretservice (though m_wa

Re: Review Request 128831: Check whether kwallet is enabled in Wallet::isOpen(name)

2016-09-24 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128831/#review99502 --- src/api/KWallet/kwallet.cpp (line 366)

Re: Review Request 129010: kded: remove dbus calls to ksplash.

2016-09-24 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129010/#review99501 --- Wouldn't this break the compatibility with older Plasma (one

Review Request 129010: kded: remove dbus calls to ksplash.

2016-09-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129010/ --- Review request for KDE Frameworks and David Edmundson. Repository: kded

Re: Review Request 128831: Check whether kwallet is enabled in Wallet::isOpen(name)

2016-09-24 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128831/#review99500 --- Ping? - Wolfgang Bauer On Sept. 4, 2016, 11:20 nachm., Wol

KActionCollection, menu/action reuse and the native Mac menubar

2016-09-24 Thread René J . V . Bertin
Hi, I'm making another attempt at raising awareness about a Qt platform limitation on Mac that has potentially severe implications for reuse of QMenus, QActions and QActionWidgets in multiple menus if one of those is attached to a native QMenuBar. In short, the KActionCollection class is compr