Re: Review Request 128916: kconfig: Make test XFAIL when running as root

2016-09-16 Thread Gleb Popov
> On Sept. 16, 2016, 7:57 p.m., Sune Vuorela wrote: > > autotests/kconfigtest.cpp, line 1376 > > > > > > Isn't a QSKIP if user is root in the beginning of the test a better > > approach ? I think, XFAIL is bet

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

2016-09-16 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/#review99231 --- autotests/kconfigtest.cpp (line 1376)

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

2016-09-16 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/#review99227 --- I'd say ship it, but let's wait for someone else. - Gleb Pop

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

2016-09-16 Thread Evgeniy Sadovnik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/ --- (Updated Sept. 16, 2016, 7:17 a.m.) Review request for KDE Frameworks and