C++11 & friends

2016-09-10 Thread Dominik Haumann
Hi all, I just saw a commit by Volker turning nullptr into Q_NULLPTR with the comment that Visual Studio 2012 does not support nullptr. While this change is trivial for obvious reasons, do we really need to do that? I am raising this question especially since KTextEditor seems to use 'nullptr' i

Re: Review Request 128882: Fix launching terminal .desktop files with konsole

2016-09-10 Thread Antonio Rojas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128882/ --- (Updated Sept. 10, 2016, 10:16 p.m.) Status -- This change has been

Re: baloo + out-of-memory in file extractor

2016-09-10 Thread Christoph Cullmann
Hi, > Hi Christoph, > > On 10 September 2016 at 23:46, Christoph Cullmann wrote: Would it be a good idea to restrict the file extractor process to some >>> fixed amount of memory to use via setrlimit? (or more fancy stuff?) >>> >>> That would probably just make Baloo crash, so fixing t

Re: Review Request 128882: Fix launching terminal .desktop files with konsole

2016-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128882/#review99061 --- Ship it! Ship It! - David Faure On Sept. 10, 2016, 7:15

Re: Review Request/New Framework: KF5::SyntaxHighlighting

2016-09-10 Thread Michael Palimaka
Hi, On 11/09/16 01:47, Volker Krause wrote: > Hi, > > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > becoming a framework :) Thanks a lot for working on this. I noticed that KF5SyntaxHighlightingConfig.cmake.in searches for Qt5Widgets, but that doesn't seem to used in

baloo + out-of-memory in file extractor

2016-09-10 Thread Boudhayan Gupta
Hi Christoph, On 10 September 2016 at 23:46, Christoph Cullmann wrote: >>> Would it be a good idea to restrict the file extractor process to some >> fixed amount of memory >>> to use via setrlimit? (or more fancy stuff?) >> >> That would probably just make Baloo crash, so fixing the bug is probab

Re: Review Request 128882: Fix launching terminal .desktop files with konsole

2016-09-10 Thread Antonio Rojas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128882/ --- (Updated Sept. 10, 2016, 7:15 p.m.) Review request for KDE Frameworks and

Review Request 128882: Fix launching terminal .desktop files with konsole

2016-09-10 Thread Antonio Rojas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128882/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request/New Framework: KF5::SyntaxHighlighting

2016-09-10 Thread Christoph Cullmann
Hi, will take a look at the API that is exposed for this first version, too. Thanks already for stepping up to "framework" your pet project, this might avoid that we end up with "just one more" highlighting implementation and perhaps even QtCreator can somewhen use (aka copy) this one to have t

Re: baloo + out-of-memory in file extractor (warning about the .mp3)

2016-09-10 Thread Christoph Cullmann
Hi, >> If you can consistently repro this, running under valgrind to check for >> leaks will also go a long way. > > https://github.com/taglib/taglib/blob/master/tests/data/toc_many_children.mp3 => Just as a warning: if you download that raw and have baloo indexing on, you are pwn'd ;=) Turn

Re: baloo + out-of-memory in file extractor

2016-09-10 Thread Christoph Cullmann
Hi, > Hi, > > On 10 Sep 2016 19:42, "Christoph Cullmann" wrote: >> >> Hi, >> >> during the last night of the akademy for me in Berlin, baloo file > extractor OOM'd my notebook >> during extracting the tag info of the taglib unit test test-files. > > Is it possible to reproduce the issue and get

Re: Review Request 128881: Remove outdated code snippet

2016-09-10 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128881/ --- (Updated Sept. 10, 2016, 6:09 p.m.) Status -- This change has been m

Re: Review Request 128881: Remove outdated code snippet

2016-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128881/#review99057 --- Ship it! Ship It! - David Faure On Sept. 10, 2016, 5:38

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 210 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/210/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 17:33:22 + Build duration: 4 min 43 sec CHANGE SET Revision c1a9ef3cb1e085bfdc2e56164b609f65f4f

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 210 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/210/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 17:33:22 + Build duration: 4 min 43 sec CHANGE SET Revision c1a9ef3cb1e085bfdc2e56164b609f65f4f

Review Request 128881: Remove outdated code snippet

2016-09-10 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128881/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request/New Framework: KF5::SyntaxHighlighting

2016-09-10 Thread Dominik Haumann
Hi Volker, thanks for this initiative! On Sat, Sep 10, 2016 at 5:47 PM, Volker Krause wrote: > Hi, > > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > becoming a framework :) > > This is a tier1/functional version of the Kate syntax highlighting engine. > It's not tied t

Re: baloo + out-of-memory in file extractor

2016-09-10 Thread Boudhayan Gupta
Hi, On 10 Sep 2016 19:42, "Christoph Cullmann" wrote: > > Hi, > > during the last night of the akademy for me in Berlin, baloo file extractor OOM'd my notebook > during extracting the tag info of the taglib unit test test-files. Is it possible to reproduce the issue and get a stack trace? If yo

Review Request/New Framework: KF5::SyntaxHighlighting

2016-09-10 Thread Volker Krause
Hi, please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for becoming a framework :) This is a tier1/functional version of the Kate syntax highlighting engine. It's not tied to a particular output format or editor engine, the interface is basically just passing in a line of text

baloo + out-of-memory in file extractor

2016-09-10 Thread Christoph Cullmann
Hi, during the last night of the akademy for me in Berlin, baloo file extractor OOM'd my notebook during extracting the tag info of the taglib unit test test-files. Would it be a good idea to restrict the file extractor process to some fixed amount of memory to use via setrlimit? (or more fancy

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 310 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/310/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:59:59 + Build duration: 19 min CHANGE SET Revision 4125136737e6cbad40ec1313e870b0a22a1c4c70

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 310 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/310/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:59:59 + Build duration: 19 min CHANGE SET Revision 4125136737e6cbad40ec1313e870b0a22a1c4c70

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 215 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/215/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 13:10:49 + Build duration: 1 min 12 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 215 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/215/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 13:10:49 + Build duration: 1 min 12 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 175 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/175/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 10 Sep 2016 12:57:45 + Build duration: 13 min CHANGE SET No ch

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 175 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/175/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 10 Sep 2016 12:57:45 + Build duration: 13 min CHANGE SET No ch

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 208 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/208/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:59:39 + Build duration: 1 min 57 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 208 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/208/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:59:39 + Build duration: 1 min 57 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 214 - Failure!

2016-09-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/214/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:54:58 + Build duration: 4 min 47 sec CHANGE SET Revision 74ba08b57036ce9faacfac1459c230303

Re: Review Request 128680: [KCharSelect] Add ToolButton for disabling characters not available in selected font

2016-09-10 Thread Andreas Kainz
> On Sept. 4, 2016, 2:34 vorm., Christoph Feck wrote: > > Andreas, any idea which icon the action could use? I would use visibility and hint to show/hide the font's that are not available in the selected font. will the font change to "not selected" grayed out when you show all characters also

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 207 - Failure!

2016-09-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/207/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:54:58 + Build duration: 50 sec CHANGE SET Revision 9ac539cf4f8220a200b6eb4cf8885ed488129d83 by sc

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 209 - Unstable!

2016-09-10 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/209/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:40:48 + Build duration: 7 min 25 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 174 - Failure!

2016-09-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/174/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 10 Sep 2016 12:21:35 + Build duration: 33 sec CHANGE SET Revis

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 101 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:06:45 + Build duration: 7 min 7 sec CHANGE SET No changes JUNIT RESULTS Name: (root) F

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 101 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:06:45 + Build duration: 7 min 7 sec CHANGE SET No changes JUNIT RESULTS Name: (root) F

Jenkins-kde-ci: kcmutils master kf5-qt5 » Linux,gcc - Build # 70 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcmutils%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/70/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:18:30 + Build duration: 1 min 19 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kcmutils master kf5-qt5 » Linux,gcc - Build # 70 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcmutils%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/70/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:18:30 + Build duration: 1 min 19 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 112 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/112/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:05:11 + Build duration: 6 min 0 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 112 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/112/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:05:11 + Build duration: 6 min 0 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 206 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/206/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:51:53 + Build duration: 7 min 34 sec CHANGE SET Revision 9581e05813ac8b15cff51ba6b6fd9b5135837143 b

Jenkins-kde-ci: kxmlgui master stable-kf5-qt5 » Linux,gcc - Build # 82 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kxmlgui%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/82/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:55:12 + Build duration: 2 min 48 sec CHANGE SET Revision 17164ba33cda0063f3472d1d2572a27c

Jenkins-kde-ci: kxmlgui master stable-kf5-qt5 » Linux,gcc - Build # 82 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kxmlgui%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/82/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:55:12 + Build duration: 2 min 48 sec CHANGE SET Revision 17164ba33cda0063f3472d1d2572a27c

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 206 - Fixed!

2016-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/206/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:51:53 + Build duration: 7 min 34 sec CHANGE SET Revision 9581e05813ac8b15cff51ba6b6fd9b5135837143 b

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 100 - Failure!

2016-09-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/100/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:42:01 + Build duration: 13 min CHANGE SET Revision c53bd7f8caa687ebcb159e3292b2ac70e92163df by sc

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 111 - Unstable!

2016-09-10 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/111/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:44:33 + Build duration: 1 min 54 sec CHANGE SET Revision 5f45fbe8e392c710984b741eb2cf9

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 114 - Still Unstable!

2016-09-10 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/114/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:44:33 + Build duration: 2 min 5 sec CHANGE SET Revision 5f45fbe8e392c710984b741eb2cf9750c0d55

Jenkins-kde-ci: kxmlgui master stable-kf5-qt5 » Linux,gcc - Build # 81 - Still Failing!

2016-09-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kxmlgui%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/81/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:41:05 + Build duration: 2 min 52 sec CHANGE SET No changes

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 113 - Still Unstable!

2016-09-10 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/113/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:33:47 + Build duration: 2 min 2 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kxmlgui master stable-kf5-qt5 » Linux,gcc - Build # 80 - Failure!

2016-09-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kxmlgui%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/80/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:23:19 + Build duration: 4 min 47 sec CHANGE SET No changes

Jenkins-kde-ci: kcmutils master kf5-qt5 » Linux,gcc - Build # 69 - Failure!

2016-09-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcmutils%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/69/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:26:25 + Build duration: 7.6 sec CHANGE SET Revision 134dc2ac5f45bcffcbf440c45d0446792f58c1fb by