Re: Review Request 128581: Make the default KMessageBoxDontAskAgainMemoryStorage save to QSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128581/#review98079 --- src/kmessagebox_p.cpp (line 45)

Re: Review Request 128581: Make the default KMessageBoxDontAskAgainMemoryStorage save to QSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128581/#review98078 --- Looks good to me. I'll leave it to David or whoever maintains

Re: Review Request 128590: Let kpackagetool5 generate appstream information for kpackage components

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128590/ --- (Updated Aug. 4, 2016, 2:38 a.m.) Status -- This change has been mar

Re: Review Request 128533: Create a test that validates projects' appstream information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128533/#review98075 --- ping? - Aleix Pol Gonzalez On July 28, 2016, 5:15 p.m., Al

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128595/#review98074 --- looks good. I have no idea how much a stone is. src/mass.cp

Re: Review Request 128581: Make the default KMessageBoxDontAskAgainMemoryStorage save to QSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128581/ --- (Updated Aug. 3, 2016, 10:12 p.m.) Review request for KDE Frameworks, Chr

Re: Review Request 128581: Make the default KMessageBoxDontAskAgainMemoryStorage save to QSettings

> On Aug. 3, 2016, 5:26 a.m., Kevin Ottens wrote: > > You also tested with kmessageboxtest, right? Yes, though being a manual test it's always a bit hard to know if it's working, it seems to be fine imho. > On Aug. 3, 2016, 5:26 a.m., Kevin Ottens wrote: > > src/kmessagebox_p.cpp, line 94 > >

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 121 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/121/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 03 Aug 2016 21:01:34 + Build duration: 6 min 2 sec CHANGE SET Revisi

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128595/#review98070 --- src/unit.h (line 87)

Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128595/ --- Review request for KDE Frameworks and David Edmundson. Repository: kunitc

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/#review98068 --- src/widgets/fileundomanager.cpp (line 421)

Review Request 128594: Add a kapptemplate for Plasma Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128594/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: p

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

> On Aug. 3, 2016, 4:50 p.m., Anthony Fieroni wrote: > > src/platforms/xcb/kwindowsystem.cpp, line 500 > > > > > > This line must be > > if (s_d && wasCompositing != s_d->compositingEnable) { why do you thin

Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/ --- (Updated Aug. 3, 2016, 11:33 a.m.) Review request for KDE Frameworks, Gar

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128576/#review98056 --- src/platforms/xcb/kwindowsystem.cpp (line 500)

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

> On Aug. 3, 2016, 2:02 nachm., Kai Uwe Broulik wrote: > > kwindowsystem master fails to build: > > > > kwindowsystem/src/platforms/xcb/kwindowsystem.cpp:441:48: error: ‘class > > NETEventFilter’ has no member named ‘compositingEnabled’ > > const bool wasCompositing = s_d ? s_d->compos

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

> On Aug. 3, 2016, 4:02 p.m., Kai Uwe Broulik wrote: > > kwindowsystem master fails to build: > > > > kwindowsystem/src/platforms/xcb/kwindowsystem.cpp:441:48: error: ‘class > > NETEventFilter’ has no member named ‘compositingEnabled’ > > const bool wasCompositing = s_d ? s_d->composit

Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/#review98052 --- src/converter.cpp (line 75)

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128576/#review98051 --- kwindowsystem master fails to build: kwindowsystem/src/platf

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 51 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/51/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 03 Aug 2016 13:18:34 + Build duration: 5 min 20 sec CHANGE SET No chan

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 51 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/51/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 03 Aug 2016 13:18:34 + Build duration: 5 min 20 sec CHANGE SET No chan

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

> On Aug. 3, 2016, 7:38 a.m., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I see here is that if a custom icon l

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

> On Aug. 3, 2016, 7:38 a.m., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I see here is that if a custom icon l

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

> On Aug. 3, 2016, 7:38 vorm., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I see here is that if a custom icon

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

> On Aug. 3, 2016, 7:38 a.m., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I see here is that if a custom icon l

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

> On Aug. 3, 2016, 7:38 a.m., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I see here is that if a custom icon l

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 51 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/51/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 03 Aug 2016 11:06:32 + Build duration: 9 min 20 sec CHANGE SET Revision 3000e

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 50 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/50/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 03 Aug 2016 11:06:32 + Build duration: 9 min 40 sec CHANGE SET Revisi

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 51 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/51/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 03 Aug 2016 11:06:32 + Build duration: 9 min 20 sec CHANGE SET Revision 3000e

Re: Review Request 128579: Use KPackage to install Plasma Packages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128579/ --- (Updated Aug. 3, 2016, 11:06 a.m.) Status -- This change has been ma

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/ --- (Updated Aug. 3, 2016, 11:05 a.m.) Status -- This change has been ma

Re: Review Request 128590: Let kpackagetool5 generate appstream information for kpackage components

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128590/ --- (Updated Aug. 3, 2016, 1:03 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/#review98044 --- Can we have an autotest for this custom iconloader case? - K

Re: Review Request 128588: Make it possible to load metadata.json file from kpackagetool5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128588/ --- (Updated Aug. 3, 2016, 10:50 a.m.) Status -- This change has been ma

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 49 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/49/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 03 Aug 2016 09:35:00 + Build duration: 6 min 49 sec CHANGE SET Revisi

Re: Low quality input country flags

> I don't understand this bug, are you saying flags of France and Romania are shown differently even if the png files have the same size? Of course that the png size is the same, but the France flag doesn't fill the whole canvas. As a result of this, the flag seems smaller when displayed in the pa

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 50 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/50/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 03 Aug 2016 09:35:00 + Build duration: 3 min 9 sec CHANGE SET Revision 4d355

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128576/ --- (Updated Aug. 3, 2016, 11:34 a.m.) Status -- This change has been ma

Re: Review Request 128572: [autotest] Extend ThemeTest with a case for compositing changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128572/ --- (Updated Aug. 3, 2016, 11:28 a.m.) Status -- This change has been ma

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128576/#review98041 --- Ship it! Ship It! - Marco Martin On Aug. 2, 2016, 12:11

Re: Review Request 128572: [autotest] Extend ThemeTest with a case for compositing changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128572/#review98040 --- Ship it! Ship It! - Marco Martin On Aug. 2, 2016, 8:53

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/#review98039 --- Ship it! Ship It! - Marco Martin On Aug. 2, 2016, 9:11

Re: Review Request 128579: Use KPackage to install Plasma Packages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128579/#review98038 --- Ship it! Ship It! - Marco Martin On Aug. 2, 2016, 4:26

Re: Review Request 128588: Make it possible to load metadata.json file from kpackagetool5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128588/#review98037 --- Ship it! Ship It! - Marco Martin On Aug. 3, 2016, 12:56

Re: Review Request 128590: Let kpackagetool5 generate appstream information for kpackage components

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128590/#review98036 --- Fix it, then Ship it! can't really comment on appstream re

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/#review98035 --- Why does it break for SNIs? It first tries QIcon::fromTheme a