Re: Review Request 128510: KNewFileMenu: fix copying template file from embedded resource

2016-07-23 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128510/#review97785 --- I wonder if this could be fixed in the lower stack. - Chinmo

Review Request 128510: KNewFileMenu: fix copying template file from embedded resource

2016-07-23 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128510/ --- Review request for KDE Frameworks, Chinmoy Ranjan Pradhan and David Faure.

Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

2016-07-23 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/#review97779 --- src/value.h (line 121)

Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

2016-07-23 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/#review97778 --- It seems good to me. If you are not told to hold this patch

Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

2016-07-23 Thread Garret Wassermann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/ --- (Updated July 23, 2016, 5 a.m.) Review request for KDE Frameworks and Joh

Jenkins-kde-ci: kio master stable-kf5-qt5 ยป Linux,gcc - Build # 147 - Unstable!

2016-07-23 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/147/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 23 Jul 2016 07:23:23 + Build duration: 6 min 42 sec CHANGE SET Revision ea8a1c25dea0accea7a77f529647f2ac45

Re: Review Request 128477: Do not delete system relevant files in tests (if we might succeed)

2016-07-23 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128477/ --- (Updated July 23, 2016, 7:23 a.m.) Status -- This change has been ma