Re: Review Request 128465: KIconLoader: massive speed improvement for loading unavailable icons

2016-07-17 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128465/#review97510 --- Fix it, then Ship it! Looks much better with one hash! s

Re: Review Request 128465: KIconLoader: massive speed improvement for loading unavailable icons

2016-07-17 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128465/#review97504 --- Ship it! Ship It! - Michael Pyne On July 17, 2016, 8:14

Re: [kde-community] Usage of QNetworkAccessManager

2016-07-17 Thread Richard Moore
On 14 July 2016 at 17:38, Thiago Macieira wrote: > On quinta-feira, 14 de julho de 2016 18:33:37 PDT Ben Cooksley wrote: > > > Unfortunately, from it's first iteration in Qt 4 QNetworkAccessManager > > w > ​e ​ > as shipped with a severe and fundamental defect in that it does not > > follow HTTP

Re: Review Request 128465: KIconLoader: massive speed improvement for loading unavailable icons

2016-07-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128465/ --- (Updated July 17, 2016, 8:14 p.m.) Review request for KDE Frameworks, Chr

Re: Review Request 128465: KIconLoader: massive speed improvement for loading unavailable icons

2016-07-17 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128465/#review97502 --- I see what you mean about the QHash suggestion. It might be

Re: Review Request 128465: KIconLoader: massive speed improvement for loading unavailable icons

2016-07-17 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128465/#review97496 --- src/kiconloader.cpp (line 1714)

Re: Review Request 128465: KIconLoader: massive speed improvement for loading unavailable icons

2016-07-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128465/ --- (Updated July 17, 2016, 11:26 a.m.) Review request for KDE Frameworks and