Re: Review Request 128465: KIconLoader: massive speed improvement for loading unavailable icons

> On jul 16, 2016, 9:44 p.m., Mark Gaiser wrote: > > src/kiconloader.cpp, lines 342-345 > > > > > > I don't know if this is as you intent it. > > > > The call mLastUnknownIconCheck.start(); starts the ti

Re: Review Request 128465: KIconLoader: massive speed improvement for loading unavailable icons

> On July 16, 2016, 9:44 p.m., Mark Gaiser wrote: > > src/kiconloader.cpp, lines 342-345 > > > > > > I don't know if this is as you intent it. > > > > The call mLastUnknownIconCheck.start(); starts the t

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 68 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/68/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 16 Jul 2016 21:21:52 + Build duration: 2 min 14 sec CHANGE SET Revision 90b6624754371d6d524753c7353

Re: Review Request 128465: KIconLoader: massive speed improvement for loading unavailable icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128465/#review97486 --- Just a small nitpick. I like your solution, nicely done! sr

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 67 - Aborted!

GENERAL INFO BUILD ABORTED Build URL: https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/67/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 16 Jul 2016 20:53:22 + Build duration: 26 min CHANGE SET Revision 90b6624754371d6d524753c73536311492

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 143 - Aborted!

GENERAL INFO BUILD ABORTED Build URL: https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/143/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 16 Jul 2016 20:53:23 + Build duration: 26 min CHANGE SET Revision b81bbb87f69a7daef8539a8a2c308d18b

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 102 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/102/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 16 Jul 2016 20:53:22 + Build duration: 6 min 44 sec CHANGE SET Revision f

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 102 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/102/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 16 Jul 2016 20:53:22 + Build duration: 6 min 44 sec CHANGE SET Revision f

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 104 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/104/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 16 Jul 2016 20:53:23 + Build duration: 3 min 58 sec CHANGE SE

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 104 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/104/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 16 Jul 2016 20:53:23 + Build duration: 2 min 23 sec CHANGE SET Re

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 84 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/84/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 16 Jul 2016 20:53:23 + Build duration: 3 min 33 sec CHANGE SET Revision c0638c81bc98f3ab123e96fa8da7545c8196c

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 68 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/68/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 16 Jul 2016 20:53:22 + Build duration: 2 min 14 sec CHANGE SET Revision 90b6624754371d6d524753c73536311492

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

> On June 14, 2016, 11:10 a.m., René J.V. Bertin wrote: > > sublime/kwidgetstyleselector.cpp, lines 110-112 > > > > > > This works on OS X using the Cocoa QPA, but crashes because of a NULL > > `this` pointer wi

Re: Review Request 128466: Rename Checksums tab to Integrity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128466/#review97484 --- Ship it! Ship It! - Ragnar Thomsen On July 16, 2016, 2:

Re: Raising the requirement to Qt 5.5 ?

Hi, As usual, I'm +1 for increasing the version we depend on. It would be cool if we were able to contact people/projects outside our community that use KF5. Jens of Meeting C++ held a small vote on Twitter regarding which version of Qt his followers use [1]. The results were as follows: 22% -

Re: Review Request 128466: Rename Checksums tab to Integrity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128466/#review97482 --- Ship it! Good idea! - Emmanuel Pescosta On July 16, 201

Re: Review Request 128466: Rename Checksums tab to Integrity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128466/#review97481 --- Ship it! As someone who proposed this change I obviously t

Re: Raising the requirement to Qt 5.5 ?

Hi, We would also like to use eg. QSurfaceEvent in Plasma which is new in 5.5. Cheers,  Kai Uwe  ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Raising the requirement to Qt 5.5 ?

We decided some time ago to support the last three minor Qt 5 release. Qt 5.7 was released on 16th June 2016, only 3 months after Qt 5.6 was released on 16th March 2016 (and 1 year after 5.5), but if we apply the above rule, it would mean we can drop Qt 5.4 support and require Qt 5.5. Of course

Re: Review Request 128465: KIconLoader: massive speed improvement for loading unavailable icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128465/#review97478 --- I like the idea, and the code changes LGTM. But I think the a

Re: Review Request 128464: Allow scrolling in config windows for small screens

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/ --- (Updated July 16, 2016, 2:40 p.m.) Review request for KDE Frameworks and

Re: Review Request 128466: Rename Checksums tab to Integrity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128466/ --- (Updated July 16, 2016, 12:35 p.m.) Review request for KDE Frameworks, KD

Re: Review Request 128466: Rename Checksums tab to Integrity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128466/#review97475 --- This suggestion sounds reasonable. I like it. - Gregor Mi

Review Request 128466: Rename Checksums tab to Integrity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128466/ --- Review request for KDE Frameworks, KDE Usability and Dominik Haumann. Rep

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

> On July 11, 2016, 9:43 a.m., Dominik Haumann wrote: > > Looks good to me. > > > > I suggest making a the calculated checksum a KSqueezedTextLabel [1], this > > way the checksum does not break the layout (in one of the animated gifs, > > the width of the dialog changes). > > [1] > > https://

Re: Review Request 128464: Allow scrolling in config windows for small screens

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/#review97474 --- I just found out one minor issue: the config window now appea

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/#review97473 --- Ping? (String freeze for frameworks is next Saturday, right?

Re: Review Request 128427: Make sure ECMGeneratePriFile.cmake behaves like the rest of ECM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128427/#review97471 --- Ship it! Ship It! - David Faure On July 12, 2016, 12:21

Re: Review Request 128464: Allow scrolling in config windows for small screens

> On July 16, 2016, 9:53 a.m., Sune Vuorela wrote: > > looks good. > > Olivier Churlaud wrote: > Who should provide the ship it flag? I don't know who is the maintainer... if no one else gives a more formal shipit by monday, consider this a shipit. - Sune ---

Re: Review Request 128464: Allow scrolling in config windows for small screens

> On July 16, 2016, 11:53 a.m., Sune Vuorela wrote: > > looks good. Who should provide the ship it flag? I don't know who is the maintainer... - Olivier --- This is an automatically generated e-mail. To reply, visit: https://git.reviewb

Re: Review Request 128464: Allow scrolling in config windows for small screens

> On July 16, 2016, 1:06 a.m., Olivier Churlaud wrote: > > Same patch should be applied to Konversation. I think you need to submit i to konversation as well, then. - Sune --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 128464: Allow scrolling in config windows for small screens

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/#review97467 --- looks good. - Sune Vuorela On July 16, 2016, 12:52 a.m., O

Review Request 128465: KIconLoader: massive speed improvement for loading unavailable icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128465/ --- Review request for KDE Frameworks, Christoph Feck, David Rosca, Michael Pyn