Re: Review Request 126131: Don't delete gl texture twice in thumbnail

> On Nov. 22, 2015, 1:24 p.m., Alex Merry wrote: > > Ship It! > > Mindaugas Baranauskas wrote: > Seems that with this patch KDE Plasma crash more often: > https://bugs.kde.org/show_bug.cgi?id=357895#c22 > > David Edmundson wrote: > @Mindaugas > > Can you try this patch now th

Re: Review Request 128464: Allow scrolling in config windows for small screens

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/#review97455 --- Same patch should be applied to Konversation. - Olivier Chur

Review Request 128464: Allow scrolling in config windows for small screens

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/ --- Review request for KDE Frameworks. Bugs: 360260 and 362234 https://bu

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

> On Nov. 22, 2015, 1:24 p.m., Alex Merry wrote: > > Ship It! > > Mindaugas Baranauskas wrote: > Seems that with this patch KDE Plasma crash more often: > https://bugs.kde.org/show_bug.cgi?id=357895#c22 @Mindaugas Can you try this patch now that 1e196fdfb2a6eaf1664e1155c086616d55c6712b w

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 101 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/101/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 15 Jul 2016 20:12:52 + Build duration: 6 min 22 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 103 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/103/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 15 Jul 2016 20:12:52 + Build duration: 6 min 21 sec CHANGE SET Re

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 103 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/103/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 15 Jul 2016 20:12:52 + Build duration: 8 min 19 sec CHANGE SE

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 51 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jul 2016 17:57:09 + Build duration: 2 min 44 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 51 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jul 2016 17:57:09 + Build duration: 2 min 44 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 50 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/50/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jul 2016 16:31:02 + Build duration: 3 min 47 sec CHANGE SET Revision 981585082d2a6a79fc8c9cceb2d8cac

Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/ --- (Updated July 15, 2016, 4:30 p.m.) Status -- This change has been ma

Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/ --- (Updated July 15, 2016, 6:13 p.m.) Review request for KDE Frameworks, Kai

Re: Review Request 125830: Read protocol info from plugin metadata

> On July 15, 2016, 8:35 a.m., David Faure wrote: > > The problem with this change is that klauncher no longer recognizes freshly > > installed kioslaves. > > > > Testcase: > > $ git clone g...@github.com:shortstheory/staging-kioslave > > $ compile and install > > $ kioclient5 list stash:/ > >

Re: Review Request 128458: KProtocolInfo: refill cache to find newly installed protocols

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128458/#review97446 --- Given we refill the cache now if some protocol is not found,

Re: Review Request 125830: Read protocol info from plugin metadata

> On July 15, 2016, 8:35 a.m., David Faure wrote: > > The problem with this change is that klauncher no longer recognizes freshly > > installed kioslaves. > > > > Testcase: > > $ git clone g...@github.com:shortstheory/staging-kioslave > > $ compile and install > > $ kioclient5 list stash:/ > >

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128398/#review97444 --- I'd recommend making a new unittest with simply a QStandardIt

Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/#review97443 --- autotests/kcollapsiblegroupbox_test.cpp (line 54)

Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/#review97442 --- Ship it! Ship It! - David Edmundson On July 9, 2016, 11

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 102 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/102/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 15 Jul 2016 10:52:23 + Build duration: 6 min 22 sec CHANGE SET Re

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 102 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/102/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 15 Jul 2016 10:52:23 + Build duration: 8 min 23 sec CHANGE SE

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 135 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/135/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jul 2016 09:28:43 + Build duration: 11 min CHANGE SET Revision e45e48c8a9512319e55277a9f4ca25102c20e7e6

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 135 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/135/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jul 2016 09:28:43 + Build duration: 11 min CHANGE SET Revision e45e48c8a9512319e55277a9f4ca25102c20e7e6

Re: Review Request 125830: Read protocol info from plugin metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125830/#review97430 --- The problem with this change is that klauncher no longer reco

Review Request 128458: KProtocolInfo: refill cache to find newly installed protocols

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128458/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: kio

Reminder: Please update kde-build-metadata when making changes to repository branch use

Hi all, Currently there are a series of build breakages on build.kde.org due to out of date build metadata. Just a reminder: before beginning ports of projects from Qt 4 to KF5, you need to: a) Ensure there is a Qt 4 branch (last stable release will do) b) Update kde-build-metadata appropriately

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

> On July 14, 2016, 1:14 p.m., Hannah von Reth wrote: > > sublime/kwidgetstyleselector.cpp, line 43 > > > > > > Dont fall back to Windows. > > Windows is the win3.11 like style. > > I guess the current one

Review Request 128456: [KNotifications] Re-enable NotifyByLogfile plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128456/ --- Review request for KDE Frameworks. Repository: knotifications Descripti