Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/#review97225 --- +1 This seems to fix the crash on the Ark side. To adapt the

Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/#review97224 --- Can you try to adapt the failing unittest into a new kwidgets

Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/ --- (Updated July 8, 2016, 9:29 p.m.) Review request for KDE Frameworks, Davi

Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/ --- Review request for KDE Frameworks, David Edmundson and Elvis Angelaccio.

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/#review97221 --- Compiled and tested on archlinux: it fixed https://sourcefor

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated July 8, 2016, 1:51 p.m.) Status -- This change has been mar

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated July 8, 2016, 12:38 p.m.) Review request for KDE Frameworks, KDE

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/ --- (Updated July 8, 2016, 12:24 p.m.) Review request for KDE Frameworks and

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/#review97213 --- I think this would fix that as well ? https://bugs.kde.org/s

Re: Is it able to make kservice's weightedOffers public access?

On vendredi 8 juillet 2016 09:04:54 CEST zhaixiang wrote: > KService::List services; > const KServiceOfferList offers = > KServiceTypeTrader::weightedOffers("Application"); > > KServiceOfferList::const_iterator itOff = offers.begin(); > for (; itOff != offers.end(); ++itOff) { > services.appe

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/ --- (Updated July 8, 2016, 10:52 a.m.) Review request for KDE Frameworks and

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/#review97193 --- src/kiconengine.cpp (line 164)

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

> On July 7, 2016, 9:59 p.m., David Faure wrote: > > autotests/kiconengine_unittest.cpp, line 69 > > > > > > What's the problem if name() returns "invalid-icon-name" here? ``` bool QIcon::hasThemeIcon(const QStri

Re: Review Request 128172: Allow overriding libexec dir from environment variable at runtime.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128172/ --- (Updated July 8, 2016, 8:27 a.m.) Status -- This change has been dis