Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

2016-07-07 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128398/ --- Review request for KDE Frameworks, Stephen Kelly and Stephen Kelly. Repo

Re: Is it able to make kservice's weightedOffers public access?

2016-07-07 Thread zhaixiang
Hi David, Thanks for your reply! Happy Euro Cup ;-) It might needs to use static KServiceTypeTrader::weightedOffers(const QString &serviceType) to get KServiceOfferList offers, for example, https://github.com/isoft-linux/plasma-workspace/blob/Chinese-word-segmentation/runners/services/servicerun

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 76 - Fixed!

2016-07-07 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/76/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 08 Jul 2016 00:00:31 + Build duration: 5 min 26 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 76 - Fixed!

2016-07-07 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/76/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 08 Jul 2016 00:00:31 + Build duration: 5 min 26 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: kcrash master stable-kf5-qt5 » Linux,gcc - Build # 68 - Failure!

2016-07-07 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcrash%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/68/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 08 Jul 2016 00:00:31 + Build duration: 10 sec CHANGE SET No changes _

Re: Review Request 128103: Add license texts for KAboutLicense ; add LGPL v2.1 as separate license.

2016-07-07 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128103/ --- (Updated July 7, 2016, 11:57 p.m.) Status -- This change has been ma

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

2016-07-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/#review97181 --- Thanks for looking into this! autotests/kiconengine_unittes

Re: Review Request 128283: Add checksums tab to the properties dialog

2016-07-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review97178 --- Fix it, then Ship it! src/widgets/kpropertiesdialog.cpp (

Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

2016-07-07 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/ --- Review request for KDE Frameworks. Repository: kiconthemes Description

Re: KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless

2016-07-07 Thread Kevin Ottens
Hello, On Saturday, 2 July 2016 12:23:31 CEST David Faure wrote: > > [...] > > We still need to handle the migration when/if the user installs > > FrameworksIntegration no? Suddenly all his MessageBoxes will be back > > without any apparent reason. > > True. Although this feels like a corner case

Re: Is it able to make kservice's weightedOffers public access?

2016-07-07 Thread David Faure
On mardi 28 juin 2016 20:39:40 CEST Sune Vuorela wrote: > On 2016-06-28, Leslie Zhai wrote: > > Hi KDE developers, > > > > It might needs to use static KServiceTypeTrader::weightedOffers(const > > QString &serviceType) to get KServiceOfferList offers, for example, > > I'll let David Faure (kserv

Re: kded's cmake package

2016-07-07 Thread David Faure
On vendredi 1 juillet 2016 14:37:59 CEST Harald Sitter wrote: > On Fri, Jul 1, 2016 at 1:34 PM, Aleix Pol wrote: > > On Wed, Jun 29, 2016 at 11:22 AM, Harald Sitter wrote: > >> Hola! > >> > >> So, I just noticed that KDED's cmake package is inconsistently named. > >> > >> cmake/KF5DocTools/ > >