Re: Review Request 127835: KHTML: Try again to fix Coverity memory leak in CSS background property

2016-05-23 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127835/ --- (Updated May 24, 2016, 4:43 a.m.) Status -- This change has been mar

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-05-23 Thread Michael Pyne
> On May 23, 2016, 11:20 a.m., David Faure wrote: > > Please note that: > > * the Q_BYTE_ORDER change was reverted, since it made the wallet storage > > incompatible with previous releases. This needs further analysis in order > > to improve the code while retaining compat. > > * kwallet is def

Re: Review Request 127835: KHTML: Try again to fix Coverity memory leak in CSS background property

2016-05-23 Thread Michael Pyne
> On May 23, 2016, 10:14 p.m., Andrea Iacovitti wrote: > > You are not too paranoid, you are right and the patch looks correct to me > > and can be shipped! > > However i think i have finally found a way to simplify this code. > > > > We have to distinguish between a single value and a value li

Review Request 127997: Extend KNS3::Entry public API

2016-05-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127997/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstu

Re: Review Request 127835: KHTML: Try again to fix Coverity memory leak in CSS background property

2016-05-23 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127835/#review95730 --- You are not too paranoid, you are right and the patch looks c

Re: kptyprocesstest is still flaky

2016-05-23 Thread Albert Astals Cid
El diumenge, 22 de maig de 2016, a les 15:59:59 CEST, David Faure va escriure: > The CI for KF5 is now all green except for kpty which is still flaky. > > https://build.kde.org/view/Frameworks%20kf5-qt5/job/kpty%20master%20stable-k > f5-qt5/42/PLATFORM=Linux,compiler=gcc/testReport/junit/%28root%2

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-23 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated May 23, 2016, 10:23 p.m.) Review request for KDE Software on Mac

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-23 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review95726 --- I've tweaked defaults provided by the theme plugin a bit more

Re: Review Request 127887: Improve usage of Qt APIs

2016-05-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127887/ --- (Updated May 23, 2016, 10:50 a.m.) Status -- This change has been ma

Re: Review Request 127925: KWalletd migration: fix error handling.

2016-05-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127925/ --- (Updated May 23, 2016, 6:58 p.m.) Status -- This change has been mar

Re: Review Request 127925: KWalletd migration: fix error handling.

2016-05-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127925/#review95723 --- Ship it! Ship It! - Martin Klapetek On May 15, 2016, 11

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 44 - Unstable!

2016-05-23 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/44/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 23 May 2016 12:37:24 + Build duration: 4 min 7 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 56 - Unstable!

2016-05-23 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/56/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 23 May 2016 12:39:59 + Build duration: 2 min 8 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 36 - Fixed!

2016-05-23 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/36/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 23 May 2016 12:34:49 + Build duration: 2 min 16 sec CHANGE SET Revision e710914566fe51e99dbc32145e62f187092

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 36 - Fixed!

2016-05-23 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/36/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 23 May 2016 12:34:49 + Build duration: 2 min 16 sec CHANGE SET Revision e710914566fe51e99dbc32145e62f187092

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 37 - Fixed!

2016-05-23 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/37/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 23 May 2016 12:34:49 + Build duration: 2 min 24 sec CHANGE SET Revision e710914566fe51e99dbc32145e62

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 37 - Fixed!

2016-05-23 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/37/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 23 May 2016 12:34:49 + Build duration: 2 min 24 sec CHANGE SET Revision e710914566fe51e99dbc32145e62

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-05-23 Thread Stephen Kelly
> On March 28, 2016, 5:14 p.m., Stephen Kelly wrote: > > Do you still have the sample application you made to test/verify this? I'd > > like to try it and it should probably be committed too. > > Pino Toscano wrote: > No I don't :-/ I remember it was just removing indexes with associated >

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-05-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127833/#review95717 --- Please note that: * the Q_BYTE_ORDER change was reverted, sin

Re: Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux, gcc - Build # 35 - Unstable!

2016-05-23 Thread David Faure
On lundi 23 mai 2016 02:44:58 CEST no-re...@kde.org wrote: > CHANGE SET > Revision 47af3e31625ec3326f5c192d629a9848edfd0817 by aleixpol: (Print the > failing plugin when notifying a cast warning) change: edit > src/lib/plugin/kpluginmetadata.cpp Hi Aleix, The test failure seems related to the com

Re: LGPL for Breeze QStyle and qtquickcontrols?

2016-05-23 Thread Martin Graesslin
On Sunday, May 22, 2016 12:22:28 AM CEST Jaroslaw Staniek wrote: > So we, in KDE, lack LGPL style code for our de-facto official look and feel. This is the crucial point. Breeze is not the de-facto official look and feel of KDE. It's the look and feel of Plasma. Applications shouldn't use it. Ap

Re: KConfig compiler. GenerateProperties and Mutable.

2016-05-23 Thread David Faure
On mardi 10 mai 2016 16:49:57 CEST Aleix Pol wrote: > On Mon, May 9, 2016 at 8:02 PM, Artem Fedoskin wrote: > > Dear KDE developers, > > > > For my GSoC 2016 project at KDE (Lite version of KStars for mobile > > devices) > > I need to access C++ class generated from XML configure file with KConfi