Re: Review Request 127968: kshareddatacache: Fix invalid use of & to avoid unaligned reads

> On Mai 19, 2016, 11:17 nachm., Michael Pyne wrote: > > This is an error upstream in the MurmurHash 1.0 aligned implementation > > (which still contains the error, see > > https://sites.google.com/site/murmurhash/MurmurHashAligned.cpp?attredirects=0 > > ) > > > > In our case KSharedDataCache

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/#review95638 --- Ship it! Sorry for the hard review. - Martin Gräßlin On

Re: Review Request 127972: Always update the Predicate parser from y/l sources

> On May 19, 2016, 10:30 p.m., Aleix Pol Gonzalez wrote: > > This has been like this for years. Has any of the premises changed? > > Michael Pyne wrote: > I think it's a good idea, if only to keep up with changes to the > generated sources to account for things like undefined behavior fixes

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

> On May 20, 2016, 3:50 a.m., Michael Pyne wrote: > > I've looked at the code itself and it seems reasonable, so from that > > perspective and given the length of time there's been no -1's, I think it's > > safe to commit. > > > > However you mentioned in the description that this isn't safe t

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

> On May 20, 2016, 3:50 a.m., Michael Pyne wrote: > > I've looked at the code itself and it seems reasonable, so from that > > perspective and given the length of time there's been no -1's, I think it's > > safe to commit. > > > > However you mentioned in the description that this isn't safe t

Re: Review Request 127972: Always update the Predicate parser from y/l sources

> On May 19, 2016, 10:30 p.m., Aleix Pol Gonzalez wrote: > > This has been like this for years. Has any of the premises changed? I think it's a good idea, if only to keep up with changes to the generated sources to account for things like undefined behavior fixes, fixes for new compiler warnin

Re: Review Request 127973: Fix race in which the file containing the X11 cookie has the wrong permissions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127973/#review95633 --- Ship it! I think a comment to the intent would be appropri

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127747/#review95632 --- I've looked at the code itself and it seems reasonable, so fr

Re: Review Request 127973: Fix race in which the file containing the X11 cookie has the wrong permissions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127973/#review95631 --- https://codereview.qt-project.org/#/c/159689/ would fix it to

Re: Review Request 127973: Fix race in which the file containing the X11 cookie has the wrong permissions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127973/ --- (Updated May 19, 2016, 11:38 p.m.) Review request for KDE Frameworks and

Review Request 127973: Fix window in which the file containing the X11 cookie has the wrong permissions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127973/ --- Review request for KDE Frameworks and David Faure. Repository: kinit De

Re: Review Request 127968: kshareddatacache: Fix invalid use of & to avoid unaligned reads

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127968/#review95630 --- Ship it! This is an error upstream in the MurmurHash 1.0 a

Re: Review Request 127972: Always update the Predicate parser from y/l sources

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95629 --- This has been like this for years. Has any of the premises ch

Review Request 127972: Always update the Predicate parser from y/l sources

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/ --- Review request for KDE Frameworks and Lukáš Tinkl. Repository: solid De

Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127971/ --- (Updated Mai 19, 2016, 9:37 nachm.) Review request for KDE Frameworks and

Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127971/ --- (Updated Mai 19, 2016, 9:35 nachm.) Review request for KDE Frameworks and

Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127971/#review95628 --- +1 src/ktoolbar.cpp (line 815)

Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127971/ --- Review request for KDE Frameworks and Plasma. Repository: kxmlgui Descr

Re: Review Request 127948: Avoid skipping KAuthorized check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127948/ --- (Updated May 19, 2016, 9:19 p.m.) Status -- This change has been mar

Re: Review Request 127948: Avoid skipping KAuthorized check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127948/#review95627 --- Fix it, then Ship it! Excellent, thanks! Just one comment

Re: Review Request 127948: Avoid skipping KAuthorized check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127948/ --- (Updated May 19, 2016, 8:17 p.m.) Review request for KDE Frameworks and M

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 54 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/54/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 19 May 2016 19:46:26 + Build duration: 10 min CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 55 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/55/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 19 May 2016 19:46:26 + Build duration: 9 min 48 sec CHANGE SET Revision 2

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 55 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/55/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 19 May 2016 19:46:26 + Build duration: 2 min 22 sec CHANGE SET Revisi

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 54 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/54/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 19 May 2016 19:46:26 + Build duration: 2 min 14 sec CHANGE SET

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/ --- (Updated May 19, 2016, 7:46 p.m.) Status -- This change has been mar

Review Request 127968: kshareddatacache: Fix invalid use of & to avoid unaligned reads

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127968/ --- Review request for KDE Frameworks, David Faure and Michael Pyne. Reposito

Re: Review Request 127963: Adding missing license

> On May 19, 2016, 3:22 p.m., Martin Gräßlin wrote: > > I think the approach here is wrong. Our frameworks are LGPLv2+. If we have > > files which don't match that we need to either change copyright or remove > > the files. > > Martin Gräßlin wrote: > A check shows that examples/kpart and

Re: Review Request 127959: Adding missing license

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127959/#review95623 --- I would prefer that we properly investigate each of the cases

Re: Review Request 127961: Adding missing license

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127961/#review95621 --- I would prefer that we properly investigate each of the cases

Re: Review Request 127960: Adding missing license

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127960/#review95622 --- I would prefer that we properly investigate each of the cases

Re: Review Request 127963: Adding missing license

> On May 19, 2016, 5:22 p.m., Martin Gräßlin wrote: > > I think the approach here is wrong. Our frameworks are LGPLv2+. If we have > > files which don't match that we need to either change copyright or remove > > the files. > > Martin Gräßlin wrote: > A check shows that examples/kpart and

Re: Review Request 127963: Adding missing license

> On May 19, 2016, 5:22 p.m., Martin Gräßlin wrote: > > I think the approach here is wrong. Our frameworks are LGPLv2+. If we have > > files which don't match that we need to either change copyright or remove > > the files. A check shows that examples/kpart and src/kpart are not built at all.

Re: Review Request 127963: Adding missing license

> On May 19, 2016, 3:25 p.m., Marco Martin wrote: > > ok, let's actually fix this properly > > Marco Martin wrote: > package/packagestructure/servicejob are the ones that should be > relicensed (i would argue they already are, as their corresponding .cpp file > is lgpl 2+ already all the

Re: Review Request 127963: Adding missing license

> On May 19, 2016, 3:25 p.m., Marco Martin wrote: > > ok, let's actually fix this properly package/packagestructure/servicejob are the ones that should be relicensed (i would argue they already are, as their corresponding .cpp file is lgpl 2+ already - Marco ---

Re: Review Request 127963: Adding missing license

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127963/#review95616 --- ok, let's actually fix this properly - Marco Martin On May

Re: Review Request 127963: Adding missing license

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127963/#review95615 --- I think the approach here is wrong. Our frameworks are LGPLv2

Re: Review Request 127963: Adding missing license

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127963/ --- (Updated May 19, 2016, 2:37 p.m.) Status -- This change has been mar

Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127870/#review95613 --- src/scriptengines/qml/plasmoid/appletinterface.h (line 279)

Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127870/#review95612 --- Ship it! Ship It! - Marco Martin On May 8, 2016, 4:15 p

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/#review95609 --- Ship it! Ship It! - Marco Martin On May 4, 2016, 5:06 p

Re: Review Request 127963: Adding missing license

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127963/#review95607 --- Ship it! Ship It! - Marco Martin On May 19, 2016, 1:51

Re: Review Request 127469: Use QQuickWidget for QML KCMs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/#review95608 --- Ship it! I suggest we try it, then see if there are any re

Review Request 127963: Adding missing license

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127963/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On May 17, 2016, 2:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

Review Request 127961: Adding missing license

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127961/ --- Review request for KDE Frameworks. Repository: kdelibs4support Descript

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On May 17, 2016, 8:07 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

Review Request 127960: Adding missing license

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127960/ --- Review request for KDE Frameworks. Repository: kcmutils Description ---

Review Request 127959: Adding missing license

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127959/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >