Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On Май 9, 2016, 3:37 след обяд, Anthony Fieroni wrote: > > Ping. It is ok, now? Martin is there any problems with whis patch? - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/

Re: Review Request 127900: Fix redirection of absolut Urls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127900/#review95439 --- src/atticabasejob.cpp (line 60)

Re: Review Request 127900: Fix redirection of absolut Urls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127900/#review95440 --- Ship it! Ship It! - Jeremy Whiting On May 12, 2016, 11:

Re: Review Request 127817: Don't make KIconThemes depend on Oxygen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127817/#review95436 --- Ship it! Ok, if noone else wants to review, ship it (wait

Re: Review Request 127900: Fix redirection of absolut Urls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127900/ --- (Updated Mai 12, 2016, 5:17 nachm.) Review request for KDE Frameworks, Co

Review Request 127900: Fix redirection of absolut Urls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127900/ --- Review request for KDE Frameworks, Cornelius Schumacher and Kevin Funk. B

Re: Review Request 127887: Improve usage of Qt APIs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127887/#review95428 --- The knewstuff (non moretools) side looks good to me. - Jerem

Re: Review Request 127878: use the "selected" icon mode in file open dialog sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127878/#review95426 --- Ship it! Ship It! - David Edmundson On May 12, 2016, 9:

Re: Review Request 127899: [KCMShell] Honor KAuthorized restrictions

> On Mai 12, 2016, 3:59 nachm., David Edmundson wrote: > > kcmshell/main.cpp, line 95 > > > > > > this line is already doing it. > > > > bool KService::noDisplay() const > > ... > > if (!KAuth

Re: Review Request 127899: [KCMShell] Honor KAuthorized restrictions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127899/ --- (Updated Mai 12, 2016, 4:03 nachm.) Status -- This change has been d

Re: Review Request 127899: [KCMShell] Honor KAuthorized restrictions

> On May 12, 2016, 3:59 p.m., David Edmundson wrote: > > kcmshell/main.cpp, line 95 > > > > > > this line is already doing it. > > > > bool KService::noDisplay() const > > ... > > if (!KAuthor

Re: Review Request 127899: [KCMShell] Honor KAuthorized restrictions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127899/#review95424 --- -2 kcmshell/main.cpp (line 95)

Re: Review Request 127899: [KCMShell] Honor KAuthorized restrictions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127899/#review95423 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 12, 2016,

Re: Review Request 127899: [KCMShell] Honor KAuthorized restrictions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127899/#review95422 --- +1 - Marco Martin On May 12, 2016, 1:59 p.m., Kai Uwe Brou

Review Request 127899: [KCMShell] Honor KAuthorized restrictions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127899/ --- Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools

Re: Review Request 127896: make dbus optional on osx: kauth

> On May 12, 2016, 8:15 a.m., Kåre Särs wrote: > > I think this patch should not include any platform specific defines. > > Disabling DBus requirement on Windows might also be interesting for some > > projects. I propose to do something similar to what is done in kxmlgui to > > disable kglobal

Re: Review Request 127896: make dbus optional on osx: kauth

> On May 12, 2016, 6:15 a.m., Kåre Särs wrote: > > I think this patch should not include any platform specific defines. > > Disabling DBus requirement on Windows might also be interesting for some > > projects. I propose to do something similar to what is done in kxmlgui to > > disable kglobal

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127850/#review95419 --- Fix it, then Ship it! logic is fine, but should not add pu

Re: Review Request 127896: make dbus optional on osx: kauth

> On May 12, 2016, 8:15 a.m., Kåre Särs wrote: > > I think this patch should not include any platform specific defines. > > Disabling DBus requirement on Windows might also be interesting for some > > projects. I propose to do something similar to what is done in kxmlgui to > > disable kglobal

Re: Review Request 127896: make dbus optional on osx: kauth

> On May 12, 2016, 8:15 a.m., Kåre Särs wrote: > > I think this patch should not include any platform specific defines. > > Disabling DBus requirement on Windows might also be interesting for some > > projects. I propose to do something similar to what is done in kxmlgui to > > disable kglobal

Re: Review Request 127896: make dbus optional on osx: kauth

> On May 12, 2016, 6:15 a.m., Kåre Särs wrote: > > I think this patch should not include any platform specific defines. > > Disabling DBus requirement on Windows might also be interesting for some > > projects. I propose to do something similar to what is done in kxmlgui to > > disable kglobal

Re: Review Request 127896: make dbus optional on osx: kauth

> On May 12, 2016, 7:43 a.m., René J.V. Bertin wrote: > > autotests/BackendsManager.cpp, lines 56-60 > > > > > > Ditto, no risk of a build failure on systems where Qt does provide a > > DBus interface? > > Nick

Re: Review Request 127896: make dbus optional on osx: kauth

> On May 12, 2016, 5:43 a.m., René J.V. Bertin wrote: > > CMakeLists.txt, lines 14-18 > > > > > > Am I right that on OS X use of DBus is going to depend on whether or > > not Qt provides the QtDBus component? If

Re: Review Request 127896: make dbus optional on osx: kauth

> On May 12, 2016, 6:15 a.m., Kåre Särs wrote: > > I think this patch should not include any platform specific defines. > > Disabling DBus requirement on Windows might also be interesting for some > > projects. I propose to do something similar to what is done in kxmlgui to > > disable kglobal

Re: Review Request 127878: use the "selected" icon mode in file open dialog sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127878/ --- (Updated May 12, 2016, 9:53 a.m.) Review request for KDE Frameworks and P

Re: Review Request 127878: use the "selected" icon mode in file open dialog sidebar

> On May 11, 2016, 11:03 a.m., David Edmundson wrote: > > src/widgets/kfileitemdelegate.cpp, line 1220 > > > > > > QCommonStyle when rendering CE_ItemViewItem checks for disabled first > > > > QIcon::Mo

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/ --- (Updated May 12, 2016, 8:57 a.m.) Status -- This change has been mar

Review Request 127897: Update documentation of kdoctools_install macro

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127897/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repos

Re: Review Request 127896: make dbus optional on osx: kauth

> On May 12, 2016, 8:15 a.m., Kåre Särs wrote: > > I think this patch should not include any platform specific defines. > > Disabling DBus requirement on Windows might also be interesting for some > > projects. I propose to do something similar to what is done in kxmlgui to > > disable kglobal