Re: Review Request 127896: make dbus optional on osx: kauth

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127896/#review95405 --- I think this patch should not include any platform specific d

Re: Review Request 127896: make dbus optional on osx: kauth

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127896/#review95404 --- Approach looks good to me, though I agree with Rene on making

Re: Review Request 127896: make dbus optional on osx: kauth

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127896/#review95403 --- Forgive me if I'd like to be certain that this isn't disablin

Re: Review Request 127896: make dbus optional on osx: kauth

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127896/#review95402 --- Erm, it seems I did something I shouldn't have done, *inadver

Re: Review Request 127813: Process paths just once

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/#review95399 --- General +1 from me, just two things: 1) Can you split these

Re: Review Request 127896: make dbus optional on osx: kauth

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127896/ --- (Updated May 12, 2016, midnight) Review request for KDE Frameworks, David

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127850/ --- (Updated May 12, 2016, 1:20 a.m.) Review request for KDE Frameworks, Plas

Re: Review Request 127813: Process paths just once

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/#review95393 --- ping? - Aleix Pol Gonzalez On May 5, 2016, 3:02 a.m., Alei

Re: Review Request 127817: Don't make KIconThemes depend on Oxygen

> On May 4, 2016, 11:45 p.m., Albert Astals Cid wrote: > > +1 would i'd like someone else opinion. Ping? - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127817/#review95188 -

Re: Review Request 127887: Improve usage of Qt APIs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127887/ --- (Updated May 12, 2016, 1:01 a.m.) Review request for KDE Frameworks and J

Review Request 127896: make dbus optional on osx: kauth

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127896/ --- Review request for KDE Frameworks, David Edmundson and Martin Gräßlin. Re

Re: Can we have a headersclean check for frameworks?

On Wed, May 11, 2016 at 10:51 PM, Stephen Kelly wrote: > Hi, > > Qt has a headersclean utility which runs each header through the compiler on > its own. That verifies that it doesn't cause certain warnings, can compile > in the presence of certain Qt defines, and includes or forward declares > eve

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 36 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/36/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 May 2016 20:47:51 + Build duration: 2 min 25 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 36 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/36/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 May 2016 20:47:51 + Build duration: 2 min 25 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 29 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/29/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 May 2016 20:42:14 + Build duration: 12 min CHANGE SET No changes JUNIT RESULTS Na

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 35 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/35/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 May 2016 20:46:05 + Build duration: 2 min 5 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 35 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/35/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 May 2016 20:46:05 + Build duration: 2 min 5 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 32 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/32/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 May 2016 20:46:05 + Build duration: 1 min 1 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Can we have a headersclean check for frameworks?

Hi, Qt has a headersclean utility which runs each header through the compiler on its own. That verifies that it doesn't cause certain warnings, can compile in the presence of certain Qt defines, and includes or forward declares everything it should. We don't have such a thing in KF5, but as s

Re: Review Request 127895: Remove unused dependencies and translation handling.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127895/ --- (Updated May 11, 2016, 6:55 p.m.) Status -- This change has been mar

Re: Review Request 127895: Remove unused dependencies and translation handling.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127895/#review95386 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 11, 2016,

Review Request 127895: Remove unused dependencies and translation handling.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127895/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Re: Review Request 127822: address the potential name/case clash of the Attica/Attica and Attica/attica header dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127822/#review95384 --- src/CMakeLists.txt (lines 160 - 163)

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/ --- (Updated May 11, 2016, 12:12 p.m.) Review request for KDE Frameworks and

Re: Review Request 127875: Selected state concept for icons

> On May 11, 2016, 10:52 a.m., David Edmundson wrote: > > src/kiconloader.cpp, line 840 > > > > > > 1) For the unselected case, do you think we want Text and Base rather > > than Window and WindowText? > > f

Re: Review Request 127878: use the "selected" icon mode in file open dialog sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127878/#review95382 --- src/widgets/kfileitemdelegate.cpp (line 1220)

Re: Review Request 127888: use selected icon effect for current KPageView page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127888/#review95381 --- Ship it! - David Edmundson On May 10, 2016, 3:12 p.m., M

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/#review95350 --- src/kiconloader.cpp (line 840)

Re: dbus-less frameworks on osx

On Wed, May 11, 2016 at 6:39 PM, Kevin Funk wrote: > On Wednesday, May 11, 2016 7:38:58 AM CEST Martin Graesslin wrote: >> On Wednesday, May 11, 2016 4:00:45 AM CEST Nick Shaforostoff wrote: >> > hi all! I'm investigating possibility of getting some kde apps to build on >> > osx with vanilla Qt wi

Re: KFilePlacesModelTest

On Saturday 07 May 2016 19:50:36 Michael Pyne wrote: > On Sat, May 7, 2016 14:33:53 David Faure wrote: > > The thing I wonder is... does it really make sense to have a model with > > random ordering? Isn't it a problem for users if their visible list of > > places is different between every run? Or