Re: dbus-less frameworks on osx

On Wednesday, May 11, 2016 7:38:58 AM CEST Martin Graesslin wrote: > On Wednesday, May 11, 2016 4:00:45 AM CEST Nick Shaforostoff wrote: > > hi all! I'm investigating possibility of getting some kde apps to build on > > osx with vanilla Qt without dbus. > > > > would you accept patches that make t

Re: dbus-less frameworks on osx

On Wednesday, May 11, 2016 4:00:45 AM CEST Nick Shaforostoff wrote: > hi all! I'm investigating possibility of getting some kde apps to build on > osx with vanilla Qt without dbus. > > would you accept patches that make that possible? > > for example, i have just built kauth without dbus and i ca

dbus-less frameworks on osx

hi all! I'm investigating possibility of getting some kde apps to build on osx with vanilla Qt without dbus. would you accept patches that make that possible? for example, i have just built kauth without dbus and i can prepare a review request with a (nice) patch for this __

Re: Review Request 126285: OS X build and warning fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126285/ --- (Updated May 10, 2016, 10:06 p.m.) Review request for KDE Software on Mac

Re: Review Request 126285: OS X build and warning fix

> On May 4, 2016, 4:16 p.m., Ivan Čukić wrote: > > Looks good to me - though I can not comment on the OSX API. I must have missed something when generating the patch, the OS X API changes comes from f223ce03d4b94ffbb093fc8be5adf8d968f54434 - Samuel --

Re: Review Request 127887: Improve usage of Qt APIs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127887/#review95365 --- src/core/installation.cpp (line 382)

Re: Review Request 127842: take highlight and highlightedText from proper color group

> On Mai 5, 2016, 8:02 nachm., Kai Uwe Broulik wrote: > > Switching themes no longer properly updates the highlight color, ie. > > switching from Breeze to Honeycomb leaves me with a blue highlight (and > > brokenness in task manager with yellow borders around blue items). Then > > switching t

Re: Review Request 127888: use selected icon effect for current KPageView page

> On May 10, 2016, 5:17 p.m., Emmanuel Pescosta wrote: > > src/kpageview_p.cpp, line 402 > > > > > > option.state & (QStyle::State_Selected | QStyle::State_Active) maybe? > > Marco Martin wrote: > doesn't wo

Re: Review Request 127888: use selected icon effect for current KPageView page

> On May 10, 2016, 3:17 p.m., Emmanuel Pescosta wrote: > > src/kpageview_p.cpp, line 402 > > > > > > option.state & (QStyle::State_Selected | QStyle::State_Active) maybe? doesn't work, if state is QStyle::State_

Review Request 127888: use selected icon effect for current KPageView page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127888/ --- Review request for KDE Frameworks and Plasma. Repository: kwidgetsaddons

Re: Review Request 127842: take highlight and highlightedText from proper color group

> On May 5, 2016, 8:02 p.m., Kai Uwe Broulik wrote: > > Switching themes no longer properly updates the highlight color, ie. > > switching from Breeze to Honeycomb leaves me with a blue highlight (and > > brokenness in task manager with yellow borders around blue items). Then > > switching to

Re: Review Request 127878: use the "selected" icon mode in file open dialog sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127878/#review95355 --- src/filewidgets/kfileplacesview.cpp (line 157)

Re: Review Request 127888: use selected icon effect for current KPageView page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127888/#review95354 --- src/kpageview_p.cpp (line 402)

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

> On May 6, 2016, 4:08 p.m., David Rosca wrote: > > It will also need > > https://quickgit.kde.org/?p=plasma-workspace.git&a=commit&h=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3 > > in Plasma/5.6 > > Aleix Pol Gonzalez wrote: > No, it's already called by `ShellCorona::loadDefaultLayout()`. >

KConfig compiler. GenerateProperties and Mutable.

Dear KDE developers, For my GSoC 2016 project at KDE (Lite version of KStars for mobile devices) I need to access C++ class generated from XML configure file with KConfig compiler from QML. I found in this patch https://git.reviewboard.kde.org/r/123367/ and in the source code of KConfig compiler t

Re: KConfig compiler. GenerateProperties and Mutable.

On Mon, May 9, 2016 at 8:02 PM, Artem Fedoskin wrote: > Dear KDE developers, > > For my GSoC 2016 project at KDE (Lite version of KStars for mobile devices) > I need to access C++ class generated from XML configure file with KConfig > compiler from QML. I found in this patch > https://git.reviewbo

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

> On May 6, 2016, 6:08 p.m., David Rosca wrote: > > It will also need > > https://quickgit.kde.org/?p=plasma-workspace.git&a=commit&h=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3 > > in Plasma/5.6 > > Aleix Pol Gonzalez wrote: > No, it's already called by `ShellCorona::loadDefaultLayout()`. >

Re: Review Request 127875: Selected state concept for icons

> On May 10, 2016, 12:50 p.m., David Edmundson wrote: > > src/kiconloader.cpp, line 839 > > > > > > Aren't we missing an arg? > > > > return QStringLiteral(".ColorScheme-Text {\ > > color:%1;\ >

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/ --- (Updated May 10, 2016, 2:15 p.m.) Review request for KDE Frameworks and P

Review Request 127887: Improve usage of Qt APIs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127887/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstu

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/#review95347 --- src/kiconloader.cpp (line 827)

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/#review95345 --- src/kiconloader.cpp (line 839)

Re: Review Request 127875: Selected state concept for icons

> On May 9, 2016, 10:32 p.m., David Edmundson wrote: > > src/kiconloader.cpp, line 841 > > > > > > we're already passing a highlightedText colour for some reason. > > > > Either: > > - Kiconloader is

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127876/ --- (Updated May 10, 2016, 12:41 p.m.) Review request for KDE Frameworks and

Re: Review Request 127875: Selected state concept for icons

> On May 9, 2016, 10:32 p.m., David Edmundson wrote: > > src/kiconloader.cpp, line 841 > > > > > > we're already passing a highlightedText colour for some reason. > > > > Either: > > - Kiconloader is

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

> On May 9, 2016, 10:22 p.m., Andreas Kainz wrote: > > I can't review the code but this is one of the best features in the past 2 > > years > > +1 from the vdg > > Hugo Pereira Da Costa wrote: > Well, Ship it is a bit premature. > I could not test the patch but: it compiles and code loo

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

> On May 9, 2016, 10:22 p.m., Andreas Kainz wrote: > > I can't review the code but this is one of the best features in the past 2 > > years > > +1 from the vdg > > Hugo Pereira Da Costa wrote: > Well, Ship it is a bit premature. > I could not test the patch but: it compiles and code loo

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

> On May 9, 2016, 10:22 p.m., Andreas Kainz wrote: > > I can't review the code but this is one of the best features in the past 2 > > years > > +1 from the vdg > > Hugo Pereira Da Costa wrote: > Well, Ship it is a bit premature. > I could not test the patch but: it compiles and code loo

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

> On May 9, 2016, 10:22 p.m., Andreas Kainz wrote: > > I can't review the code but this is one of the best features in the past 2 > > years > > +1 from the vdg > > Hugo Pereira Da Costa wrote: > Well, Ship it is a bit premature. > I could not test the patch but: it compiles and code loo

Re: Review Request 127878: use the "selected" icon mode in file open dialog sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127878/ --- (Updated May 10, 2016, 11:57 a.m.) Review request for KDE Frameworks and

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

> On May 9, 2016, 10:22 p.m., Andreas Kainz wrote: > > I can't review the code but this is one of the best features in the past 2 > > years > > +1 from the vdg Well, Ship it is a bit premature. I could not test the patch but: it compiles and code looks sensible. However, there are probably piec

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/ --- (Updated May 10, 2016, 10:56 a.m.) Review request for KDE Frameworks and

Re: Review Request 127875: Selected state concept for icons

> On May 9, 2016, 10:32 p.m., David Edmundson wrote: > > src/kiconloader.cpp, line 311 > > > > > > was createIconImage in the last frameworks? > > > > if so this is an ABI break. > > > > instead

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 28 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 May 2016 10:23:49 + Build duration: 1 min 9 sec CHANGE SET Revision 5f33966bb16e137ef64debbbc64a862f175c

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 28 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 May 2016 10:23:49 + Build duration: 1 min 9 sec CHANGE SET Revision 5f33966bb16e137ef64debbbc64a862f175c

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 28 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 May 2016 10:23:49 + Build duration: 1 min 9 sec CHANGE SET Revision 5f33966bb16e137ef64debbbc64a8

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 28 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 May 2016 10:23:49 + Build duration: 1 min 9 sec CHANGE SET Revision 5f33966bb16e137ef64debbbc64a8

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

> On April 28, 2016, 8:02 a.m., Olivier Churlaud wrote: > > Any other feedback? What should I do? > > Allen Winter wrote: > I suppose I need to find the time to test this out on the actual > api.kde.org machine. can I run it on the old KDE4 kdelibs KDE/4.14 branch? > > Olivier Churlaud wr

Re: Jenkins-kde-ci (many CI failures)

On Sunday 08 May 2016 23:06:02 Ben Cooksley wrote: > On Sun, May 8, 2016 at 2:44 AM, David Faure wrote: > > kdewebkit just failed with "Broken pipe" (the TCP error you mentionned) > > (and kxmlrpcclient failed again with an anongit error). This is like > > playing wack-a-mole... > > Yeah :( Fort

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/#review95322 --- Ship it! Ship It! - David Faure On May 9, 2016, 9:06 p.

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 64 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/64/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 May 2016 07:20:50 + Build duration: 1 min 9 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 64 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/64/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 May 2016 07:20:50 + Build duration: 1 min 9 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 27 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 May 2016 07:01:46 + Build duration: 33 sec CHANGE SET No changes