Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

2016-05-05 Thread Martin Gräßlin
> On May 4, 2016, 10:18 a.m., Martin Gräßlin wrote: > > src/platforms/xcb/kwindowsystem.cpp, lines 711-717 > > > > > > This changes the behavior of the method. Now always NETWM is preferred, > > even if it doesn

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-05-05 Thread Michael Pyne
> On May 5, 2016, 9:15 p.m., Albert Astals Cid wrote: > > src/runtime/kwalletd/main.cpp, line 97 > > > > > > See REVIEW: 126681 (commit 901c27ca7cb05cca1a960747b280d40cd7707158) it > > seems this fixes things. So

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 25 - Still Unstable!

2016-05-05 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 May 2016 22:17:44 + Build duration: 11 min CHANGE SET Revision af320ed5599cb0737c0601e26126c39e6478

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 22 - Still Unstable!

2016-05-05 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 May 2016 22:17:45 + Build duration: 5 min 2 sec CHANGE SET Revision af320ed5599cb0737c0601e2

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-05-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127833/#review95214 --- -1 src/runtime/kwalletd/main.cpp (line 97)

Re: Review Request 127842: take highlight and highlightedText from proper color group

2016-05-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127842/#review95212 --- Switching themes no longer properly updates the highlight col

Re: Review Request 126495: Install parsetrigrams tool for cross compiling.

2016-05-05 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126495/ --- (Updated May 5, 2016, 7:55 p.m.) Status -- This change has been mark

Re: Review Request 126986: hunspell: Load/Store a personal dictionary

2016-05-05 Thread Viktar Vauchkevich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126986/ --- (Updated May 5, 2016, 7:52 p.m.) Status -- This change has been mark

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

2016-05-05 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/ --- (Updated Май 5, 2016, 7:50 след обяд) Review request for KDE Frameworks,

Re: Review Request 127842: take highlight and highlightedText from proper color group

2016-05-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127842/ --- (Updated May 5, 2016, 12:22 p.m.) Status -- This change has been mar

Re: Review Request 127842: take highlight and highlightedText from proper color group

2016-05-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127842/#review95200 --- Ship it! Ship It! - Sebastian Kügler On May 5, 2016, 9:

Re: Review Request 127843: Properly remove composed characters

2016-05-05 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/#review95199 --- Looks that review board cannot handle indic characters. I pos

Review Request 127843: Properly remove composed characters

2016-05-05 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/ --- Review request for KDE Frameworks, Christoph Cullmann and Dominik Haumann.

Re: Review Request 127842: take highlight and highlightedText from proper color group

2016-05-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127842/ --- (Updated May 5, 2016, 9:54 a.m.) Review request for KDE Frameworks and Pl

Review Request 127842: take highlight and highlightedText from proper color group

2016-05-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127842/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor