Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127386/#review93581 --- mtp/devicecache.cpp (line 113)

Review Request 127383: Avoid introspecting a DBus interface when we don't use it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127383/ --- Review request for KDE Frameworks. Repository: kdbusaddons Description

Re: Review Request 127205: Add stubs to allow compilation on Android.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/ --- (Updated March 15, 2016, 8:53 p.m.) Status -- This change has been m

Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127386/ --- Review request for KDE Frameworks, David Faure and Philipp Schmidt. Bugs:

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 319 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/319/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 15 Mar 2016 16:49:31 + Build duration: 2 min 26 sec CHANGE SET Revis

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 319 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/319/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 15 Mar 2016 16:49:31 + Build duration: 3 min 13 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 321 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/321/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 15 Mar 2016 16:49:31 + Build duration: 2 min 14 sec CHANGE SET Re

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 321 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/321/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 15 Mar 2016 16:49:31 + Build duration: 2 min 46 sec CHANGE SE

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 318 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/318/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 15 Mar 2016 16:17:11 + Build duration: 2 min 23 sec CHANGE SET Revis

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 318 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/318/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 15 Mar 2016 16:17:11 + Build duration: 3 min 9 sec CHANGE SET Revision a

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 320 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/320/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 15 Mar 2016 16:17:06 + Build duration: 2 min 8 sec CHANGE SET Rev

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 320 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/320/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 15 Mar 2016 16:17:06 + Build duration: 2 min 59 sec CHANGE SE

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

> On March 15, 2016, 3:15 p.m., David Rosca wrote: > > Are you sure this fixes it? I've tested it now with Qt 5.5 and it just > > completely broke the skip taskbar feature (= plasma popups are shown ALWAYS > > in taskbar). I was experimenting with various workarounds too, but found > > none (o

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 319 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/319/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 15 Mar 2016 15:35:41 + Build duration: 2 min 21 sec CHANGE SET Re

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 319 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/319/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 15 Mar 2016 15:35:41 + Build duration: 2 min 42 sec CHANGE SE

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 317 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/317/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 15 Mar 2016 15:35:41 + Build duration: 2 min 16 sec CHANGE SET Revis

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 317 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/317/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 15 Mar 2016 15:35:41 + Build duration: 2 min 33 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 318 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/318/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 15 Mar 2016 14:36:40 + Build duration: 2 min 18 sec CHANGE SET Re

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 318 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/318/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 15 Mar 2016 14:36:40 + Build duration: 2 min 46 sec CHANGE SE

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 316 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/316/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 15 Mar 2016 14:36:40 + Build duration: 2 min 25 sec CHANGE SET Revis

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127374/#review93558 --- Are you sure this fixes it? I've tested it now with Qt 5.5 an

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 316 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/316/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 15 Mar 2016 14:36:40 + Build duration: 3 min 18 sec CHANGE SET Revision

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127374/ --- (Updated March 15, 2016, 3:36 p.m.) Status -- This change has been m

Re: Review Request 127380: More conservative approach to saving some disk accesses

> On March 15, 2016, 9:51 a.m., Anthony Fieroni wrote: > > ext[4] = { ".png", ".svgz", ".svg", ".xpm" }; > > This is a prefered order? > > The order can safe disk activity, linear search increase it. > > Did you try other order or *smart* reoredering on-the-fly? I agree that could be a factor, I

Re: Review Request 127380: More conservative approach to saving some disk accesses

> On March 15, 2016, 10:44 a.m., Mark Gaiser wrote: > > Why don't you just make use of the posix stat call? I know the > > QFileInfo::lastModified() has some issues as David described in your last > > approach, but why not use the plain simple stat function? > > http://man7.org/linux/man-pages/

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 268 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/268/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Mar 2016 11:50:14 + Build duration: 5 min 25 sec CHANGE SET Revision a1a42314def54cef8620d9b79236ce619f26a4ed

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 253 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/253/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Mar 2016 11:50:14 + Build duration: 7 min 1 sec CHANGE SET Revision a1a42314def54cef8620d9b79236ce619f2

Re: Review Request 121575: FindEpoxy.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121575/ --- (Updated March 15, 2016, 10:47 a.m.) Status -- This change has been

Re: Review Request 127380: More conservative approach to saving some disk accesses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127380/#review93538 --- Why don't you just make use of the posix stat call? I know th

Re: Review Request 127380: More conservative approach to saving some disk accesses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127380/#review93533 --- ext[4] = { ".png", ".svgz", ".svg", ".xpm" }; This is a prefe

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127374/#review93531 --- Ship it! I'd say flesh out the comment a bit more to indic