Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/ --- (Updated March 12, 2016, 1:29 a.m.) Review request for KDE Frameworks and

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-11 Thread Aleix Pol Gonzalez
> On March 11, 2016, 11:14 p.m., Marco Martin wrote: > > src/plasmaquick/appletquickitem.cpp, line 648 > > > > > > who will be using this? from the shell? Yes, see my patch in plasma-workspace. - Aleix -

Re: Review Request 127348: [KPeople] Set the contact uri as person uri in PersonData when no person exists

2016-03-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127348/#review93427 --- Can you add a test case for the `PersonDataTests`? - Aleix P

Review Request 127348: [KPeople] Set the contact uri as person uri in PersonData when no person exists

2016-03-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127348/ --- Review request for KDE Frameworks. Repository: kpeople Description

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93422 --- src/plasmaquick/appletquickitem.h (line 130)

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

2016-03-11 Thread Martin Kostolný
> On Úno. 27, 2016, 11:11 dop., David Faure wrote: > > It seems weird to have a setting for FTP on one side, and a setting for > > "SMB and SFTP and any slave where this is implemented in the future". > > I understand that it was the path of least code changes, but I fear this > > creates an in

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93419 --- I have a rough idea how you want it to work, but to really ev

Re: Review Request 127237: Fix crash in kmore tools on Windows

2016-03-11 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127237/ --- (Updated March 11, 2016, 12:43 p.m.) Status -- This change has been

Review Request 127345: Make it possible for an applet to offer a test object

2016-03-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

2016-03-11 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126618/ --- (Updated March 11, 2016, 8:19 p.m.) Review request for KDE Frameworks.

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-11 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/ --- (Updated March 11, 2016, 4:26 p.m.) Review request for KDE Frameworks and

Re: Review Request 127267: [KPeople] Set a name for the database connection

2016-03-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127267/ --- (Updated March 11, 2016, 2:54 p.m.) Status -- This change has been m