Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

2016-02-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127166/#review92707 --- nice refactoring. The code looks much cleaner! src/klaunche

Review Request 127166: Fix xcb port of klauncher and clean up the code.

2016-02-23 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127166/ --- Review request for KDE Frameworks, David Faure and Martin Gräßlin. Reposi

Re: Review Request 127164: Add actionType to the declarative plugin

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127164/#review92704 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 24, 2016

Re: Review Request 127164: Add actionType to the declarative plugin

2016-02-23 Thread Martin Klapetek
> On Feb. 24, 2016, 1:47 a.m., Aleix Pol Gonzalez wrote: > > What does it look like on the code? > > > > `ActionTypeWrapper.TextChatAction` might be awkward. KPeople.ActionType.TextChatAction - Martin --- This is an automatically gener

Re: Review Request 127142: Add a property indicating whether the models form a connected chain.

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127142/#review92702 --- src/kmodelindexproxymapper.h (line 84)

Re: Review Request 127164: Add actionType to the declarative plugin

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127164/#review92701 --- What does it look like on the code? `ActionTypeWrapper.TextC

Re: Review Request 127163: Add actionType to the PersonActionsModel

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127163/#review92700 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 24, 2016

Re: Review Request 127159: Make the KPeople qml example slightly more usable

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127159/#review92699 --- Ship it! Everybody hates red backgrounds /o\. Thanks! -

Re: Review Request 127117: Reverse the filtering logic

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127117/#review92698 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 23, 2016

Re: Review Request 127031: Add function to get runtime frameworks version information

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127031/#review92697 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 23, 2016

Re: Review Request 127148: KLinkItemSelectionModel: Add new default constructor.

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127148/#review92696 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22, 2016

Re: Review Request 127147: KLinkItemSelectionModel: Make the linked selection model settable

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127147/#review92695 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22, 2016

Re: Review Request 127145: KLinkItemSelectionModel: Don't store model locally

2016-02-23 Thread Aleix Pol Gonzalez
> On Feb. 24, 2016, 1:36 a.m., Aleix Pol Gonzalez wrote: > > Ship It! Eh.. wait, we still support Qt 5.3, will that be a problem? - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/

Re: Review Request 127145: KLinkItemSelectionModel: Don't store model locally

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127145/#review92693 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22, 2016

Re: Review Request 127139: Add unit test for KModelIndexProxyMapper.

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127139/#review92692 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22, 2016

Re: Review Request 127140: KModelIndexProxyMapper: Add some asserts

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127140/#review92691 --- src/kmodelindexproxymapper.cpp (line 232)

Re: Review Request 127141: KModelIndexProxyMapper: Simplify logic of connected check

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127141/#review92690 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22, 2016

Re: Review Request 127143: Reset KSelectionProxyModel state when needed

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127143/#review92689 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22, 2016

Re: Review Request 127144: KSelectionProxyModel: Fix iteration bug

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127144/#review92688 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22, 2016

Re: Review Request 127146: KLinkItemSelectionModel: Handle changes to the selectionModel model

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127146/#review92687 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22, 2016

Re: Review Request 127149: KLinkItemSelectionModel: Test the effect of separate object network

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127149/#review92686 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22, 2016

Re: Review Request 127150: KLinkItemSelectionModel: Test clearing the selection

2016-02-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127150/#review92685 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22, 2016

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

2016-02-23 Thread Albert Astals Cid
> On Feb. 22, 2016, 9:55 a.m., Albert Astals Cid wrote: > > I'd prefer if you could fix this at the Qt level, why would > > nativeLanguageName ever return empty? > > Andre Heinecke wrote: > I've just checked. It's a Windows thing. qlocale_win calls windows API > getLocaleInfo(LOCALE_SNATIV

Review Request 127164: Add actionType to the declarative plugin

2016-02-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127164/ --- Review request for KDE Frameworks and KDEPIM. Repository: kpeople Descr

Review Request 127163: Add actionType to the PersonActionsModel

2016-02-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127163/ --- Review request for KDE Frameworks and KDEPIM. Repository: kpeople Descr

Re: Review Request 127158: Adds writer and external (extractor and writer) plugin support

2016-02-23 Thread Varun Joshi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127158/ --- (Updated Feb. 23, 2016, 10:03 p.m.) Review request for Baloo, KDE Framewo

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

2016-02-23 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/ --- (Updated Feb. 23, 2016, 10:54 p.m.) Review request for KDE Software on Ma

Review Request 127158: Adds writer and external (extractor and writer) plugin support

2016-02-23 Thread Varun Joshi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127158/ --- Review request for Baloo, KDE Frameworks and Vishesh Handa. Repository: k

Review Request 127159: Make the KPeople qml example slightly more usable

2016-02-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127159/ --- Review request for KDE Frameworks, KDEPIM and Plasma. Repository: kpeople

Re: Taking a (semi-)break

2016-02-23 Thread Alex Merry
On 2016-02-22 22:01, Stephen Kelly wrote: Alex Merry wrote: Hi all, A combination of a serious illness in the family and some of the heated discussions taking place on other KDE mailing lists has led to me burning out on the KDE front. As a result, I'm taking a step back (some of you may h

Re: Review Request 127117: Reverse the filtering logic

2016-02-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127117/ --- (Updated Feb. 23, 2016, 8:54 p.m.) Review request for KDE Frameworks and

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

2016-02-23 Thread Andre Heinecke
> On Feb. 22, 2016, 9:55 a.m., Albert Astals Cid wrote: > > I'd prefer if you could fix this at the Qt level, why would > > nativeLanguageName ever return empty? > > Andre Heinecke wrote: > I've just checked. It's a Windows thing. qlocale_win calls windows API > getLocaleInfo(LOCALE_SNATIV

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

2016-02-23 Thread Andre Heinecke
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127136/ --- (Updated Feb. 23, 2016, 3:16 p.m.) Review request for KDE Frameworks. C

Re: Review Request 127121: KWallet::openWallet(Synchronous) : time out after 1 hour rather than 25 seconds.

2016-02-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127121/#review92667 --- Ship it! Ship It! - David Edmundson On Feb. 20, 2016, 8

Re: Review Request 126883: Add Package::cryptographicHash(QCryptographicHash::Algorithm)

2016-02-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126883/#review92668 --- Ship it! Ship It! - Marco Martin On Jan. 25, 2016, 2:10

Re: Review Request 126740: Add a script for optimizing svgs

2016-02-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review92662 --- Ship it! - David Edmundson On Feb. 16, 2016, 2:02 a.m.,

Re: Review Request 126740: Add a script for optimizing svgs

2016-02-23 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review92666 --- Ship it! Ship It! - Andreas Kainz On Feb. 16, 2016, 2:0

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 237 - Unstable!

2016-02-23 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/237/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 23 Feb 2016 13:42:39 + Build duration: 5 min 57 sec CHANGE SET Revision cf8906a4ddac2472c35915f2c7820195e4

Re: Review Request 127031: Add function to get runtime frameworks version information

2016-02-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127031/ --- (Updated Feb. 23, 2016, 1:50 p.m.) Review request for KDE Frameworks. R

Re: Review Request 127079: fix uninitialised var

2016-02-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127079/ --- (Updated Feb. 23, 2016, 2:07 p.m.) Status -- This change has been ma

Re: Review Request 127127: KOpenWithDialog: show mimetype name and comment in "Remember" checkbox text

2016-02-23 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127127/#review92657 --- +1 from the usability side, great improvement! - Thomas Pfei

Spread to more platforms - Randa Meetings 2016 open for registration

2016-02-23 Thread Mario Fux
Good morning everyone Please excuse this cross-posting but all the above mailing list fit quite well this year's topic of the Randa Meetings: multi-platform end-user application development. This includes stuff like improving KDE Frameworks 5 (KF5) on other platforms like MS Windows, Android o

Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl

2016-02-23 Thread David Faure
> On Feb. 20, 2016, 7:46 p.m., David Faure wrote: > > src/filewidgets/kurlnavigator.h, line 428 > > > > > > Signal names usually end with "ed", they reflect a state change or an > > action change. > > > >