Re: Review Request 127033: Add /../share/hunspell/ to dictionary search path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127033/#review92654 --- Fix it, then Ship it! src/plugins/hunspell/hunspelldict.c

Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl

> On Feb. 20, 2016, 7:46 p.m., David Faure wrote: > > src/filewidgets/kurlnavigator.h, line 428 > > > > > > Signal names usually end with "ed", they reflect a state change or an > > action change. > > > >

Re: Review Request 127033: Add /../share/hunspell/ to dictionary search path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127033/ --- (Updated Feb. 22, 2016, 8:59 p.m.) Review request for KDE Frameworks, Lau

Taking a (semi-)break

Hi all, A combination of a serious illness in the family and some of the heated discussions taking place on other KDE mailing lists has led to me burning out on the KDE front. As a result, I'm taking a step back (some of you may have noticed this already). I expect to get back into the swing

Re: Review Request 127046: Move popup menu image actions into a submenu

> On Feb. 12, 2016, 2:37 p.m., Thomas Pfeiffer wrote: > > I wouldn't say that all actions for images are rarely used. > > I don't see why viewing, copying or saving an image is less frequently done > > than the same things regarding the link. Can't we have those three still on > > the first lev

Re: Review Request 127046: Move popup menu image actions into a submenu

> On Feb. 12, 2016, 3:37 p.m., Thomas Pfeiffer wrote: > > I wouldn't say that all actions for images are rarely used. > > I don't see why viewing, copying or saving an image is less frequently done > > than the same things regarding the link. Can't we have those three still on > > the first lev

Re: Review Request 127046: Move popup menu image actions into a submenu

> On Feb. 12, 2016, 2:37 p.m., Thomas Pfeiffer wrote: > > I wouldn't say that all actions for images are rarely used. > > I don't see why viewing, copying or saving an image is less frequently done > > than the same things regarding the link. Can't we have those three still on > > the first lev

Re: Review Request 127142: Add a property indicating whether the models form a connected chain.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127142/ --- (Updated Feb. 22, 2016, 4:33 p.m.) Review request for KDE Frameworks. R

Re: Review Request 127147: KLinkItemSelectionModel: Make the linked selection model settable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127147/ --- (Updated Feb. 22, 2016, 4:30 p.m.) Review request for KDE Frameworks. R

Re: Review Request 127148: KLinkItemSelectionModel: Add new default constructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127148/ --- (Updated Feb. 22, 2016, 4:31 p.m.) Review request for KDE Frameworks. R

Re: Review Request 127145: KLinkItemSelectionModel: Don't store model locally

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127145/ --- (Updated Feb. 22, 2016, 4:30 p.m.) Review request for KDE Frameworks. R

Re: Review Request 127139: Add unit test for KModelIndexProxyMapper.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127139/ --- (Updated Feb. 22, 2016, 4:28 p.m.) Review request for KDE Frameworks. R

Re: Review Request 127142: Add a property indicating whether the models form a connected chain.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127142/#review92641 --- src/kmodelindexproxymapper.cpp (lines 105 - 106)

Re: Review Request 127148: KLinkItemSelectionModel: Add new default constructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127148/#review92639 --- src/klinkitemselectionmodel.h (line 108)

Re: Review Request 127147: KLinkItemSelectionModel: Make the linked selection model settable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127147/#review92640 --- Bunch of coding style nitpicks. src/klinkitemselectionmodel

KItemModels review requests

Hi, I just pushed a bunch of reviewboard review requests for kitemmodels. These have been reviewed by two colleagues here at Ableton. For your convenience you can find them as a git branch here: https://github.com/ske-ableton/kitemmodels/commits/master I can of course rebase and merge thes

Review Request 127144: KSelectionProxyModel: Fix iteration bug

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127144/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Review Request 127140: KModelIndexProxyMapper: Add some asserts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127140/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Review Request 127139: Add unit test for KModelIndexProxyMapper.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127139/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Review Request 127142: Add a property indicating whether the models form a connected chain.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127142/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Review Request 127141: KModelIndexProxyMapper: Simplify logic of connected check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127141/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Review Request 127145: KLinkItemSelectionModel: Don't store model locally

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127145/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Review Request 127146: KLinkItemSelectionModel: Handle changes to the selectionModel model

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127146/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Review Request 127143: Reset KSelectionProxyModel state when needed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127143/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Review Request 127148: KLinkItemSelectionModel: Add new default constructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127148/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Review Request 127147: KLinkItemSelectionModel: Make the linked selection model settable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127147/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Review Request 127149: KLinkItemSelectionModel: Test the effect of separate object network

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127149/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Review Request 127150: KLinkItemSelectionModel: Test clearing the selection

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127150/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

> On feb. 22, 2016, 9:55 a.m., Albert Astals Cid wrote: > > I'd prefer if you could fix this at the Qt level, why would > > nativeLanguageName ever return empty? > > Andre Heinecke wrote: > I've just checked. It's a Windows thing. qlocale_win calls windows API > getLocaleInfo(LOCALE_SNATIV

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

> On Feb. 22, 2016, 9:55 a.m., Albert Astals Cid wrote: > > I'd prefer if you could fix this at the Qt level, why would > > nativeLanguageName ever return empty? I've just checked. It's a Windows thing. qlocale_win calls windows API getLocaleInfo(LOCALE_SNATIVELANGUAGENAME) ( https://msdn.mic

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127136/#review92630 --- I'd prefer if you could fix this at the Qt level, why would n

Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127136/ --- Review request for KDE Frameworks. Repository: kxmlgui Description