Re: libkonq release? I'm missing the favicons interface

On Sat, Feb 6, 2016 at 10:21 AM, David Faure wrote: > Unaware of this discussion (no time to read kde-devel), I have done exactly > this during January. KIO (starting from 5.19) now has a KIOGui library > with a > FavIconRequestJob, which removes the dependency on the kded module > provided by li

Re: Review Request 126740: Add a script for optimizing svgs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/ --- (Updated Feb. 16, 2016, 3:02 a.m.) Review request for KDE Frameworks and

Re: Review Request 127060: Potentially fix 347962

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127060/ --- (Updated Feb. 16, 2016, 1:17 a.m.) Status -- This change has been ma

Re: Review Request 127060: Potentially fix 347962

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127060/#review92418 --- Ship it! see comment src/kdeclarative/qmlobject.cpp (lin

Re: Review Request 127077: kio_http: read and discard body after a 404 with errorPage=false.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127077/ --- (Updated Feb. 15, 2016, 9:17 p.m.) Review request for KDE Frameworks, Daw

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/ --- (Updated Feb. 15, 2016, 7:45 p.m.) Status -- This change has been ma

Re: Review Request 127079: fix uninitialised var

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127079/#review92411 --- src/declarativeimports/platformcomponents/application_p.h (l

Review Request 127079: fix uninitialised var

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127079/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 127023: [KFileMetadata] Support Origin Email subject/sender/id

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127023/#review92404 --- Fix it, then Ship it! src/propertyinfo.cpp (line 421)

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

> On Feb. 15, 2016, 8:42 a.m., Martin Gräßlin wrote: > > Thanks for contributing the code, I'm very happy to see this happening! > > Sorry, that I cannot provide a good review as I'm not really into the OSX > > API, thus my review here might look a little bit nitpicky. > > > > General comment:

Re: Review Request 127024: Don't filter names if we have mimetypes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127024/ --- (Updated Feb. 15, 2016, 12:37 p.m.) Status -- This change has been m

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

> On Feb. 15, 2016, 8:42 a.m., Martin Gräßlin wrote: > > Thanks for contributing the code, I'm very happy to see this happening! > > Sorry, that I cannot provide a good review as I'm not really into the OSX > > API, thus my review here might look a little bit nitpicky. > > > > General comment:

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/#review92390 --- Ship it! Yes in my opinion this is fine and in line with h

Re: Review Request 127004: WIP: OpenFileManagerWindowJob

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127004/#review92385 --- src/widgets/openfilemanagerwindowjob.cpp (line 107)

Re: Review Request 127024: Don't filter names if we have mimetypes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127024/#review92384 --- Ship it! Ship It! - David Faure On Feb. 14, 2016, 11:31