Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

> On Feb. 14, 2016, 11:11 p.m., Aleix Pol Gonzalez wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 192 > > > > > > Wouldn't it be a good practice to assume people are doing the right > > thing

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

> On Feb. 14, 2016, 11:12 p.m., Aleix Pol Gonzalez wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 198 > > > > > > We shouldn't be calling sync API there. That is true :( I have been debuggi

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/#review92378 --- Thanks for contributing the code, I'm very happy to see this

Re: Review Request 127024: Don't filter names if we have mimetypes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127024/ --- (Updated Feb. 15, 2016, 12:31 a.m.) Review request for KDE Frameworks and

Re: Review Request 127044: Show a warning if there's an error in the Engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127044/ --- (Updated Feb. 14, 2016, 11:28 p.m.) Status -- This change has been m

Re: Review Request 127044: Show a warning if there's an error in the Engine

> On Feb. 13, 2016, 7:31 p.m., David Faure wrote: > > That's a start, for debugging. The question is, should the user be notified > > too, in some way? True, I'll leave that up to the maintainer, especially given it might mean changes in the UI. - Aleix

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/#review92369 --- src/platformtheme/kdeplatformfiledialoghelper.cpp (line 198)

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/#review92368 --- src/platformtheme/kdeplatformfiledialoghelper.cpp (line 192)

Re: Review Request 127076: kio_http: fix mimetype determination when URL ends with '/'.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127076/ --- (Updated Feb. 14, 2016, 10:24 p.m.) Review request for KDE Frameworks, Da

Re: Review Request 127077: kio_http: read and discard body after a 404 with errorPage=false.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127077/ --- (Updated Feb. 14, 2016, 10:23 p.m.) Review request for KDE Frameworks, Da

Re: Review Request 127076: kio_http: fix mimetype determination when URL ends with '/'.

> On Feb. 14, 2016, 10:02 p.m., Milian Wolff wrote: > > autotests/httpserver_p.cpp, line 95 > > > > > > replace with category based logging? I'd like to keep the diff not _too_ different from the code in kdsoap,

Re: Review Request 127077: kio_http: read and discard body after a 404 with errorPage=false.

> On Feb. 14, 2016, 9:58 p.m., Milian Wolff wrote: > > autotests/http_jobtest.cpp, line 71 > > > > > > what fails? can you `QEXPECT_FAIL` it? or did you fix it already (I > > assume that is the case) LOL I forgo

Re: Review Request 127076: kio_http: fix mimetype determination when URL ends with '/'.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127076/#review92363 --- Fix it, then Ship it! autotests/httpserver_p.h (line 121)

Re: Review Request 127077: kio_http: read and discard body after a 404 with errorPage=false.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127077/#review92361 --- Fix it, then Ship it! autotests/http_jobtest.cpp (line 71

Re: Review Request 127077: kio_http: read and discard body after a 404 with errorPage=false.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127077/ --- (Updated Feb. 14, 2016, 9:57 p.m.) Review request for KDE Frameworks, Daw

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/ --- (Updated Feb. 14, 2016, 8:21 p.m.) Status -- This change has been ma

Re: Review Request 126480: Fix assorted memory leaks and undefined accesses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126480/ --- (Updated Feb. 14, 2016, 8:06 p.m.) Review request for KDE Frameworks, Dav

Re: Review Request 127077: kio_http: fix mimetype determination when URL ends with '/'.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127077/ --- (Updated Feb. 14, 2016, 7:40 p.m.) Review request for KDE Frameworks, Daw

Review Request 127077: kio_http: fix mimetype determination when URL ends with '/'.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127077/ --- Review request for KDE Frameworks, Dawit Alemayehu, Andreas Hartmetz, and R

Review Request 127076: kio_http: fix mimetype determination when URL ends with '/'.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127076/ --- Review request for KDE Frameworks, Dawit Alemayehu and Andreas Hartmetz.

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/#review92350 --- Looks good to me. Possibly switch the if/else to have the sh

Re: building everything with a set of specific preprocessor token(s)/definition(s)?

On 14 February 2016 at 22:00, René J.V. wrote: > On Sunday February 14 2016 15:20:14 David Faure wrote: > >> export CXXFLAGS="-DMYDEFINE=1" before running cmake should do the trick. > > That's what I'm using ATM, but cmake has a nasty habit of not taking the > user's full CXXFLAGS and/or adding i

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/ --- (Updated Feb. 14, 2016, 5:44 p.m.) Review request for KDE Software on Mac

Re: building everything with a set of specific preprocessor token(s)/definition(s)?

On Sunday February 14 2016 15:20:14 David Faure wrote: > export CXXFLAGS="-DMYDEFINE=1" before running cmake should do the trick. That's what I'm using ATM, but cmake has a nasty habit of not taking the user's full CXXFLAGS and/or adding its own stuff to the resulting CMAKE_CXX_COMPILER_FLAGS_X

Re: building everything with a set of specific preprocessor token(s)/definition(s)?

On 14 February 2016 at 19:31, René J.V. wrote: > Hi, > > I'd like to investigate something Qt-related that would require me to build > all frameworks with a specific set of preprocessor tokens defined. Rather > than patching all toplevel CMake files I'm hoping for way to define those > tokens i

Re: building everything with a set of specific preprocessor token(s)/definition(s)?

On Sunday 14 February 2016 15:01:43 René J.V. Bertin wrote: > Hi, > > I'd like to investigate something Qt-related that would require me to build > all frameworks with a specific set of preprocessor tokens defined. Rather > than patching all toplevel CMake files I'm hoping for way to define thos

building everything with a set of specific preprocessor token(s)/definition(s)?

Hi, I'd like to investigate something Qt-related that would require me to build all frameworks with a specific set of preprocessor tokens defined. Rather than patching all toplevel CMake files I'm hoping for way to define those tokens in the cmake invocation, IOW on the cmake command line. It s