Re: Review Request 126955: Fix crash in activities context menu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126955/#review91918 --- Looks correct, although IMHO it's the code that creates a cla

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "unma

Re: Review Request 126948: Simplify attica plugin look-up and initialization

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126948/ --- (Updated Feb. 2, 2016, 2:06 a.m.) Status -- This change has been mar

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

> On Feb. 1, 2016, 10 p.m., Kai Uwe Broulik wrote: > > src/declarativeimports/plasmaextracomponents/plasmaextracomponentsplugin.cpp, > > line 34 > > > > > > I thought QLatin1String was better for comparison? +1

Re: Review Request 126948: Simplify attica plugin look-up and initialization

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126948/#review91908 --- Ship it! Ship It! - Jeremy Whiting On Feb. 1, 2016, 12:

Re: Review Request 126948: Simplify attica plugin look-up and initialization

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126948/#review91906 --- Ship it! Having custom lib loading code is not a good idea

Re: Review Request 126903: Fix buddy widgets working with KFontRequester

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126903/ --- (Updated Feb. 1, 2016, 11:58 p.m.) Status -- This change has been ma

Review Request 126955: Fix crash in activities context menu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126955/ --- Review request for KDE Frameworks. Bugs: 351485 http://bugs.kde.org/s

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "unma

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 1, 2016, 8:12 nachm., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "un

Re: Review Request 126934: Reduce use of gettext API.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126934/#review91899 --- Ship it! Ship It! - Chusslove Illich On Феб. 1, 2016, 1

Re: Review Request 126949: Remove Air and Oxygen themes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/#review91883 --- Hi, I know I say I will keep oxygen-icons5 up to date, and I

Re: Review Request 126770: Fix most Clazy warnings in KXmlGui.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126770/#review91882 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 16, 2016

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review91881 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 17, 2016

Re: Review Request 126934: Reduce use of gettext API.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126934/ --- (Updated Feb. 1, 2016, 9:51 nachm.) Review request for KDE Frameworks, Al

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 1, 2016, 7:39 nachm., Boudhayan Gupta wrote: > > +1 > > > > Ideally the default look-n-feel package should include only two themes - > > the default one and a high-contrast counterpart. In fact all other themes > > should reside elsewhere. > > > > If we still want to "officially" pr

Re: Review Request 126949: Remove Air and Oxygen themes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/#review91876 --- +1 - Kai Uwe Broulik On Feb. 1, 2016, 7:30 nachm., Martin

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 1, 2016, 8:39 p.m., Boudhayan Gupta wrote: > > +1 > > > > Ideally the default look-n-feel package should include only two themes - > > the default one and a high-contrast counterpart. In fact all other themes > > should reside elsewhere. > > > > If we still want to "officially" prov

Re: Review Request 126949: Remove Air and Oxygen themes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/#review91874 --- +1 Ideally the default look-n-feel package should include on

Re: Review Request 126948: Simplify attica plugin look-up and initialization

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126948/ --- (Updated Feb. 1, 2016, 8:37 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 126948: Simplify attica plugin look-up and initialization

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126948/ --- (Updated Feb. 1, 2016, 8:35 p.m.) Review request for KDE Frameworks. Ch

Review Request 126949: Remove Air and Oxygen themes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/ --- Review request for KDE Frameworks and Plasma. Bugs: 358533 http://bug

Re: Review Request 126926: Clean up dependencies for KDeclarative/QuickAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126926/#review91871 --- Ship it! Ship It! - David Edmundson On Jan. 30, 2016, 1

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review91889 --- src/declarativeimports/calendar/daysmodel.cpp (line 135)

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "unma

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "unma

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126523/ --- (Updated Feb. 1, 2016, 6:47 p.m.) Status -- This change has been mar

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 1, 2016, 9:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "unma

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "unma

Re: Review Request 126949: Remove Air and Oxygen themes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/#review91878 --- Ship it! Ship It! - David Edmundson On Feb. 1, 2016, 7:

Re: Review Request 126772: Fix some Clazy warnings in KService

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126772/#review91880 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 16, 2016

Re: Review Request 126769: Fix all Clazy warnings in KDED.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126769/#review91879 --- Please note you changed the wrong function. The offending fun

Review Request 126948: Simplify attica plugin look-up and initialization

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126948/ --- Review request for KDE Frameworks. Repository: attica Description -

Re: KMenu aboutToShowContextMenu KF5 porting options: None. Do we care?

El Monday 01 February 2016, a les 08:39:22, David Faure va escriure: > On Monday 01 February 2016 00:43:27 Albert Astals Cid wrote: > > In the kdelibs4 world one could connect to KMenu aboutToShowContextMenu > > signal to add more entries to the submenu that appears when right > > clicking on a men

Re: Review Request 126926: Clean up dependencies for KDeclarative/QuickAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126926/ --- (Updated Feb. 1, 2016, 7:12 p.m.) Status -- This change has been mar

Re: Review Request 126892: [kioslave/remote] check return of createWizardEntry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126892/ --- (Updated Feb. 1, 2016, 4:34 p.m.) Status -- This change has been mar

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126523/#review91869 --- Ship it! Ship It! - David Edmundson On Jan. 23, 2016, 1

Review Request 126945: Don't call exec() from QML

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126945/ --- Review request for KDE Frameworks. Bugs: 357435 http://bugs.kde.org/s

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126523/#review91864 --- Ping? - Elvis Angelaccio On Jan. 23, 2016, 11:29 a.m., Elv

Re: Review Request 126893: [kioslave/remote] fix knetattach .desktop filename

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126893/ --- (Updated Feb. 1, 2016, 4:56 p.m.) Status -- This change has been mar

Re: Review Request 126892: [kioslave/remote] check return of createWizardEntry

> On 2月 1, 2016, 8:18 p.m., David Faure wrote: > > Ship It! Thanks! Sorry, I pushed this commit to remote another branch 'origin/kcoredir' Could you delete this branch? - Takahiro --- This is an automatically generated e-mail. To reply

Re: Review Request 126892: [kioslave/remote] check return of createWizardEntry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126892/#review91842 --- Ship it! Ship It! - David Faure On Jan. 29, 2016, 11:29

Re: Review Request 126893: [kioslave/remote] fix knetattach .desktop filename

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126893/#review91841 --- Ship it! Ship It! - David Faure On Jan. 29, 2016, 11:29

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126895/ --- (Updated Feb. 1, 2016, 10:53 a.m.) Review request for KDE Frameworks. C

Re: KActivitiesStats framework for review

Hi Martin, I'll need to find a better file template plugin for Vim that loads per-project headers. It should be ok now - lgpl2, lgpl3 + e.V. clause. Cheers, Ivan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mai

Re: KActivitiesStats framework for review

On Monday, February 1, 2016 9:59:17 AM CET Ivan Čukić wrote: > Hi all, > > There is a new framework-to-be under review. Until now, it was used in > plasma (and shipped with plasma, although it was developed in > kactivities repository - strange setup, but we somehow managed). To > avoid collisions

KActivitiesStats framework for review

Hi all, There is a new framework-to-be under review. Until now, it was used in plasma (and shipped with plasma, although it was developed in kactivities repository - strange setup, but we somehow managed). To avoid collisions, it was previously known under the KActivitiesExperimentalStats name, an

Re: KMenu aboutToShowContextMenu KF5 porting options: None. Do we care?

On Monday 01 February 2016 00:43:27 Albert Astals Cid wrote: > In the kdelibs4 world one could connect to KMenu aboutToShowContextMenu > signal > to add more entries to the submenu that appears when right clicking on a menu > entry. > > Nowadays KMenu is gone in apps that do not use kdelibs4sup

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

> On Jan. 29, 2016, 9:43 a.m., David Faure wrote: > > This looks good to me. It doesn't affect Linux, it doesn't affect API / > > binary compatibility, it uses #if so no risk of missing include, and it > > hides the globalaccel gui so it's not like users have the risk on clicking > > on someth