Re: Review Request 126934: Reduce use of gettext API.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126934/#review91826 --- I'm fine with this, I'm just thinking that the file as whole

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 172 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/172/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 31 Jan 2016 21:28:27 + Build duration: 19 min CHANGE SET Revision 54536d9cc9dad94a75fc8baf8fd35869b984219

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 177 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/177/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 31 Jan 2016 21:20:23 + Build duration: 19 min CHANGE SET Revision 54536d9cc9dad94a75fc8baf8fd35869

KMenu aboutToShowContextMenu KF5 porting options: None. Do we care?

In the kdelibs4 world one could connect to KMenu aboutToShowContextMenu signal to add more entries to the submenu that appears when right clicking on a menu entry. Nowadays KMenu is gone in apps that do not use kdelibs4support so we can't use that. We still have a default menu that appears whe

Re: API review: FavIconManager vs FavIconHostRequestJob

Hello, On Sunday, 31 January 2016 10:40:12 CET David Faure wrote: > On Thursday 28 January 2016 09:35:53 laurent Montel wrote: > > Yep some time I forgot it in kmail when I used manual call to start. > > So if you want to use it make it automatic it's better. > > I agree, but then I wonder why KJ

Re: API review: FavIconManager vs FavIconHostRequestJob

Hello, Here comes my purely API focused comments. I'll snip anything else (even comments). If I missed something important due to this approach, feel free to point it out. On Thursday, 28 January 2016 01:33:32 CET David Faure wrote: > namespace KIO { > > class KIOGUI_EXPORT FavIconsManager : p

Re: Review Request 126940: Move .protocol files of all io slaves bundled in kio to JSON meta data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126940/ --- (Updated Jan. 31, 2016, 3:41 p.m.) Review request for KDE Frameworks, Ale

Review Request 126940: Move .protocol files of all io slaves bundled in kio to JSON meta data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126940/ --- Review request for KDE Frameworks, Alex Richardson and David Faure. Repos

Re: QSP patch/activator

And here's the business part of the latest version of my QSP patch, by popular request (or not) :) I've followed your (David's) remark that the actual QExtStandardPaths payload could be part of QStandardPaths; QExtStandardPaths is now purely header based - in qstandardpaths.h to be exact. The

Re: Review Request 126675: Add .kra and .ora qimagio plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126675/ --- (Updated Jan. 31, 2016, 3:01 p.m.) Status -- This change has been ma

Re: Review Request 126675: Add .kra and .ora qimagio plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126675/#review91823 --- Ship it! Ship It! - Alex Merry On Jan. 31, 2016, 1:21 p

Re: Review Request 126675: Add .kra and .ora qimagio plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126675/ --- (Updated Jan. 31, 2016, 1:21 p.m.) Review request for KDE Frameworks and

Re: Review Request 126675: Add .kra and .ora qimagio plugins

> On Jan. 31, 2016, 1:03 p.m., Alex Merry wrote: > > CMakeLists.txt, line 22 > > > > > > What about making this optional (and only building those two plugins if > > it is found)? Fine with me. - Boudewijn --

Re: Review Request 126675: Add .kra and .ora qimagio plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126675/#review91821 --- CMakeLists.txt (line 22)

Re: QSP patch/activator

On Sunday January 31 2016 12:10:05 David Faure wrote: > On Sunday 31 January 2016 11:18:34 René J.V. Bertin wrote: > > +case QPlatformTheme::IconThemeSearchPaths: > > +if (QStandardPaths::isXDGLocationsEnabled()) { > > +return xdgIconThemePaths(); > > +} > > I don'

Re: API review: FavIconManager vs FavIconHostRequestJob

On Sunday 31 January 2016 11:29:31 laurent Montel wrote: > Le dimanche 31 janvier 2016, 10:40:12 CET David Faure a écrit : > > On Thursday 28 January 2016 09:35:53 laurent Montel wrote: > > > +ecm_qt_declare_logging_category(kiogui_SRCS HEADER favicons_debug.h > > > IDENTIFIER FAVICONS_LOG CATEGORY

Re: Review Request 126936: help: fix garbage sent when serving static files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126936/ --- (Updated Jan. 31, 2016, 11:41 a.m.) Status -- This change has been m

Re: Review Request 126936: help: fix garbage sent when serving static files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126936/#review91819 --- Ship it! Inviala! - Luigi Toscano On Gen. 31, 2016, 11:

Re: Review Request 126936: help: fix garbage sent when serving static files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126936/#review91818 --- Ship it! Ship It! - David Faure On Jan. 31, 2016, 10:01

Re: Review Request 126936: help: fix garbage sent when serving static files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126936/#review91817 --- Additional note: simple test with kioclient5 cat help:/kdoct

Re: QSP patch/activator

On Sunday 31 January 2016 11:18:34 René J.V. Bertin wrote: > +case QPlatformTheme::IconThemeSearchPaths: > +if (QStandardPaths::isXDGLocationsEnabled()) { > +return xdgIconThemePaths(); > +} I don't think this requires an if() at all. It's not like Mac OSX has freed

Re: API review: FavIconManager vs FavIconHostRequestJob

Le dimanche 31 janvier 2016, 10:40:12 CET David Faure a écrit : > On Thursday 28 January 2016 09:35:53 laurent Montel wrote: > > +ecm_qt_declare_logging_category(kiogui_SRCS HEADER favicons_debug.h > > IDENTIFIER FAVICONS_LOG CATEGORY_NAME kde.kio.favicons) > > In this directory we will use just fa

Re: QSP patch/activator

Hi, I was just reminded of a related issue. The native Mac platform theme has a very limited icon theme search path. You can add the XDG-compliant icon repository to that path, but then almost all buttons will start to show icons: the platform theme apparently doesn't even check the DialogButto

Review Request 126936: help: fix garbage sent when serving static files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126936/ --- Review request for KDE Frameworks, David Faure and Luigi Toscano. Reposit

Re: API review: FavIconManager vs FavIconHostRequestJob

On Thursday 28 January 2016 09:35:53 laurent Montel wrote: > +ecm_qt_declare_logging_category(kiogui_SRCS HEADER favicons_debug.h > IDENTIFIER FAVICONS_LOG CATEGORY_NAME kde.kio.favicons) > In this directory we will use just favicon ? > Perhaps a more generic log name no ? Well, one debug area pe

Re: Review Request 126774: Fix many warnings presented by clazy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126774/#review91815 --- Ship it! Ship It! - David Faure On Jan. 20, 2016, 2 a.m

Review Request 126934: Reduce use of gettext API.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126934/ --- Review request for KDE Frameworks, Aleix Pol Gonzalez and Chusslove Illich.