Re: Deadlock in kded whith Qt 5.6

On Tuesday 19 January 2016 22:54:35 Thiago Macieira wrote: > On Monday 18 January 2016 09:23:51 David Faure wrote: > > Thiago: indeed the BlockingQueuedConnection call from messageFilter to the > > main thread occasionnally leads to deadlocks, we need your > > "postpone incoming messages" idea. >

Re: Review Request 126818: Cache QX11Info::appRootWindow in eventFilter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126818/#review91362 --- Ship it! Ship It! - Martin Gräßlin On Jan. 20, 2016, 12

Re: Review Request 126818: Cache QX11Info::appRootWindow in eventFilter

> On Jan. 20, 2016, 2:58 a.m., Aleix Pol Gonzalez wrote: > > src/platforms/xcb/kwindowsystem_p_x11.h, line 147 > > > > > > Should this (maybe) be static? Or rather Q_GLOBAL_STATIC? > > > > Or we'll just

Re: Deadlock in kded whith Qt 5.6

On Monday 18 January 2016 09:23:51 David Faure wrote: > Thiago: indeed the BlockingQueuedConnection call from messageFilter to the > main thread occasionnally leads to deadlocks, we need your > "postpone incoming messages" idea. Please try the attached patch, also found at https://coderevi

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 72 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/72/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jan 2016 05:59:16 + Build duration: 9.9 sec CHANGE SET No changes __

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 71 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/71/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jan 2016 05:59:16 + Build duration: 9.9 sec CHANGE SET No changes _

Re: Review Request 126774: Fix many warnings presented by clazy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126774/ --- (Updated Jan. 20, 2016, 3 a.m.) Review request for KDE Frameworks and Ale

Re: Review Request 126818: Cache QX11Info::appRootWindow in eventFilter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126818/#review91358 --- src/platforms/xcb/kwindowsystem_p_x11.h (line 147)

Re: Review Request 126818: Cache QX11Info::appRootWindow in eventFilter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126818/#review91355 --- +1 Purely unscientific measurement through ksysguard shows t

Review Request 126818: Cache QX11Info::appRootWindow in eventFilter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126818/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 126740: Add a script for optimizing svgs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review91352 --- there was also an discussion to use png files cause they are

Re: Review Request 126740: Add a script for optimizing svgs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/ --- (Updated Jan. 19, 2016, 11:54 p.m.) Review request for KDE Frameworks and

Re: Review Request 126740: Add a script for optimizing svgs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/ --- (Updated Jan. 19, 2016, 7:02 p.m.) Review request for KDE Frameworks and

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review91342 --- Ship it! Ship It! - David Edmundson On Jan. 5, 2016, 11

Re: Deadlock in kded whith Qt 5.6

On Tuesday 19 January 2016 15:56:47 you wrote: > I briefly talked about this with David yesterday and looked at the code. > What happened previously in kded5: > - it installs a message filter using libdbus API QtDBus API. In fact, it's QtDBus API that exists and has existed only for kded (and now

Re: Review Request 126806: DragDropEvent: Add ignore() function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126806/ --- (Updated Jan. 19, 2016, 4:49 p.m.) Status -- This change has been ma

Re: Review Request 126806: DragDropEvent: Add ignore() function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126806/#review91340 --- Ship it! Ship It! - Sebastian Kügler On Jan. 18, 2016,

Re: Review Request 126813: Fix build with older polkit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126813/#review91338 --- The symbol `polkit_system_bus_name_get_user_sync` doesn't exi

Re: Deadlock in kded whith Qt 5.6

On Dienstag, 19. Januar 2016 10:02:33 CET Aleix Pol wrote: > On Mon, Jan 18, 2016 at 9:23 AM, David Faure wrote: > > On Friday 15 January 2016 13:48:14 Aleix Pol wrote: > >> On Fri, Jan 15, 2016 at 1:02 PM, Aleix Pol wrote: > >> > Hi, > >> > I realized earlier last week that some of my applicati

Re: Review Request 126725: prevent crash-on-exit in KSelectAction::~KSelectAction

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126725/ --- (Updated Jan. 19, 2016, 2:09 p.m.) Status -- This change has been ma

Review Request 126813: Fix build with older polkit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126813/ --- Review request for KDE Frameworks. Repository: polkit-qt-1 Description

Re: [karchive] /: Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).

2016-01-19 10:11 GMT+01:00 Aleix Pol : > On Tue, Jan 19, 2016 at 9:15 AM, David Faure wrote: > > Git commit 3b13ef97925725b2a273a4d3e7d1c0c7e151522d by David Faure. > > Committed on 19/01/2016 at 08:14. > > Pushed by dfaure into branch 'master'. > > > > Fix CMP0063 warning (the one about CXX_VISI

Re: Review Request 126798: Add multiple installation method per categorie

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126798/ --- (Updated Jan. 19, 2016, 11:35 a.m.) Review request for KDE Frameworks and

Re: Review Request 126798: Add multiple installation method per categorie

> On Jan. 18, 2016, 4:52 p.m., Aleix Pol Gonzalez wrote: > > src/core/engine.cpp, line 135 > > > > > > Shouldn't this break? Otherwise some of the installations won't get > > connected. No. I think previous cod

Re: [karchive] /: Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).

On Tue, Jan 19, 2016 at 9:15 AM, David Faure wrote: > Git commit 3b13ef97925725b2a273a4d3e7d1c0c7e151522d by David Faure. > Committed on 19/01/2016 at 08:14. > Pushed by dfaure into branch 'master'. > > Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET). > > Any volunteer for doing this ove

Re: Deadlock in kded whith Qt 5.6

On Mon, Jan 18, 2016 at 9:23 AM, David Faure wrote: > On Friday 15 January 2016 13:48:14 Aleix Pol wrote: >> On Fri, Jan 15, 2016 at 1:02 PM, Aleix Pol wrote: >> > Hi, >> > I realized earlier last week that some of my applications were >> > freezing, it turns out it's because my kded is freezing

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

> On Jan. 14, 2016, 8:47 a.m., Kåre Särs wrote: > > tests/proxymodeltestapp/proxyitemselectionwidget.cpp, line 47 > > > > > > QStringLiteral with multiple string initializers does not work on > > Windows. All pla

Re: Reporting bugs to frameworks

On Tue, Jan 19, 2016 at 9:06 PM, David Faure wrote: > On Friday 15 January 2016 13:39:12 Christoph Feck wrote: >> On Friday 15 January 2016 12:55:47 Aleix Pol wrote: >> > Hi, >> > I've recently found a bug in kded. I've been trying to report it >> > but didn't manage to find it on the list [1]. >>

[karchive] /: Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).

Git commit 3b13ef97925725b2a273a4d3e7d1c0c7e151522d by David Faure. Committed on 19/01/2016 at 08:14. Pushed by dfaure into branch 'master'. Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET). Any volunteer for doing this over all frameworks? CCMAIL: kde-frameworks-devel@kde.org M +1

Re: Review Request 126789: Don't propagate dataChanged upwards when we are not filtering.

> On Jan. 19, 2016, 7:59 a.m., David Faure wrote: > > I wrote extensive unit tests for this class. > > 1) does the unittest still pass? > > 2) if yes, then it should be extended to test for this case The unit tests all still pass here, I'll look into expanding the tests. - Volker ---

Re: Review Request 126769: Fix all Clazy warnings in KDED.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126769/#review91307 --- src/kded.cpp (line 223)

Re: Reporting bugs to frameworks

On Friday 15 January 2016 13:39:12 Christoph Feck wrote: > On Friday 15 January 2016 12:55:47 Aleix Pol wrote: > > Hi, > > I've recently found a bug in kded. I've been trying to report it > > but didn't manage to find it on the list [1]. > > > > What did I miss? > > frameworks-kdaemon What a ...