Re: Review Request 126648: Allow to disable KArchive for internal usage

2016-01-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126648/#review90682 --- Ship it! src/xslt_kde.cpp (line 17)

Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126650/ --- Review request for KDE Frameworks and Kai Uwe Broulik. Repository: kidlet

Review Request 126648: Allow to disable KArchive for internal usage

2016-01-05 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126648/ --- Review request for Build System, KDE Frameworks and Alex Merry. Repositor

Re: Review Request 126403: Get rid of QApplication dependency

2016-01-05 Thread Albert Astals Cid
> On gen. 4, 2016, 7:42 a.m., Martin Gräßlin wrote: > > anyone tested this on an "affected system"? > > Albert Astals Cid wrote: > I have not, I thought you had made it clear in the past you thought it > was a bad idea since it was all supposed to be widget based anyway. > > Thomas Lübking

Re: Review Request 126403: Get rid of QApplication dependency

2016-01-05 Thread Thomas Lübking
> On Jan. 4, 2016, 7:42 a.m., Martin Gräßlin wrote: > > anyone tested this on an "affected system"? > > Albert Astals Cid wrote: > I have not, I thought you had made it clear in the past you thought it > was a bad idea since it was all supposed to be widget based anyway. > > Thomas Lübking

Re: Review Request 126403: Get rid of QApplication dependency

2016-01-05 Thread Albert Astals Cid
> On gen. 4, 2016, 7:42 a.m., Martin Gräßlin wrote: > > anyone tested this on an "affected system"? > > Albert Astals Cid wrote: > I have not, I thought you had made it clear in the past you thought it > was a bad idea since it was all supposed to be widget based anyway. > > Thomas Lübking

Re: Review Request 126161: OS X housekeeping

2016-01-05 Thread René J . V . Bertin
> On Dec. 25, 2015, 3:42 p.m., René J.V. Bertin wrote: > > src/kdeinit/kinit_mac.mm, lines 662-666 > > > > > > I'd love to add `[NSApp activateIgnoringOtherApps:YES]` and/or `[NSApp > > unhide]` here, preceded b

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

2016-01-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90655 --- +1 makes sense to me. - Aleix Pol Gonzalez On Jan. 5, 2016,

Review Request 126639: Enable date format in tickmark.

2016-01-05 Thread Luca Beldi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126639/ --- Review request for KDE Frameworks and David Faure. Repository: kplotting

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

2016-01-05 Thread René J . V . Bertin
On Tuesday January 05 2016 15:01:08 Christoph Cullmann wrote: >Therefore I do there not installEventFilter(this) but installEventFilter(qApp) >and qApp != this. Right. I must have seen that but not really realised what it implied. >For 4 I guess it is easiest to implement ::event like e.g descri

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

2016-01-05 Thread Christoph Cullmann
Hi, > Hi, > > I was experimenting with our 2 different approaches to implement this in kate4 > yesterday. Somehow, after implementing KateApp::eventFilter() I kept seeing > events being delivered to that function after commenting out the corresponding > installEventFilter() call. That's with a KA

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

2016-01-05 Thread René J . V . Bertin
Hi, I was experimenting with our 2 different approaches to implement this in kate4 yesterday. Somehow, after implementing KateApp::eventFilter() I kept seeing events being delivered to that function after commenting out the corresponding installEventFilter() call. That's with a KApplication::ev

Re: QProcess for GUI apps on OSX (Re: closest equivalent to KApplicationPrivate::init() ?)

2016-01-05 Thread René J . V . Bertin
On Tuesday January 05 2016 12:55:57 David Faure wrote: > I'm surprised it's that complex, and that an OSX app cannot launch another > one and have it appear in front. > Is there no app with an action that starts a calculator, a special-character > selector, etc.? > Is there no alternative applic

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 218 - Fixed!

2016-01-05 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/218/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 05 Jan 2016 12:00:49 + Build duration: 2 min 34 sec CHANGE SET Revisi

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 218 - Fixed!

2016-01-05 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/218/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 05 Jan 2016 12:00:49 + Build duration: 2 min 34 sec CHANGE SET Revisi

Re: Review Request 126620: Fixed most of level 1 and level 2 warnings

2016-01-05 Thread Artur Puzio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126620/ --- (Updated Jan. 5, 2016, 12:21 p.m.) Status -- This change has been ma

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

2016-01-05 Thread Martin Gräßlin
> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly unexpecte

Re: QProcess for GUI apps on OSX (Re: closest equivalent to KApplicationPrivate::init() ?)

2016-01-05 Thread David Faure
On Tuesday 05 January 2016 11:58:49 René J.V. Bertin wrote: > It's not that it is so different. My gripe is with the use of the word and > concept GUI. I'm going to have to figure out exactly what GUI aspects are > only available to app bundles on OS X currently, and to what extent > LaunchServi

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

2016-01-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/ --- (Updated Jan. 5, 2016, 11:16 a.m.) Review request for KDE Frameworks and

Review Request 126632: add a "Complementary" color scheme to kcolorscheme

2016-01-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/ --- Review request for KDE Frameworks and Plasma. Repository: kconfigwidgets

Re: QProcess for GUI apps on OSX (Re: closest equivalent to KApplicationPrivate::init() ?)

2016-01-05 Thread René J . V . Bertin
On Monday January 04 2016 23:14:23 David Faure wrote: >> Yes, of course. You were hinting at that I start drafting a patch for >> QProcess, no? Or do you have a Mac yourself on which to cook one up? > >I'm letting you do this, just providing input. Ok. Going to let this simmer/ferment/mature a b

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

2016-01-05 Thread René J . V . Bertin
> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly unexpecte

Re: Review Request 118909: Imply SkipTaskbar and SkipPager depending on Window Type

2016-01-05 Thread Thomas Lübking
> On June 23, 2014, 8:08 p.m., Thomas Lübking wrote: > > What about (non override) utility windows (eg. assume Qt would not set > > floating dock override to bring its own titlebar)? > > While kwin (iirc by default) hides them for inactive windows, that's rather > > a feature. > > > > -> By th

Jenkins-kde-ci: karchive master kf5-qt5 » Linux,gcc - Build # 48 - Fixed!

2016-01-05 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/karchive%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/48/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 05 Jan 2016 09:00:27 + Build duration: 1 min 42 sec CHANGE SET Revision 77c13da03864bc86715e634523a273a2909b49

Jenkins-kde-ci: karchive master kf5-qt5 » Linux,gcc - Build # 48 - Fixed!

2016-01-05 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/karchive%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/48/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 05 Jan 2016 09:00:27 + Build duration: 1 min 42 sec CHANGE SET Revision 77c13da03864bc86715e634523a273a2909b49

Re: Review Request 126403: Get rid of QApplication dependency

2016-01-05 Thread Thomas Lübking
> On Jan. 4, 2016, 7:42 a.m., Martin Gräßlin wrote: > > anyone tested this on an "affected system"? > > Albert Astals Cid wrote: > I have not, I thought you had made it clear in the past you thought it > was a bad idea since it was all supposed to be widget based anyway. We're trying to re

Jenkins-kde-ci: karchive master stable-kf5-qt5 » Linux,gcc - Build # 47 - Fixed!

2016-01-05 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/karchive%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 05 Jan 2016 09:00:27 + Build duration: 1 min 25 sec CHANGE SET Revision 77c13da03864bc86715e634523a273a

Jenkins-kde-ci: karchive master stable-kf5-qt5 » Linux,gcc - Build # 47 - Fixed!

2016-01-05 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/karchive%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 05 Jan 2016 09:00:27 + Build duration: 1 min 25 sec CHANGE SET Revision 77c13da03864bc86715e634523a273a

Jenkins-kde-ci: karchive master kf5-qt5 » Linux,gcc - Build # 47 - Failure!

2016-01-05 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/karchive%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 05 Jan 2016 08:19:57 + Build duration: 1 min 10 sec CHANGE SET Revision 4b0842b7c68ebd733271a4208c3bfffe35c768

Jenkins-kde-ci: karchive master stable-kf5-qt5 » Linux,gcc - Build # 46 - Failure!

2016-01-05 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/karchive%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/46/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 05 Jan 2016 08:19:57 + Build duration: 1 min 11 sec CHANGE SET Revision 4b0842b7c68ebd733271a4208c3bfff