Re: Review Request 126505: Do not show a warning color before the user even started typing

2015-12-26 Thread Elvis Angelaccio
> On Dec. 26, 2015, 10:17 p.m., Thomas Pfeiffer wrote: > > Just one question: Why should a mismatch only be considered when the two > > have the same length? > > Couldn't you show the warning as soon as an actual mismatch is detected, > > even if that happens before the confirmation password ha

Re: Review Request 126505: Do not show a warning color before the user even started typing

2015-12-26 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126505/#review90126 --- Just one question: Why should a mismatch only be considered wh

Re: Review Request 126481: Avoid deliberately overflowing a full buffer.

2015-12-26 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126481/ --- (Updated Dec. 26, 2015, 4:26 p.m.) Status -- This change has been ma

Re: Review Request 126481: Avoid deliberately overflowing a full buffer.

2015-12-26 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126481/#review90120 --- Ship it! Minor coding style nitpick, please fix before commit

Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2015-12-26 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126523/ --- Review request for KDE Frameworks, KDE Usability, Kai Uwe Broulik, and Chr

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

2015-12-26 Thread Jaime Torres Amate
> On Dec. 17, 2015, 4:16 p.m., Martin Gräßlin wrote: > > > > Jaime Torres Amate wrote: > Hello, > > This is just a warning to know if this patch has been tested in a two > monitor environment in a laptop. > In a pyqt application I save and restore the size and position of t