Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126476/#review89968 --- Test question: should it be "1.5 other windows" or "1.5 other

Review Request 126481: Avoid deliberately overflowing a full buffer.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126481/ --- Review request for KDE Frameworks and Daniel Vrátil. Repository: kcodecs

Review Request 126480: Fix assorted memory leaks and undefined accesses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126480/ --- Review request for KDE Frameworks, David Faure, Martin Tobias Holmedahl Sa

Review Request 126476: Make it possible to use doubles as index for i18np*() calls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126476/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n

Jenkins-kde-ci: ki18n master kf5-qt5 » Linux,gcc - Build # 33 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 22 Dec 2015 18:10:53 + Build duration: 1 min 23 sec CHANGE SET Revision 2755b8ff8a17fb1a333c0fa3e00a884c501280ce

Jenkins-kde-ci: ki18n master stable-kf5-qt5 » Linux,gcc - Build # 38 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ki18n%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/38/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 22 Dec 2015 18:10:53 + Build duration: 1 min 3 sec CHANGE SET Revision 2755b8ff8a17fb1a333c0fa3e00a884c501

Re: Review Request 126471: Don't emit statusChanged if it hasn't changed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126471/ --- (Updated Dec. 22, 2015, 5:32 p.m.) Status -- This change has been ma

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

> On Dec. 22, 2015, 4:59 p.m., Ivan Čukić wrote: > > The patch seems straight-forward. > > > > I can not find the reference that QRegularExpression is thread-safe (the > > most I see is 'all functions in this class are reentrant which is stated > > for QRegExp as well). > > > > The QRegExp vs

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

> On Dec. 22, 2015, 4:59 p.m., Ivan Čukić wrote: > > The patch seems straight-forward. > > > > I can not find the reference that QRegularExpression is thread-safe (the > > most I see is 'all functions in this class are reentrant which is stated > > for QRegExp as well). > > > > The QRegExp vs

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126474/#review89939 --- The patch seems straight-forward. I can not find the referenc

Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126474/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 126455: Add mutex round static QRegExp usage in KShorturifilter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126455/ --- (Updated Dec. 22, 2015, 4:33 p.m.) Status -- This change has been di

Re: Review Request 126472: Don't always load the timetracker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126472/#review89924 --- Ship it! Nice. I agree with Aleix that the env var would be

Re: Review Request 126472: Don't always load the timetracker

> On Dec. 22, 2015, 3:21 p.m., Aleix Pol Gonzalez wrote: > > I'm ok with this, although it wasn't guarded initially because it was asked > > not to. IIRC. > > > > Anyway, +1. Some small documentation about the environment variable would be neat. - Aleix

Re: Review Request 126472: Don't always load the timetracker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126472/#review89921 --- I'm ok with this, although it wasn't guarded initially because

Re: Review Request 126471: Don't emit statusChanged if it hasn't changed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126471/#review89920 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 22, 2015, 3

Review Request 126472: Don't always load the timetracker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126472/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Review Request 126471: Don't emit statusChanged if it hasn't changed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126471/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 126426: Add a warning color to kwalletd's password dialogs

> On Dec. 22, 2015, 12:25 a.m., Thomas Pfeiffer wrote: > > As already said in the other review request: The field should only be > > marked when it loses focus, otherwise it always has the error state while > > the user is typing. If that's already the case, then I'm all +1 Not yet. I will try

building KHtml and KJs with LTO?

Hi, Quick question: I'm getting unspecified linker failures when I try to build KHtml and KJs with link-time optimisation on Linux, using gcc 5.3.0 . I know that certain KDE libs (kdelibs4...) wouldn't build with LTO, but these are the first KF5 frameworks that show this failure for me; all othe