Re: Review Request 126329: kio: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126329/#review89450 --- Ship it! Ship It! - David Faure On Dec. 13, 2015, 10:04 p.

Re: Review Request 126312: Add xcb variant for static KStartupInfo::sendFoo methods

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126312/ --- (Updated Dec. 14, 2015, 8:08 a.m.) Review request for KDE Frameworks and

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89448 --- src/platformtheme/kdeplatformtheme.cpp (line 45)

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126324/#review89447 --- src/gui/CMakeLists.txt (line 2)

Re: Review Request 126325: kwidgetsaddons: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126325/ --- (Updated Dez. 13, 2015, 10:38 nachm.) Review request for KDE Frameworks a

Re: Review Request 126329: kio: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126329/ --- (Updated Dez. 13, 2015, 10:04 nachm.) Review request for KDE Frameworks.

Re: Review Request 126328: kwallet: Do not use QStringLiteral with multi strings

> On Dez. 13, 2015, 1:01 vorm., Nick Shaforostoff wrote: > > i suggest using: > > > > #ifdef Q_OS_WIN > > #define U QLatin1String > > #else > > #define U QStringLiteral > > #endif > > Valentin Rusu wrote: > Patrick's approach corresponds to a widespread practice in KF5 sources. > It al

Re: Review Request 126328: kwallet: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126328/ --- (Updated Dec. 13, 2015, 9:57 p.m.) Status -- This change has been ma

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89424 --- +1 Thank you! This fixes Plasma startup for me and I wasted h

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 11, 2015, 2:55 p.m., Thomas Lübking wrote: > > src/kdeui/kdialogbuttonbox.cpp, line 39 > > > > > > QDialogButtonBox::addButton should do correctly anyway, so please don't > > workaround things that are

Re: "Buttons have icons", round N+1

On Sunday December 13 2015 17:14:17 Thomas Lübking wrote: > I object the overhead concern. The global solution is easily applied by the > style (the icon isn't loaded from disk or rendered until you/the style > requires a pixmap from painting - until then there's just a string that hints > whic

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to incor

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 11, 2015, 1:55 p.m., Thomas Lübking wrote: > > src/kdeui/kdialogbuttonbox.cpp, line 39 > > > > > > QDialogButtonBox::addButton should do correctly anyway, so please don't > > workaround things that are

Re: "Buttons have icons", round N+1

On Sonntag, 13. Dezember 2015 16:20:19 CEST, René J.V. wrote: There has been some discussion around one of my RRs concerning how to respect KDE's ShowIconsOnPushButtons and Qt's SH_DialogButtonBox_ButtonsHaveIcons style hint. The ultimate way would be in the style that does the actual drawin

"Buttons have icons", round N+1

Hi, There has been some discussion around one of my RRs concerning how to respect KDE's ShowIconsOnPushButtons and Qt's SH_DialogButtonBox_ButtonsHaveIcons style hint. The ultimate way would be in the style that does the actual drawing, but that is probably not the one with the smallest overhe

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 11, 2015, 2:55 p.m., Thomas Lübking wrote: > > For the record: I've raised a few interrogations that are preventing me from following up and addressing the open issues raised by Thomas. - René J.V. --- This is an automaticall

Re: Review Request 126329: kio: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126329/#review89415 --- src/widgets/kpropertiesdialog.cpp (line 603)

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126324/ --- (Updated Dec. 13, 2015, 2:54 p.m.) Review request for KDE Software on Mac

Re: [Kde-pim] kdesrc-build setup for kdepim

On Saturday, December 12, 2015 11:00:39 PM CET Alex Merry wrote: > The recent splitting of kdepimlibs has caused a clean run of > kdesrc-build to fail on lots of pim modules. This seems to be a > combination of kde-build-metadata not recording the dependencies > properly for a lot of things, and "p

Re: Review Request 125641: Allow PAM unlocking of a running wallet

> On Oct. 23, 2015, 7:07 p.m., Boudhayan Gupta wrote: > > src/runtime/kwalletd/main.cpp, line 173 > > > > > > Is this necessary? Shouldn't KWallet::Wallet::isOpen() fail nicely if > > the wallet isn't running?

Re: Review Request 126328: kwallet: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126328/#review89411 --- Ship it! Ship It! - Valentin Rusu On Dec. 12, 2015, 10:59

Re: Review Request 126328: kwallet: Do not use QStringLiteral with multi strings

> On Dec. 13, 2015, 1:01 a.m., Nick Shaforostoff wrote: > > i suggest using: > > > > #ifdef Q_OS_WIN > > #define U QLatin1String > > #else > > #define U QStringLiteral > > #endif Patrick's approach corresponds to a widespread practice in KF5 sources. It also has the advantage to always use