Re: Review Request 126328: kwallet: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126328/#review89407 --- i suggest using: #ifdef Q_OS_WIN #define U QLatin1String #els

Re: Review Request 126327: sonnet: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126327/#review89406 --- Ship it! as that are just tests, i.e. not real code, i sugges

Re: Review Request 126329: kio: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126329/#review89405 --- please use QLatin1String instead of QString::fromLatin1 for QR

Review Request 126330: use Qt defines for portability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126330/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Review Request 126329: kio: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126329/ --- Review request for KDE Frameworks. Repository: kio Description ---

kdesrc-build setup for kdepim

The recent splitting of kdepimlibs has caused a clean run of kdesrc-build to fail on lots of pim modules. This seems to be a combination of kde-build-metadata not recording the dependencies properly for a lot of things, and "playground/pim" in the kdepim kdesrc-build include file being far too

Review Request 126328: kwallet: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126328/ --- Review request for KDE Frameworks. Repository: kwallet Description

Review Request 126326: kdbusaddons: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126326/ --- Review request for KDE Frameworks. Repository: kdbusaddons Description

Review Request 126327: sonnet: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126327/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 29 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/29/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Dec 2015 22:22:20 + Build duration: 1 min 21 sec CHANGE SET Revision d7e2b83df15aea30a6449d6b7bc6cb265b

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 29 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/29/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Dec 2015 22:22:20 + Build duration: 1 min 21 sec CHANGE SET Revision d7e2b83df15aea30a6449d6b7bc6cb265b

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125988/ --- (Updated Dec. 12, 2015, 10:08 p.m.) Status -- This change has been m

Review Request 126325: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126325/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidget

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

> On Dec. 12, 2015, 10:02 p.m., David Faure wrote: > > Ah I needed the last hunk from your patch, too. Now it works. > > http://www.davidfaure.fr/2015/0001-Add-autocompletion-for-.-input-which-offers-all-hidd.patch > > ok with you? LGTM, thanks! :) - Emmanuel --

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126324/ --- (Updated Dec. 12, 2015, 10:19 p.m.) Review request for KDE Software on Ma

Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126324/ --- Review request for KDE Software on Mac OS X and KDE Frameworks. Repositor

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125988/#review89400 --- Ah I needed the last hunk from your patch, too. Now it works.

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 25 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Dec 2015 19:34:43 + Build duration: 3 min 5 sec CHANGE SET Revision 8490cbf0e03ade567357809c2769

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 25 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Dec 2015 19:34:43 + Build duration: 3 min 5 sec CHANGE SET Revision 8490cbf0e03ade567357809c2769

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

> On Dec. 12, 2015, 11:12 a.m., David Faure wrote: > > Either that, or if you want the fix to be available before 5.6 is out, wrap > > your fix with #if QT_VERSION < QT_VERSION_CHECK(5, 6, 0). > > > > We can always clean it up once 5.6 is required (i.e. in a few years ;). > > And mention the qt

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126295/#review89398 --- Ship it! We could findChildren in an autotest to find the but

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 12, 2015, 7:08 p.m.) Review request for KDE Software on Mac

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 7, 2015, 5:41 p.m., René J.V. Bertin wrote: > > So with the current implementation that uses inheritance, there are 2 > > classes that have a `delayedDBusConnects` method which uses > > `QDBusConnection::sessionBus().connect()` to register things on the DBus. > > Both invoke that met

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89394 --- +1, this also fixes plasma on mobile CI - Bhushan Shah On D

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89391 --- Ooh, also, please write a unit test. I can help with that if y

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 52 > > > > > > Honestly, I'd just use ARG as the prefix - you're in a function, it's > > not going to leak anyway.

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89388 --- We're getting there :-). kde-modules/KDEInstallDirs.cmake (l

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

Most of our users currently prefer the basic Qt file dialog, but if there's some way to get the KDE one outside of plasma, I'm sure many would rejoice. On 12 December 2015 at 13:31, David Faure wrote: > On Thursday 10 December 2015 10:38:06 Weng Xuetian wrote: >> if you want to achieve the same

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

> On Dec. 12, 2015, 11:54 a.m., Emmanuel Pescosta wrote: > > Sorry for breaking this code :/ > > > > Would it be possible to add some test cases to prevent such problems in > > future? > > Xuetian Weng wrote: > I don't know. It's not a good practice to test with private interface. The pub

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

On Thursday 10 December 2015 10:38:06 Weng Xuetian wrote: > if you want to achieve the same feature in some > other desktop, it would be better to make a fork of > frameworkintegration. Not frameworkintegration, just the platformtheme (QPT). Like some others before, you're confusing frameworkint

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

On Saturday December 12 2015 11:46:06 David Faure wrote: > > kiod5 is started, but doesn't post a dialog. Doesn't raise/return an error > > either. > > If there a debug category to activate in order to get more output I haven't > > found it. > > Did you try this on linux with Qt 5.4 or 5.5, to

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

> On Dec. 12, 2015, 10:54 a.m., Emmanuel Pescosta wrote: > > Sorry for breaking this code :/ > > > > Would it be possible to add some test cases to prevent such problems in > > future? I don't know. It's not a good practice to test with private interface. - Xuetian

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125988/#review89381 --- Either that, or if you want the fix to be available before 5.6

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126295/ --- (Updated Dec. 12, 2015, 11:11 a.m.) Review request for KDE Frameworks, Da

Re: kwidgetsaddons on OS X: menus become menu items

René J.V. Bertin wrote: > The widget is reparented away from the QMenu to the native menu view. If you > show the menu in some other place (e.g. as a popup menu), the widget will not > be there. Actually I think this part *is* related: I noticed that the Bookmarks menu is supposed to appear also

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

> On Dec. 6, 2015, 12:19 p.m., David Faure wrote: > > OK I debugged this further, and I found why this didn't match my > > expectations of the QUrl behaviour: > > > > QUrl::fromLocalFile("/tmp/.") leads to file:///tmp rather than > > file:///tmp/. I consider this a bug (when NormalizePathSegme

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126295/#review89378 --- Sorry for breaking this code :/ Would it be possible to add s

Re: kdelibs4support forces "icons in buttons"?

On Tuesday 08 December 2015 14:36:14 René J.V. Bertin wrote: > Hi, > > I have the strong impression that applications using the kdelibs4support fw > are forced to show icons in buttons, regardless of the corresponding setting > (which is respected elsewhere). > For some reason it does not happen

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

On Monday 07 December 2015 16:14:54 René J.V. Bertin wrote: > On Sunday December 06 2015 14:51:40 David Faure wrote: > > > Here is an easy way to test this: do the same change for kiod in kio (it's > > like a mini kded) and then > > cd kio/tests ; ./listjobtest ftp://t...@upload.kde.org > > s

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126295/#review89377 --- src/filewidgets/kurlnavigator.cpp (line 156)

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126295/ --- (Updated Dec. 12, 2015, 9:35 a.m.) Review request for KDE Frameworks, Dav