Re: Review Request 126161: OS X housekeeping

On Wednesday 25 November 2015 16:45:25 René J.V. Bertin wrote: > > No, with "my" fix, applications started through kwrapper appear as individual > entries in `ps` listings, with your fix only the `kwrapper5 /path/to/command` > entry shows up. I don't see how that's possible. If kdeinit forks, s

Re: Failure while executing KTar::open while using KCompressionDevice as the device

On Saturday 21 November 2015 15:50:31 Luiz Romário Santana Rios wrote: > , or make the waitFor* calls and warn the user > that passing a QIODevice which is not yet fully ready to > KCompressionDevice might make KTar::open() block. That would work I guess. In a unittest or a non-gui tool or a secon

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/#review88852 --- autotests/CMakeLists.txt (line 44)

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

> On Nov. 25, 2015, 9:30 p.m., David Faure wrote: > > autotests/CMakeLists.txt, line 44 > > > > > > sorry I just realized something else: these calls to "tar" will break > > on Windows. > > > > I would s

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/#review88850 --- autotests/CMakeLists.txt (line 44)

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

2015-11-25 17:56 GMT-03:00 David Faure : > On Wednesday 25 November 2015 14:54:49 Luiz Romário Santana Rios wrote: >> > >> > My /usr/include/zconf.h says >> > >> > #if defined(ZLIB_CONST) && !defined(z_const) >> > # define z_const const >> > #else >> > # define z_const >> > #endif >> >> Mine does

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/ --- (Updated Nov. 25, 2015, 9:19 p.m.) Status -- This change has been ma

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/ --- (Updated Nov. 25, 2015, 9:16 p.m.) Review request for KDE Frameworks, Ale

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/#review88847 --- Ship it! I would have used less member variables in the unitt

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

On Wednesday 25 November 2015 14:54:49 Luiz Romário Santana Rios wrote: > > > > My /usr/include/zconf.h says > > > > #if defined(ZLIB_CONST) && !defined(z_const) > > # define z_const const > > #else > > # define z_const > > #endif > > Mine doesn't define anything like that. > > > > > and /usr/i

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126170/ --- (Updated Nov. 25, 2015, 7:12 p.m.) Review request for KDE Software on Mac

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

On Nov. 25, 2015, 6:18 p.m., René J.V. Bertin wrote: > > See qtbase/src/plugins/platforms/cocoa/qcocoaintegration.mm and > > qcocoahelpers.mm Isn't copy/paste a great tool? :) Anyway, `qt_mac_transformProccessToForegroundApplication` only reads the `LSUIElement` key to determine whether an ap

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

2015-11-25 13:08 GMT-03:00 David Faure : > On Wednesday 25 November 2015 12:21:11 Luiz Romário Santana Rios wrote: >> >> Btw, the commit 0f0230f7d2feeca7ed00072e7b17b24c14f53698 ("Fix clang >> warnings") makes the compilation fail in my machine. In the >> KGzipFilter::setInBuffer() method, you chan

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126170/#review88838 --- src/kded.cpp (line 683)

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126170/#review88837 --- Would it be an idea to create a framework function to run the

Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126170/ --- Review request for KDE Software on Mac OS X and KDE Frameworks. Repositor

Re: Review Request 126161: OS X housekeeping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/ --- (Updated Nov. 25, 2015, 6 p.m.) Review request for KDE Software on Mac OS

Re: Review Request 126161: OS X housekeeping

> On Nov. 25, 2015, 8:39 a.m., David Faure wrote: > > src/kdeinit/kinit.cpp, line 1621 > > > > > > Yes if you have to run a separate process which will then dlopen the > > kdeinit module, the whole purpose of k

Re: Review Request 126161: OS X housekeeping

> On Nov. 25, 2015, 8:39 a.m., David Faure wrote: > > src/kdeinit/kinit.cpp, line 1621 > > > > > > Yes if you have to run a separate process which will then dlopen the > > kdeinit module, the whole purpose of k

Re: Review Request 126161: OS X housekeeping

> On Nov. 25, 2015, 7:39 a.m., David Faure wrote: > > src/kdeinit/kinit.cpp, line 1621 > > > > > > Yes if you have to run a separate process which will then dlopen the > > kdeinit module, the whole purpose of k

Re: Review Request 126161: OS X housekeeping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/ --- (Updated Nov. 25, 2015, 5:19 p.m.) Review request for KDE Software on Mac

Re: Review Request 126161: OS X housekeeping

> On Nov. 25, 2015, 8:39 a.m., David Faure wrote: > > src/kdeinit/kinit.cpp, line 1621 > > > > > > Yes if you have to run a separate process which will then dlopen the > > kdeinit module, the whole purpose of k

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

On Wednesday 25 November 2015 12:21:11 Luiz Romário Santana Rios wrote: > > Btw, the commit 0f0230f7d2feeca7ed00072e7b17b24c14f53698 ("Fix clang > warnings") makes the compilation fail in my machine. In the > KGzipFilter::setInBuffer() method, you change a C-cast to (Bytef *) to > a reinterpret_ca

Re: Review Request 126161: OS X housekeeping

> On Nov. 25, 2015, 7:39 a.m., David Faure wrote: > > src/kdeinit/kinit.cpp, line 1621 > > > > > > Yes if you have to run a separate process which will then dlopen the > > kdeinit module, the whole purpose of k

Re: Review Request 126167: Expose QMimeType comment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126167/#review88826 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 25, 2015, 4

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

2015-11-25 5:08 GMT-03:00 David Faure : > On Tuesday 24 November 2015 23:38:28 David Faure wrote: >> On Monday 23 November 2015 12:11:12 Luiz Romário Santana Rios wrote: >> > 2015-11-21 21:02 GMT-03:00 David Faure : >> > > >> > > This is an automatically generated e-mail. To reply, visit: >> > > h

Re: Failure while executing KTar::open while using KCompressionDevice as the device

2015-11-23 13:57 GMT-03:00 Aleix Pol : > On Mon, Nov 23, 2015 at 4:54 PM, Luiz Romário Santana Rios > wrote: >> 2015-11-02 14:53 GMT-03:00 Luiz Romário Santana Rios : >>> Hello, >>> >>> I'm trying to decompress a XZ archive downloaded using >>> QNetworkAccessManager, so, according to the documents

Re: Review Request 126161: OS X housekeeping

> On Nov. 25, 2015, 8:39 a.m., David Faure wrote: > > src/kdeinit/kinit.cpp, line 1621 > > > > > > Yes if you have to run a separate process which will then dlopen the > > kdeinit module, the whole purpose of k

Re: Review Request 126161: OS X housekeeping

> On Nov. 25, 2015, 2:49 a.m., Lamarque Souza wrote: > > src/kdeinit/kdeinit5_proxy.cpp, line 1 > > > > > > Please add a copyright header for each new file [1]. If I am not > > mistaken all frameworks 5 files shou

Review Request 126167: Expose QMimeType comment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126167/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kde

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/ --- (Updated Nov. 25, 2015, 3:12 p.m.) Review request for KDE Frameworks, Ale

Re: Review Request 126088: Port KDeclarative to use KI18n directly, rather than adding its own bindings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126088/ --- (Updated Nov. 25, 2015, 12:32 p.m.) Status -- This change has been m

Re: Review Request 126088: Port KDeclarative to use KI18n directly, rather than adding its own bindings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126088/#review88790 --- Ship it! Ship It! - Marco Martin On Nov. 16, 2015, 12:57 p

Re: Review Request 126164: Request proper dbus name for kioexec

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126164/ --- (Updated Nov. 25, 2015, 8:35 a.m.) Status -- This change has been ma

Re: Review Request 126164: Request proper dbus name for kioexec

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126164/#review88785 --- Ship it! "in kde" -> you meant in kde4 (kde-runtime4 more pre

Review Request 126164: Request proper dbus name for kioexec

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126164/ --- Review request for KDE Frameworks and David Faure. Bugs: 353037 https

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

On Tuesday 24 November 2015 23:38:28 David Faure wrote: > On Monday 23 November 2015 12:11:12 Luiz Romário Santana Rios wrote: > > 2015-11-21 21:02 GMT-03:00 David Faure : > > > > > > This is an automatically generated e-mail. To reply, visit: > > > https://git.reviewboard.kde.org/r/125974/ > > >