Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 19, 2015, 5:21 p.m., Marco Martin wrote: > > so let's go for that and then add the import with the singleton as well, if > > is okay for framework maintainer are fine with the qtqml dependency.. but > > they should be as the "everything in kdeclarative" situation has to be > > solved

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 18, 2015, 12:52 p.m., Martin Gräßlin wrote: > > src/plugins/osx/macpoller.cpp, lines 222-227 > > > > > > seriously? You care about idle timeouts below 5 msec? This is a > > framework to tell the applic

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 18, 2015, 4:22 a.m., Martin Gräßlin wrote: > > src/plugins/osx/macpoller.cpp, lines 222-227 > > > > > > seriously? You care about idle timeouts below 5 msec? This is a > > framework to tell the applica

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> Again - this is not against IOKit or what Apple does, but your usage > of QTimer in your code. RRs are meant for constructive feedback, and Oh, I can use Grand Central Dispatch if that makes you feel better, but in the end something will have to check at certain times of interest whether indeed

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/#review88619 --- src/declarativeimports/core/units.cpp (line 41)

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

2015-11-19 17:17 GMT+01:00 René J.V. : > On Thursday November 19 2015 15:21:10 Dario Freddi wrote: > >> * KIdleTime strives to be as lightweight as possible. This is something >>which came from the old approach used in KDE3/4 powermanagement which was > ... >>resource (aka: the power manager) to ta

Re: Review Request 126119: remove unused platformstatus kded

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126119/#review88618 --- Ship it! Ship It! - Sebastian Kügler On Nov. 19, 2015, 4:1

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 17, 2015, 10:58 p.m., Lamarque Souza wrote: > > src/plugins/osx/macpoller.h, line 24 > > > > > > Nitpick: this should go after #include > > René J.V. Bertin wrote: > Any guidelines that dictate thi

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

On Thursday November 19 2015 15:21:10 Dario Freddi wrote: > * KIdleTime strives to be as lightweight as possible. This is something >which came from the old approach used in KDE3/4 powermanagement which was ... >resource (aka: the power manager) to take care of this, but it was deemed >crazy to br

Re: Review Request 126087: Move the i18n context from KDeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/#review88612 --- so let's go for that and then add the import with the singleto

Review Request 126119: remove unused platformstatus kded

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126119/ --- Review request for KDE Frameworks and Plasma. Bugs: 348840 http://bug

Re: Review Request 126087: Move the i18n context from KDeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/ --- (Updated Nov. 19, 2015, 5 p.m.) Review request for KDE Frameworks, Chussl

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

Hi all, On 19 November 2015 at 15:06, René J.V. wrote: > On Thursday November 19 2015 08:10:08 Martin Graesslin wrote: >> the code else where, but because the issues pointed out would be unresolved >> giving users of your code a bad framework and thus harming both your users as >> well as the fra

Re: Review Request 126117: Fix resetting or changing the source model of a KRecursiveFilterProxyModel.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126117/ --- (Updated Nov. 19, 2015, 3:17 p.m.) Status -- This change has been ma

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

Given I already stepped in... 2015-11-19 10:36 GMT+01:00 René J.V. : > > Now it's just bad code, eh? > > Just for the record: no one but Apple really knows what IOKit considers being > idle but it clearly involves absence of user input events. That's "user > idle", not "system idle" (term from t

Re: Review Request 126117: Fix resetting or changing the source model of a KRecursiveFilterProxyModel.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126117/#review88602 --- Ship it! Ship It! - Kevin Funk On Nov. 19, 2015, 1:33 p.m.

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

Hi René, just thought I'd clarify some things as the creator/former maintainer of all this - which might also justify some of Martin's positions. The idea behind KIdleTime is that the framework shall be a lightweight, non-critical framework for those applications which want to know about the idle

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

There's something else that's been bothering me since I realised it: KIdleTime has been written with the assumption that'll always work, and that whatever initialisation is required never fails. That must be why the return value from setupPoller() is discarded. Maybe this all holds true on Linu

Review Request 126117: Fix resetting or changing the source model of a KRecursiveFilterProxyModel.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126117/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

> On Nov. 16, 2015, 5:16 p.m., Hrvoje Senjan wrote: > > >assuming, that is, distros push out the updates together > > > > don't assume this ;-) at least send a mail to kde-distro-packagers about > > the sideeffects if those 3 are pushed asynchronously > > Boudhayan Gupta wrote: > 'course,

Review Request 126113: make event filters static to decrease installed filters on qApp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/ --- Review request for KDE Frameworks and Plasma. Bugs: 351923 http://bug

Re: Review Request 126110: Clean up and armour Baloo::Database::open()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126110/ --- (Updated Nov. 19, 2015, 5:09 p.m.) Review request for Baloo, KDE Framewor

Re: Review Request 125619: Refactor KNewPasswordDialog class

> On Nov. 16, 2015, 12:56 p.m., Heiko Tietze wrote: > > Ship It! > > Elvis Angelaccio wrote: > I'm assuming that yours is a ship-it only from the usability side, right? Yes, UX only. No design comment from my side, but still with all of the previous considerations. - Heiko

Re: Review Request 125619: Refactor KNewPasswordDialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/ --- (Updated Nov. 19, 2015, 11:04 a.m.) Status -- This change has been m

Review Request 126110: Clean up and armour Baloo::Database::open()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126110/ --- Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.

Re: Review Request 125619: Refactor KNewPasswordDialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/ --- (Updated Nov. 19, 2015, 10:49 a.m.) Review request for KDE Frameworks and

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

On Thursday November 19 2015 08:10:08 Martin Graesslin wrote: > I want to apologize for saying that. Please be aware that this was only > intended as a description of code (yes I also call code written by myself > idiotic and worse things) and not against you. Apology accepted, but please reali

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126078/#review88573 --- Hello folks, Martin Graesslin has asked the CWG to step in her