Re: Build and test failures with Qt 5.6 and Qt 5.3

2015-11-09 Thread Martin Graesslin
On Monday, November 9, 2015 6:00:43 PM CET Jan Kundrát wrote: > On Monday, 9 November 2015 08:21:21 CET, Martin Graesslin wrote: > > I'm sorry, but I'm not able to reproduce the failure on my > > local Qt 5.6 setup. > > The failures look like there is no WM running on the CI system, > > maybe openb

Re: [CRITICAL] KIO Test "threadtest" can enter into infinite loop

2015-11-09 Thread Ben Cooksley
On Mon, Nov 9, 2015 at 8:30 PM, David Faure wrote: > On Monday 09 November 2015 19:36:09 Ben Cooksley wrote: >> On Mon, Nov 9, 2015 at 10:26 AM, Albert Astals Cid wrote: >> > El Saturday 07 November 2015, a les 10:36:18, David Faure va escriure: >> >> On Saturday 07 November 2015 11:17:31 Ben Coo

[sysadmin/ci-builder-tools] build/kio: Disable ASAN for all of KIO. We can't switch it off per test, so for everything it shall have to be...

2015-11-09 Thread Ben Cooksley
Git commit 7f4c67b4bdf3d2c46a855fc2f7d03f9fc0606caa by Ben Cooksley. Committed on 10/11/2015 at 06:56. Pushed by bcooksley into branch 'master'. Disable ASAN for all of KIO. We can't switch it off per test, so for everything it shall have to be... CCMAIL: kde-frameworks-devel@kde.org A +2-0

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

2015-11-09 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125951/#review88206 --- src/declarativeimports/calendar/eventpluginsmanager.cpp (line

Re: Review Request 126009: [KUrlNavigator] Fix url encoding problems in KUrlNavigator

2015-11-09 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126009/ --- (Updated Nov. 9, 2015, 10:15 p.m.) Status -- This change has been ma

Re: Review Request 126009: [KUrlNavigator] Fix url encoding problems in KUrlNavigator

2015-11-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126009/#review88203 --- Ship it! Ship It! - David Faure On Nov. 9, 2015, 7:09 p.m.

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

2015-11-09 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125951/ --- (Updated Nov. 9, 2015, 8:56 p.m.) Review request for KDE Frameworks and P

Review Request 126009: [KUrlNavigator] Fix url encoding problems in KUrlNavigator

2015-11-09 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126009/ --- Review request for KDE Frameworks and David Faure. Bugs: 354678 https

Re: Build and test failures with Qt 5.6 and Qt 5.3

2015-11-09 Thread Jan Kundrát
On Monday, 9 November 2015 08:21:21 CET, Martin Graesslin wrote: I'm sorry, but I'm not able to reproduce the failure on my local Qt 5.6 setup. The failures look like there is no WM running on the CI system, maybe openbox crashed? (We had that before that our tests were able to trigger crashes

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 9, 2015, 3:15 p.m.) Status -- This change has been mar

Re: Review Request 125976: add an update() method

2015-11-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/#review88197 --- Ship it! Not sure if we can use the Package::JobError::Foo sy

Re: Review Request 125976: add an update() method

2015-11-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/#review88195 --- Ship it! Nice. Few issues with the wording in the comments, b

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 9, 2015, 2:51 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 126001: In KConfigTest::testEntryMap, convert QByteArray with nulls using a char *

2015-11-09 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126001/ --- (Updated Nov. 9, 2015, 2:43 p.m.) Status -- This change has been mar

Re: Review Request 126001: In KConfigTest::testEntryMap, convert QByteArray with nulls using a char *

2015-11-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126001/#review88194 --- Ship it! Ah, yes, I read the code too fast. Indeed I expect

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 9, 2015, 2:40 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 126001: In KConfigTest::testEntryMap, convert QByteArray with nulls using a char *

2015-11-09 Thread Matthew Dawson
> On Nov. 9, 2015, 2:57 a.m., David Faure wrote: > > Isn't this exactly the wrong fix? The goal of the test with embedded NULs > > in a QByteArray is to test that KConfig can be used to store binary data, > > isn't it? So I would think the expected value was correct, it's the KConfig > > code

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 9, 2015, 1:18 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 9, 2015, 1:15 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin
> On Nov. 7, 2015, 2:03 p.m., Sebastian Kügler wrote: > > src/kpackage/private/packagejobthread_p.h, line 58 > > > > > > As you note yourself, perhaps just make it an enum? It's not private > > API, OK, but the c

Re: Review Request 126004: add symlink verification tech

2015-11-09 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126004/ --- (Updated Nov. 9, 2015, 12:54 p.m.) Status -- This change has been ma

Re: Review Request 126002: Fix KArchive for behavior change in Qt 5.6

2015-11-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126002/ --- (Updated Nov. 9, 2015, 12:46 p.m.) Status -- This change has been ma

Re: [mostly OS X]: KDEHOME vs. ~/.kde best practices, *rc files and related questions

2015-11-09 Thread David Faure
On Monday 09 November 2015 13:36:33 René J.V. Bertin wrote: > Being more integrated is a worthy goal, but IMHO not so much if it comes at > the detriment of flexibility, for the (borderline) cases where that > integration is not desired. (And I wouldn't bet anything that you've been > able to fo

Re: Review Request 126004: add symlink verification tech

2015-11-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126004/#review88189 --- Ship it! Good stuff! - Sebastian Kügler On Nov. 9, 2015, 1

Re: [mostly OS X]: KDEHOME vs. ~/.kde best practices, *rc files and related questions

2015-11-09 Thread René J . V . Bertin
On Sunday November 08 2015 21:58:21 David Faure wrote: >Not really. I do exactly that to run KF5 apps in a KDE4 desktop here. Et te, Brutus? :) >It's just a matter of writing your export statements in a file that you source >before running a kf5 app (from a terminal). The sourcing of the env can

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 135 - Still Unstable!

2015-11-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/135/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 09 Nov 2015 12:28:37 + Build duration: 2 min 59 sec CHANGE SET Re

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 126 - Still Unstable!

2015-11-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/126/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 09 Nov 2015 12:28:37 + Build duration: 1 min 54 sec CHANGE SET Revision

Re: Review Request 126002: Fix KArchive for behavior change in Qt 5.6

2015-11-09 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126002/#review88182 --- Ship it! ouch, I was bitten by that in KDevelop as well...

Review Request 126004: add symlink verification tech

2015-11-09 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126004/ --- Review request for KDE Frameworks. Repository: breeze-icons Description

Re: rocs fails to compile? - was -Re: KDE Applications 15.08.3 available for packagers

2015-11-09 Thread Alex Merry
On 2015-11-09 11:11, Alex Merry wrote: On 2015-11-09 08:18, David Faure wrote: On Sunday 08 November 2015 22:21:18 Albert Astals Cid wrote: Does anybody have problems building rocs? It builds fine here but CI complains https://build.kde.org/job/rocs%20Applications-15.08%20stable-kf5-qt5/PLA

Re: rocs fails to compile? - was -Re: KDE Applications 15.08.3 available for packagers

2015-11-09 Thread Alex Merry
On 2015-11-09 08:18, David Faure wrote: On Sunday 08 November 2015 22:21:18 Albert Astals Cid wrote: Does anybody have problems building rocs? It builds fine here but CI complains https://build.kde.org/job/rocs%20Applications-15.08%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/console Ma

Re: Review Request 126002: Fix KArchive for behavior change in Qt 5.6

2015-11-09 Thread Nick Shaforostoff
> On Nov. 9, 2015, 10:42 a.m., Nick Shaforostoff wrote: > > src/ktar.cpp, line 293 > > > > > > why can't we just use QFile::decodeName(const char * localFileName) > > overload? ok, there is a limit of 100. then

Re: Review Request 126002: Fix KArchive for behavior change in Qt 5.6

2015-11-09 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126002/#review88178 --- src/ktar.cpp (line 292)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 134 - Still Unstable!

2015-11-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/134/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 09 Nov 2015 10:11:57 + Build duration: 2 min 48 sec CHANGE SET Re

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 125 - Still Unstable!

2015-11-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/125/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 09 Nov 2015 10:11:57 + Build duration: 2 min 49 sec CHANGE SET Revision

Re: Review Request 125975: X11 build system cleanup

2015-11-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125975/ --- (Updated Nov. 9, 2015, 10:11 a.m.) Status -- This change has been ma

Re: icon frameworks

2015-11-09 Thread Harald Sitter
On Sat, Nov 7, 2015 at 8:35 PM, David Faure wrote: > On Saturday 07 November 2015 10:04:52 David Faure wrote: >> >> Did you check the list from >> https://community.kde.org/Frameworks/CreationGuidelines >> ? >> >> At first sight I see already one thing missing: no CI job under >> https://build.kde

Re: rocs fails to compile? - was -Re: KDE Applications 15.08.3 available for packagers

2015-11-09 Thread David Faure
On Sunday 08 November 2015 22:21:18 Albert Astals Cid wrote: > Does anybody have problems building rocs? > > It builds fine here but CI complains > > https://build.kde.org/job/rocs%20Applications-15.08%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/console > > Maybe it fails with KF 5.16? Ca