Re: Review Request 125885: Support socks5 proxy in KTcpSocket

> On Nov. 2, 2015, 8:08 a.m., David Faure wrote: > > Ah I see, forget what I said about HTTP proxy. > > > > About the missing argument, it would indeed be useful for this code: > > http://lxr.kde.org/source/extragear/network/konversation/src/irc/server.cpp > > Add a separate method, for BC reaso

Re: Review Request 125904: Save proxy url with correct scheme.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125904/ --- (Updated Nov. 8, 2015, 3:26 a.m.) Status -- This change has been mar

Re: Review Request 125815: Provide an alternative when khelpcenter is not available

> On Nov. 4, 2015, 1:43 a.m., Aleix Pol Gonzalez wrote: > > Bump? Anyone with docs.kde.org knowledge around? > > Ben Cooksley wrote: > As long as the application name is being submitted in lower case, it > should work fine. > > Examples: > https://docs.kde.org/index.php?branch

Re: Review Request 124714: Add support to qmake's options to api.kde.org

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124714/ --- (Updated Nov. 8, 2015, 1:21 a.m.) Review request for KDE Frameworks and A

Re: Review Request 124714: Add support to qmake's options to api.kde.org

> On Nov. 3, 2015, 7:42 p.m., Alex Merry wrote: > > Sorry I've let this sit for so long - Real Life(TM) got in the way. > > > > Rather than adding variables for each of these, I'd rather have some way to > > add free text to this field. Also, have you checked that an extra line > > break doesn

Re: Build and test failures with Qt 5.6 and Qt 5.3

Ah, for the *** sake. My fault, I expected that the 'since' tag is missing from that one like it is for setClearColor and didn't check. I've removed the call in question when compiling against Qt 5.3. It will manifest as an issue for people that use dark colour scheme, but since the activities KC

Re: Build and test failures with Qt 5.6 and Qt 5.3

On Saturday, 7 November 2015 22:38:16 CET, Ivan Čukić wrote: - [5.3] kactivities: won't build due to QQuickWidget::setClearColor which is 5.4+ only. It should be ok now. I've added a work-around (essentially how the method is implemented in 5.4 and 5.5). kactivities/src/workspace/settings/im

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 162 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/162/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Nov 2015 21:14:45 + Build duration: 12 min CHANGE SET Revision 2b211d1db809df2e01362e8dbfda3dffab8c6e3d by scri

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 162 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/162/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Nov 2015 21:14:45 + Build duration: 12 min CHANGE SET Revision 2b211d1db809df2e01362e8dbfda3dffab8c6e3d by scri

Re: Build and test failures with Qt 5.6 and Qt 5.3

> - [5.3] kactivities: won't build due to QQuickWidget::setClearColor which is > 5.4+ only. It should be ok now. I've added a work-around (essentially how the method is implemented in 5.4 and 5.5). Cheers, Ivan ___ Kde-frameworks-devel mailing list Kde-

Re: Build and test failures with Qt 5.6 and Qt 5.3

Hi David, thanks for looking into this. I'm happy that you find the additional coverage useful. At this time, the infrastructure cannot easily send out automated e-mails only upon a change in the state of a build job -- if someone has some time and is willing to improve this, I'll be happy to w

Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125988/ --- Review request for KDE Frameworks. Bugs: 354981 https://bugs.kde.org/

Re: icon frameworks

On Saturday 07 November 2015 10:04:52 David Faure wrote: > > Did you check the list from > https://community.kde.org/Frameworks/CreationGuidelines > ? > > At first sight I see already one thing missing: no CI job under > https://build.kde.org/view/Frameworks%20kf5-qt5/ To get this moving (since

Qt 5.6 behavior change with QByteArray(str, size) and QFile::encodeName()

KTar's unittests detected a behavior change in Qt. Thiago, is it intentional, or should it be fixed in Qt ? KTar does QString name = QFile::decodeName(QByteArray(buffer, 100)); where buffer is e.g. "filename\0\0\0\0\0\0[...]" With Qt < 5.6 this would lead to name being equal to "filename". Wit

Review Request 125987: KFontSettingsData autotest: dbus connect happens with QueuedConnection, wait for it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125987/ --- Review request for KDE Frameworks and Àlex Fiestas. Repository: framework

Re: Review Request 125976: add an update() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/#review88138 --- In general, I like the idea. We have to be a bit careful to ke

Re: Updating techbase wiki page according to KF5 policies

David Faure ha scritto: > On Friday 06 November 2015 23:42:21 Martin Walch wrote: > >> * Is that wiki page meant to apply to KF5? >> * If it shall apply to KF5 is it safe to update it accordingly? > > Don't know. Technically the naming is wrong, there's no "kdelibs" > in KF5. Maybe you could make

Re: Policy on order of include guards and license texts

On Saturday 07 November 2015 00:23:31 Martin Walch wrote: > Hi, > > should include guards be put above or below the license text (for > KDE in general)? I have always always seen them below. In Qt, in kdelibs, in KF5, in KDE apps code. Someone might unearth an exception, of course, but I'm prett

Re: Updating techbase wiki page according to KF5 policies

On Friday 06 November 2015 23:42:21 Martin Walch wrote: > Hi, > > the techbase wiki says > > > If you add #includes for Qt classes, use both the module and class name. > > This allows library code to be used by applications without excessive > > compiler include paths. Urgh, that's indeed outdat

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 33 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Nov 2015 12:30:59 + Build duration: 1 min 59 sec CHANGE SET Revision 8691afcd8811b5e977495944db

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 33 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Nov 2015 12:30:59 + Build duration: 1 min 59 sec CHANGE SET Revision 8691afcd8811b5e977495944db

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 132 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/132/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 07 Nov 2015 12:17:29 + Build duration: 6 min 44 sec CHANGE SET Re

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 123 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/123/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 07 Nov 2015 12:17:29 + Build duration: 2 min 36 sec CHANGE SET Revision

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125877/ --- (Updated Nov. 7, 2015, 12:30 p.m.) Status -- This change has been ma

Re: Review Request 125790: Recognize image/vnd.adobe.photoshop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125790/ --- (Updated Nov. 7, 2015, 12:28 p.m.) Status -- This change has been ma

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125877/#review88135 --- Ship it! Thanks !! - David Faure On Nov. 7, 2015, 12:10 p.

Re: Review Request 125790: Recognize image/vnd.adobe.photoshop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125790/ --- (Updated Nov. 7, 2015, 12:19 nachm.) Review request for KDE Frameworks.

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125877/ --- (Updated Nov. 7, 2015, 12:10 p.m.) Review request for KDE Frameworks. R

Re: Build and test failures with Qt 5.6 and Qt 5.3

>> - [5.3] kactivities: won't build due to QQuickWidget::setClearColor which >> is 5.4+ only. > > Ivan, can this be worked around? I'll have to check. (if nothing else, I'll disable that part - it is for the settings module, not really a part of the framework) For how long are we going to support

Policy on order of include guards and license texts

Hi, should include guards be put above or below the license text (for KDE in general)? Should the answer also go into https://techbase.kde.org/Policies/Kdelibs_Coding_Style ? Best regards, Martin Walch -- ___ Kde-frameworks-devel mailing list Kde-fr

Updating techbase wiki page according to KF5 policies

Hi, the techbase wiki says > If you add #includes for Qt classes, use both the module and class name. > This allows library code to be used by applications without excessive > compiler include paths. Taken from: https://techbase.kde.org/Policies/Kdelibs_Coding_Style As far as I have understood

Re: [CRITICAL] KIO Test "threadtest" can enter into infinite loop

On Sat, Nov 7, 2015 at 11:23 PM, David Faure wrote: > On Saturday 07 November 2015 10:36:18 David Faure wrote: >> On Saturday 07 November 2015 11:17:31 Ben Cooksley wrote: >> > Hi all, >> > >> > It appears the test running with the binary name of "threadtest" in >> > kio has a grave bug which can

Re: Build and test failures with Qt 5.6 and Qt 5.3

On Friday 06 November 2015 17:21:33 Jan Kundrát wrote: > Hi folks, > please take a look at the CI status matrix at [1]. TL;DR: There are build > failures with Qt 5.3, plenty of test failures, and some test failures > specific to the still unreleased Qt 5.6. > > Oh, and a cmake 3.4-git regression

Re: Review Request 125790: Recognize image/vnd.adobe.photoshop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125790/#review88128 --- /usr/share/mime/aliases says image/x-psd image/vnd.adobe.photo

Re: Review Request 125788: [kio thumbnailer] Recognize image/webp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125788/#review88127 --- In fact image/webp is the only mimetype that is defined in (sh

Re: Re[2]: Failure while executing KTar::open while using KCompressionDevice as the device

On Saturday 07 November 2015 12:18:56 Nick Shaforostoff wrote: > > Aleix suggested QBuffer, but archives can be *huge*, so this might > > eat all available memory. This is the reason why KTar uses a temp file > > for the compressed-tar case. > > qbuffer may be used for decompressing archives that

Re: [CRITICAL] KIO Test "threadtest" can enter into infinite loop

On Saturday 07 November 2015 10:36:18 David Faure wrote: > On Saturday 07 November 2015 11:17:31 Ben Cooksley wrote: > > Hi all, > > > > It appears the test running with the binary name of "threadtest" in > > kio has a grave bug which can lead to it entering into an infinite > > loop. > > > > Thi

Re[2]: Failure while executing KTar::open while using KCompressionDevice as the device

> Aleix suggested QBuffer, but archives can be *huge*, so this might > eat all available memory. This is the reason why KTar uses a temp file > for the compressed-tar case. qbuffer may be used for decompressing archives that are e.g. less than 50% of free ram if an archive is larger then tmpfile

Re: Review Request 125971: k7zip: fix memleaks, lower memory usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125971/ --- (Updated Nov. 7, 2015, 10:07 a.m.) Status -- This change has been ma

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 161 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/161/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Nov 2015 09:31:41 + Build duration: 5 min 7 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Re: [CRITICAL] KIO Test "threadtest" can enter into infinite loop

On Saturday 07 November 2015 11:17:31 Ben Cooksley wrote: > Hi all, > > It appears the test running with the binary name of "threadtest" in > kio has a grave bug which can lead to it entering into an infinite > loop. > > This was consuming virtually the entire resources of one builder with > old

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125974/#review88126 --- BTW why create a KTar on top of a KCompressionDevice? KTar is

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125974/#review88125 --- src/ktar.cpp (line 480)

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

> On Nov. 6, 2015, 7:52 a.m., David Faure wrote: > > src/karchive.cpp, line 652 > > > > > > This is not equivalent to seek(d->pos). > > seek(d->pos) goes to the absolute position d->pos, counting from the >

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 160 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/160/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Nov 2015 09:18:54 + Build duration: 1 min 5 sec CHANGE SET Revision 11ec27748cf6562daaf1ee6f15fe4b332affdb65 by

Jenkins-kde-ci: kxmlgui master kf5-qt5 » Linux,gcc - Build # 34 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/34/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Nov 2015 09:13:09 + Build duration: 39 sec CHANGE SET No changes ___

plasma-frameworks unittest still broken

Good morning from the unit test police... https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/122/console 03:08:59 FAIL! : DialogNativeTest::size() Compared values are not the same 03:08:59Actual (m_dialog->width()): 112 03:08:59Expec

Re: icon frameworks

On Friday 06 November 2015 11:27:36 Harald Sitter wrote: > Quick update with > > On Thu, Nov 5, 2015 at 10:07 AM, Harald Sitter wrote: > > - breeze-icons is a new repo going to be split from breeze and moving > > to frameworks (tier1) > > This is now in frameworks and open to push to. > > > - o

Re: Failure while executing KTar::open while using KCompressionDevice as the device

On Friday 06 November 2015 08:47:34 Luiz Romário Santana Rios wrote: > 2015-11-06 4:48 GMT-03:00 David Faure : > > On Monday 02 November 2015 14:53:40 Luiz Romário Santana Rios wrote: > >> > >> I'm trying to decompress a XZ archive downloaded using > >> QNetworkAccessManager, so, according to the d

Re: Fwd: KF5 plugins and PLUGIN_INSTALL_DIR vs QT_PLUGIN_INSTALL_DIR

On Friday 06 November 2015 11:26:44 René J.V. Bertin wrote: > > What is going wrong here, and why? What's going wrong is that your KF5 install prefix isn't known to Qt, evidently. We solve this on Linux by - setting the environment variable QT_PLUGIN_PATH, in the developer case (KF5 install pr

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

> On Oct. 29, 2015, 8:26 p.m., Aleix Pol Gonzalez wrote: > > autotests/kdeplatformtheme_unittest.cpp, line 237 > > > > > > What does `qApp->wheelScrollLines()` return now? > > David Rosca wrote: > It returne

Re: Review Request 125971: k7zip: fix memleaks, lower memory usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125971/#review88120 --- Ship it! Looks good. Please do a "make test" before pushing,