Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-11-01 Thread David Faure
> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 30 - Still Unstable!

2015-11-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/30/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 Nov 2015 05:48:11 + Build duration: 2 min 3 sec CHANGE SET Revision e840f5fb12287a0324597832bb

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 28 - Fixed!

2015-11-01 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 Nov 2015 05:48:11 + Build duration: 1 min 59 sec CHANGE SET Revision e840f5fb12287a03245

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 28 - Fixed!

2015-11-01 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 Nov 2015 05:48:11 + Build duration: 1 min 59 sec CHANGE SET Revision e840f5fb12287a03245

Re: Review Request 125915: Drop runtime dependency on QApplication

2015-11-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125915/#review87827 --- src/platforms/xcb/kwindowsystem.cpp (line 585)

Re: Review Request 125911: EventGenerator: Add support for sending wheel events

2015-11-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125911/#review87826 --- Ship it! Ship It! - David Edmundson On Nov. 1, 2015, 10:53

Re: Review Request 125905: Make kactivitymanagerd a QApplication

2015-11-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/#review87825 --- I've made https://git.reviewboard.kde.org/r/125915/ - David E

Review Request 125915: Drop runtime dependency on QApplication

2015-11-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125915/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 125884: Set default value for WheelScrollLines

2015-11-01 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125884/#review87824 --- Ship it! Ship It! - Jeremy Whiting On Oct. 30, 2015, 3 p.m

Re: [kdeclarative] src/quickaddons: fix ciritical regression for QuickViewSharedEngine by commit 3792923639b1c480fd622f7d4d31f6f888c925b9

2015-11-01 Thread Takahiro HASHIMOTO
Thanks for your notice. I'l do it. 2015-10-29 17:33 GMT+09:00 David Faure : > On Thursday 22 October 2015 00:08:55 Takahiro Hashimoto wrote: > > Git commit 1c3f42afe17cc090372eaf45647d71495de12c19 by Takahiro > Hashimoto. > > Committed on 22/10/2015 at 00:03. > > Pushed by hashimoto into branch '

Re: Review Request 125905: Make kactivitymanagerd a QApplication

2015-11-01 Thread Albert Astals Cid
> On nov. 1, 2015, 11:49 a.m., Ivan Čukić wrote: > > So, we went a full circle back to QApplication :) > > > > What assert are you hitting on unity? KWindowSystem uses QApplication::desktopWidget which you can't if you're not a QApplication - Albert

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-11-01 Thread Christoph Cullmann
> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Re: Review Request 125911: EventGenerator: Add support for sending wheel events

2015-11-01 Thread David Rosca
> On Nov. 1, 2015, 4:10 p.m., David Edmundson wrote: > > src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp, line 95 > > > > > > sendWheelEventRecursive here, no? No, the "recursion" is done with allChildIte

Re: Review Request 125911: EventGenerator: Add support for sending wheel events

2015-11-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125911/#review87809 --- src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp (line

Re: Review Request 125905: Make kactivitymanagerd a QApplication

2015-11-01 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/#review87792 --- So, we went a full circle back to QApplication :) What assert

Review Request 125911: EventGenerator: Add support for sending wheel events

2015-11-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125911/ --- Review request for KDE Frameworks. Repository: kdeclarative Description