Review Request 125905: Make kactivitymanagerd a QApplication

2015-10-31 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/ --- Review request for KDE Frameworks, Martin Gräßlin and Ivan Čukić. Reposit

Re: Review Request 125904: Save proxy url with correct scheme.

2015-10-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125904/#review87791 --- src/kcms/kio/kproxydlg.cpp (line 106)

Review Request 125904: Save proxy url with correct scheme.

2015-10-31 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125904/ --- Review request for KDE Frameworks and Eike Hein. Repository: kio Descri

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 124 - Still Unstable!

2015-10-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/124/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 31 Oct 2015 21:28:49 + Build duration: 3 min 18 sec CHANGE SET Re

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 115 - Still Unstable!

2015-10-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/115/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 31 Oct 2015 21:28:49 + Build duration: 2 min 44 sec CHANGE SET Revision

Re: Review Request 125885: Support socks5 proxy in KTcpSocket

2015-10-31 Thread Xuetian Weng
> On Oct. 31, 2015, 8:39 a.m., David Faure wrote: > > This is clearly missing an "else" for other cases like an http proxy, can > > you add it, even without being able to test it? > > > > In any case this is a clear improvement. > > Xuetian Weng wrote: > I'm not aware that http proxy can h

Re: Review Request 125885: Support socks5 proxy in KTcpSocket

2015-10-31 Thread Xuetian Weng
> On Oct. 31, 2015, 8:39 a.m., David Faure wrote: > > This is clearly missing an "else" for other cases like an http proxy, can > > you add it, even without being able to test it? > > > > In any case this is a clear improvement. I'm not aware that http proxy can handle arbitrary tcp connection

Re: Review Request 125779: properly handle middle click in navigatormenu

2015-10-31 Thread Ilia Kats
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125779/ --- (Updated Oct. 31, 2015, 10:11 a.m.) Status -- This change has been m

Re: Review Request 125885: Support socks5 proxy in KTcpSocket

2015-10-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125885/#review87773 --- Ship it! This is clearly missing an "else" for other cases li