Review Request 125885: Support socks5 proxy in KTcpSocket

2015-10-30 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125885/ --- Review request for KDE Frameworks and David Faure. Bugs: 342402 https

Re: Review Request 125884: Set default value for WheelScrollLines

2015-10-30 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125884/#review87766 --- +1. - Luca Beltrame On Ott. 30, 2015, 10 p.m., David Rosca

Re: Review Request 125833: Use QStringLiteral in generated code

2015-10-30 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125833/ --- (Updated Oct. 30, 2015, 10:31 p.m.) Status -- This change has been m

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 47 - Fixed!

2015-10-30 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Oct 2015 21:06:32 + Build duration: 3 min 39 sec CHANGE SET Revision 4ca3237c2e07ac035104af5730bd209c18

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 47 - Fixed!

2015-10-30 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Oct 2015 21:06:32 + Build duration: 3 min 39 sec CHANGE SET Revision 4ca3237c2e07ac035104af5730bd209c18

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 48 - Fixed!

2015-10-30 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/48/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Oct 2015 21:06:32 + Build duration: 1 min 57 sec CHANGE SET Revision 4ca3237c2e07ac035104af5730b

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 48 - Fixed!

2015-10-30 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/48/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Oct 2015 21:06:32 + Build duration: 1 min 57 sec CHANGE SET Revision 4ca3237c2e07ac035104af5730b

Review Request 125884: Set default value for WheelScrollLines

2015-10-30 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125884/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread David Rosca
> On Oct. 30, 2015, 7:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? > > David Rosca wrote: > Broke in what way? Did you try if it works without this commit? > > Lu

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread Luca Beltrame
> On Ott. 30, 2015, 8:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? > > David Rosca wrote: > Broke in what way? Did you try if it works without this commit? > > Lu

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread David Rosca
> On Oct. 30, 2015, 7:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? > > David Rosca wrote: > Broke in what way? Did you try if it works without this commit? > > Lu

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread Luca Beltrame
> On Ott. 30, 2015, 8:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? > > David Rosca wrote: > Broke in what way? Did you try if it works without this commit? > > Lu

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread David Rosca
> On Oct. 30, 2015, 7:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? > > David Rosca wrote: > Broke in what way? Did you try if it works without this commit? > > Lu

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread Luca Beltrame
> On Ott. 30, 2015, 8:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? > > David Rosca wrote: > Broke in what way? Did you try if it works without this commit? I just

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread David Rosca
> On Oct. 30, 2015, 7:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? Broke in what way? Did you try if it works without this commit? - David

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125863/#review87757 --- It looks like this broke mouse wheel scrolling for me (on Qt 5

Re: Review Request 125875: Fix build for Qt < 5.5

2015-10-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125875/#review87743 --- Seems David Faure committed the same thing. commit 7a0639c692

Re: Review Request 125875: Fix build for Qt < 5.5

2015-10-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125875/ --- (Updated Oct. 30, 2015, 1:58 p.m.) Status -- This change has been ma

Re: Review Request 125164: Finish killed KIO jobs

2015-10-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/ --- (Updated Oct. 30, 2015, 12:46 p.m.) Review request for KDE Frameworks.

Re: icons packages with frameworks

2015-10-30 Thread Harald Sitter
On Thu, Oct 22, 2015 at 10:12 AM, David Faure wrote: > On Wednesday 21 October 2015 21:07:16 Christoph Cullmann wrote: >> Hi, >> >> >> So maybe this wouldn't be such a bad move after all. >> > >> > Agreed, we have frameworks (e.g. KIconThemes) "depending" on breeze, so it >> > makes some kind of s

Jenkins-kde-ci: kauth master stable-kf5-qt5 » Linux,gcc - Build # 25 - Fixed!

2015-10-30 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kauth%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Oct 2015 08:09:50 + Build duration: 1 min 27 sec CHANGE SET Revision 7a0639c692ea2054049c020bd1b309d369

Jenkins-kde-ci: kauth master stable-kf5-qt5 » Linux,gcc - Build # 25 - Fixed!

2015-10-30 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kauth%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Oct 2015 08:09:50 + Build duration: 1 min 27 sec CHANGE SET Revision 7a0639c692ea2054049c020bd1b309d369

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-30 Thread Christoph Cullmann
> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-30 Thread David Faure
> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-30 Thread Christoph Cullmann
> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Re: Review Request 125874: make kio_http_cache_cleaner deployable in application installer/bundles

2015-10-30 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125874/ --- (Updated Oct. 30, 2015, 8:13 a.m.) Status -- This change has been ma

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/#review87727 --- src/extractors/externalextractor.cpp (line 69)

Re: Review Request 125449: Add support for desktop file name to KAboutData

2015-10-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125449/ --- (Updated Oct. 30, 2015, 8:01 a.m.) Status -- This change has been ma

Re: Review Request 125875: Fix build for Qt < 5.5

2015-10-30 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125875/#review87725 --- +1 - Luca Beltrame On Ott. 29, 2015, 7:55 p.m., David Edmun

Re: Review Request 125766: Changed the manual command line parsing to use QCommandLineParser.

2015-10-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125766/#review87724 --- Ship it! src/kded.cpp (line 684)

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-30 Thread Christoph Cullmann
> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Re: Review Request 125833: Use QStringLiteral in generated code

2015-10-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125833/#review87722 --- Ship it! Ship It! - David Faure On Oct. 28, 2015, 7:32 a.m

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/#review87721 --- src/ioslaves/file/file.cpp (line 80)

Re: Review Request 125874: make kio_http_cache_cleaner deployable in application installer/bundles

2015-10-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125874/#review87720 --- Ship it! Ship It! - David Faure On Oct. 29, 2015, 5:21 p.m

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-30 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/#review87719 --- Ping? :-) - Boudhayan Gupta On Oct. 24, 2015, 5:49 p.m., Bo