Re: Review Request 125830: Read protocol info from plugin metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125830/#review87561 --- Looks good to me if it still works. I don't really like all

Re: Review Request 125800: OS X build and warning fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125800/ --- (Updated Oct. 27, 2015, 11:01 p.m.) Review request for KDE Frameworks and

Re: Review Request 125830: Read protocol info from plugin metadata

> On Oct. 27, 2015, 10:23 p.m., Alex Merry wrote: > > src/core/kprotocolinfo.cpp, lines 121-122 > > > > > > I would still rather calculate this information - protocol is the key > > from the iterated map, and ex

Re: Review Request 125830: Read protocol info from plugin metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125830/ --- (Updated Oct. 27, 2015, 10:31 p.m.) Review request for KDE Frameworks, Al

Re: QVariant precision issues

David Edmundson wrote: > qFuzzyCompare ? Yes, QVariant uses qFuzzyCompare internally, which means you get the precision that qFuzzyCompare hardcodes. You need to extract the double if you want to do something else. We hit the same problem in work: double d1 = 1.0001; double d2 = 1

Re: Review Request 125830: Read protocol info from plugin metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125830/#review87558 --- src/core/kprotocolinfo.cpp (lines 121 - 122)

Re: QVariant precision issues

qFuzzyCompare ? ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: QVariant precision issues

Hi, i guess the test should use values representable, e.g not stuff like 0.2. doubles are stored in 2 not 10 base. Greetings Christoph - Albert Astals Cid schrieb: > Hi, i remember a while ago an issue with QVariant not storing doubles the > same > way it used to in this list. > > We se

QVariant precision issues

Hi, i remember a while ago an issue with QVariant not storing doubles the same way it used to in this list. We seem to have hit that in step https://build.kde.org/job/step%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/ 19/testReport/%28root%29/TestSuite/stepcore_test_metaobject/ Does anyone rem

Re: Review Request 125343: bump so version from 5 to 6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125343/#review87548 --- Ping; John, can you have a look please? - Martin Klapetek O

Re: Review Request 125819: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125819/ --- (Updated Oct. 27, 2015, 6:46 p.m.) Status -- This change has been ma

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/ --- (Updated Oct. 27, 2015, 7:30 p.m.) Review request for KDE Frameworks, Pla

Re: Review Request 125819: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125819/#review87536 --- Ship it! Don't forget to change the commit message to reflect

Review Request 125830: Read protocol info from plugin metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125830/ --- Review request for KDE Frameworks, Alex Richardson and David Faure. Repos

Re: Review Request 125797: protocoltojson application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125797/ --- (Updated Oct. 27, 2015, 4:54 p.m.) Status -- This change has been ma

Re: Review Request 125797: protocoltojson application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125797/#review87527 --- Ship it! - Alex Richardson On Oct. 26, 2015, 5:03 p.m., Chr

Re: Review Request 125797: protocoltojson application

> On Oct. 26, 2015, 5:27 p.m., Alex Richardson wrote: > > The protocoltojson program will have to read the plugin metadata.json file > > to insert the "KDE-KIO-Protocols" to that json file as it is not possible > > to embed more than one JSON file into a Qt plugin. > > > > I am not sure whethe

Re: Review Request 125797: protocoltojson application

> On Oct. 26, 2015, 5:27 p.m., Alex Richardson wrote: > > The protocoltojson program will have to read the plugin metadata.json file > > to insert the "KDE-KIO-Protocols" to that json file as it is not possible > > to embed more than one JSON file into a Qt plugin. > > > > I am not sure whethe

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 123 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/123/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 27 Oct 2015 11:07:23 + Build duration: 3 min 21 sec CHANGE SET Re

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 114 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/114/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 27 Oct 2015 11:07:23 + Build duration: 3 min 7 sec CHANGE SET Revision 7

Re: Review Request 125819: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125819/ --- (Updated Okt. 27, 2015, 8:41 vorm.) Review request for KDE Frameworks.

Re: Review Request 125819: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces

> On Okt. 26, 2015, 10:03 nachm., Alex Merry wrote: > > This shouldn't be necessary. I think the issue you're having is that you're > > giving the wrong arguments to CMake. Rather than using > > > > -DCMAKE_INSTALL_FULL_DATAROOTDIR:PATH=/usr/share > > > > you should be using > > > > -

Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

> On Oct. 27, 2015, 8 a.m., David Faure wrote: > > src/widgets/kopenwithdialog.cpp, line 970 > > > > > > This else should be removed, then. > > > > There's no reason to only set m_pService when mimetype

Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125691/#review87487 --- Ah OK. When creating a KOpenWithDialog without a mimetype argu

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 99 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/99/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Oct 2015 07:41:07 + Build duration: 4 min 8 sec CHANGE SET Revision 0f816ab3fada9f57e836da78470003dd

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 99 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/99/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Oct 2015 07:41:07 + Build duration: 4 min 8 sec CHANGE SET Revision 0f816ab3fada9f57e836da78470003dd

Re: Review Request 125803: KBuildSycoca: always save, even if no change in .desktop file was noticed.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125803/ --- (Updated Oct. 27, 2015, 7:40 a.m.) Status -- This change has been ma