Re: Review Request 125590: Patch for kimageformats that handles xcfgz / xcfbz2 (compressed GIMP) images (read-only).

2015-10-24 Thread Tudor PRISTAVU
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125590/ --- (Updated Oct. 25, 2015, 3:04 a.m.) Review request for KDE Frameworks and

Re: Review Request 125779: properly handle middle click in navigatormenu

2015-10-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125779/#review87352 --- Thanks for the patch! src/filewidgets/kurlnavigatorbutton.cp

Re: Review Request 125778: Allow kio .protocol files to be app local and local kioslave deployment

2015-10-24 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125778/ --- (Updated Oct. 24, 2015, 7:06 p.m.) Review request for KDE Frameworks and

Review Request 125779: properly handle middle click in navigatormenu

2015-10-24 Thread Ilia Kats
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125779/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 125778: Allow kio .protocol files to be app local

2015-10-24 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125778/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 125772: Improve search for drkonqui and keep it silent per default if not found

2015-10-24 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125772/ --- (Updated Oct. 24, 2015, 6:25 p.m.) Status -- This change has been ma

Jenkins-kde-ci: kio master kf5-qt5 ยป Linux,gcc - Build # 141 - Unstable!

2015-10-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/141/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 24 Oct 2015 18:02:50 + Build duration: 8 min 5 sec CHANGE SET Revision f2c96d1550f22600f1b6dee74851c25a3f733ef4 b

Re: Review Request 125772: Improve search for drkonqui and keep it silent per default if not found

2015-10-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125772/#review87344 --- Ship it! Ship It! - David Faure On Oct. 24, 2015, 2:27 p.m

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

2015-10-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125515/ --- (Updated Oct. 24, 2015, 6:02 p.m.) Status -- This change has been ma

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

2015-10-24 Thread David Faure
> On Oct. 22, 2015, 4:32 p.m., Frank Reininghaus wrote: > > 4096 bytes looks reasonable. I think I would still find a fail-safe > > solution with a dynamically increasing buffer prettier, but it's so > > extremely unlikely that this will ever cause problems that it's not worth > > arguing abou

Re: icons packages with frameworks

2015-10-24 Thread Christoph Cullmann
Hi, works now with master branch, thanks for the reviews. http://kate-editor.org/2015/10/24/katekwrite-on-mac-more-icons-more-plugins/ Toolbars with icons without any hacking, how cool is that ;) Greetings Christoph - Am 23. Okt 2015 um 8:34 schrieb cullmann cullm...@absint.com: > Hi, >

Re: Review Request 125772: Improve search for drkonqui and keep it silent per default if not found

2015-10-24 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125772/ --- (Updated Oct. 24, 2015, 2:27 p.m.) Review request for KDE Frameworks and

Review Request 125772: Improve search for drkonqui and keep it silent per default if not found

2015-10-24 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125772/ --- Review request for KDE Frameworks and David Faure. Repository: kcrash D

Re: Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons

2015-10-24 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125760/ --- (Updated Oct. 24, 2015, 1:10 p.m.) Status -- This change has been ma

Re: Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons

2015-10-24 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125760/#review87338 --- Ship it! Ship It! - Boudewijn Rempt On Oct. 23, 2015, 5:28

Re: Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons

2015-10-24 Thread Christoph Cullmann
> On Oct. 23, 2015, 9:46 p.m., Aleix Pol Gonzalez wrote: > > +1 looks good to me. Ship it from someone? - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125760/#review87320 --

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-24 Thread Boudhayan Gupta
> On Oct. 24, 2015, 6 p.m., Vishesh Handa wrote: > > I still have many thoughts regarding this particular approach, and third > > party plugins in general. I'm trying to write them into a cohesive blob. Do you mean the entire current extractor interface, or just this patch? What do you mean, "

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-24 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/#review87334 --- I still have many thoughts regarding this particular approach,

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-24 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/ --- (Updated Oct. 24, 2015, 5:49 p.m.) Review request for Baloo, KDE Framewor

Re: Question about goal of Windows/Mac frameworks

2015-10-24 Thread Kevin Ottens
Hello, On Wednesday 21 October 2015 22:22:54 Christoph Cullmann wrote: > > On Wednesday 21 October 2015 21:06:02 Christoph Cullmann wrote: > > My concern there is more the fact that this kind of "short term" or > > "temporary" solutions tend to become permanent. As long as it is causing > > pain y

Re: Question about goal of Windows/Mac frameworks

2015-10-24 Thread Kevin Ottens
Hello, On Friday 23 October 2015 16:35:36 Luigi Toscano wrote: > On Wednesday 21 of October 2015 20:09:33 Kevin Ottens wrote: > > And then, three areas of efforts which we are missing right now in > > Frameworks: - systematically try to reduce the tier and type of our > > frameworks (the maturity