Re: phonon hassle to build WAS: Re: Policy for Dependencies

2015-10-13 Thread Christoph Cullmann
Hi, > On Wed, Oct 14, 2015 at 8:47 AM, Christoph Cullmann > wrote: >>> On Tue, Oct 13, 2015 at 8:42 AM, Christoph Cullmann >>> wrote: phonon is a hassle on both win/mac (if you don't require audio, like most applications won't) >>> >>> Oo >>> >>> explain please? >> Hi, >> >> to build

Re: phonon hassle to build WAS: Re: Policy for Dependencies

2015-10-13 Thread Harald Sitter
On Wed, Oct 14, 2015 at 8:47 AM, Christoph Cullmann wrote: >> On Tue, Oct 13, 2015 at 8:42 AM, Christoph Cullmann >> wrote: >>> phonon is a hassle on both win/mac (if you don't require audio, like most >>> applications won't) >> >> Oo >> >> explain please? > Hi, > > to build phonon with an usabl

Re: phonon hassle to build WAS: Re: Policy for Dependencies

2015-10-13 Thread Christoph Cullmann
> On Tue, Oct 13, 2015 at 8:42 AM, Christoph Cullmann > wrote: >> phonon is a hassle on both win/mac (if you don't require audio, like most >> applications won't) > > Oo > > explain please? Hi, to build phonon with an usable backends is work on mac and win and e.g. Kate uses no sounds at all

phonon hassle to build WAS: Re: Policy for Dependencies

2015-10-13 Thread Harald Sitter
On Tue, Oct 13, 2015 at 8:42 AM, Christoph Cullmann wrote: > phonon is a hassle on both win/mac (if you don't require audio, like most > applications won't) Oo explain please? ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://

Re: Policy for Dependencies

2015-10-13 Thread Martin Graesslin
On Tuesday, October 13, 2015 10:07:18 PM CEST Jaroslaw Staniek wrote: > Hi, > Just wanted to say I'd like to minimize dependencies for Kexi on Windows > too, among other things. > > With my realistic hat on, risky ideas are like: > - depending on kdecoration to just have default icons I hope that

Re: Policy for Dependencies

2015-10-13 Thread Martin Klapetek
Hey, On Tue, Oct 13, 2015 at 6:20 PM, Christoph Cullmann wrote: > > I hope I didn't upset anybody, just got a bit frustrated by the current > state of > the art. Alone how many patches for all our stuff are floating around in > the net > to make it somehow buildable instead of some solution insi

Re: Policy for Dependencies

2015-10-13 Thread Christoph Cullmann
Hi, >> > I disagree, phonon and dbus are available on OSX and could be made to work >> > so having a ECM_BUILD_FOR_OSX_APPBUNDLE that disables perfectly valid >> > features doesn't make sense to me. >> >> Albert, >> From the fact that some foreign solution (dbus is foreign to OSX and >> for that

Re: Policy for Dependencies

2015-10-13 Thread Luigi Toscano
Albert Astals Cid ha scritto: > El Wednesday 14 October 2015, a les 00:07:10, Jaroslaw Staniek va escriure: >> >> Your view may be different, more workspace-related, your definition of >> portability may be different too. I am looking at code that uses KF5 >> as a Qt code in the first place. Qt do

Re: Policy for Dependencies

2015-10-13 Thread Albert Astals Cid
El Wednesday 14 October 2015, a les 00:07:10, Jaroslaw Staniek va escriure: > On 13 October 2015 at 23:22, Albert Astals Cid wrote: > > El Tuesday 13 October 2015, a les 08:55:27, Martin Graesslin va escriure: > > > On Tuesday, October 13, 2015 8:42:43 AM CEST Christoph Cullmann wrote: > > > > Hi,

Re: Policy for Dependencies

2015-10-13 Thread Christoph Cullmann
Hi, > El Tuesday 13 October 2015, a les 23:59:33, Christoph Cullmann va escriure: >> Hi, >> >> >> Ok, after the reasonable criticisms of making the sound stuff optional in >> >> knotifications per default: >> >> >> >> Could we have some ECM switch like (name is just an example): >> >> >> >> opt

Re: Policy for Dependencies

2015-10-13 Thread Albert Astals Cid
El Tuesday 13 October 2015, a les 23:59:33, Christoph Cullmann va escriure: > Hi, > > >> Ok, after the reasonable criticisms of making the sound stuff optional in > >> knotifications per default: > >> > >> Could we have some ECM switch like (name is just an example): > >> > >> option(KDE_ENABLE_

Re: Policy for Dependencies

2015-10-13 Thread Jaroslaw Staniek
On 13 October 2015 at 23:22, Albert Astals Cid wrote: > > El Tuesday 13 October 2015, a les 08:55:27, Martin Graesslin va escriure: > > On Tuesday, October 13, 2015 8:42:43 AM CEST Christoph Cullmann wrote: > > > Hi, > > > > thanks for raising this topic. I think it's very important that we have a

Re: Policy for Dependencies

2015-10-13 Thread Christoph Cullmann
Hi, > On 2015-10-13, Martin Graesslin wrote: >> I'm not sure whether it's the best solution. The problem you try to fix with >> it is distros breaking packaging. I agree with Martin K that this is a huge >> problem and that it will happen - since the automation of packages I also >> experienced t

Re: Policy for Dependencies

2015-10-13 Thread Christoph Cullmann
Hi, >> Ok, after the reasonable criticisms of making the sound stuff optional in >> knotifications per default: >> >> Could we have some ECM switch like (name is just an example): >> >> option(KDE_ENABLE_MINIMAL_DEPENDENCIES "Will switch as many dependencies >> from required to optional as possi

Re: Policy for Dependencies

2015-10-13 Thread Albert Astals Cid
El Tuesday 13 October 2015, a les 14:20:31, Christoph Cullmann va escriure: > Hi, > > different take on that below: > > Hi, > > > >> On Tuesday, October 13, 2015 8:42:43 AM CEST Christoph Cullmann wrote: > >>> Hi, > >> > >> thanks for raising this topic. I think it's very important that we have

Re: Policy for Dependencies

2015-10-13 Thread Albert Astals Cid
El Tuesday 13 October 2015, a les 08:55:27, Martin Graesslin va escriure: > On Tuesday, October 13, 2015 8:42:43 AM CEST Christoph Cullmann wrote: > > Hi, > > thanks for raising this topic. I think it's very important that we have a > general strategy for frameworks and not have thousands of micro

Re: Review Request 125619: Refactor KNewPasswordDialog class

2015-10-13 Thread Thomas Pfeiffer
> On Oct. 13, 2015, 1:33 p.m., Aleix Pol Gonzalez wrote: > > File Attachment: knewpassworddialog4.png - knewpassworddialog4.png > > > > > > Shouldn't it have a red background when empty as well? > > Elvis Angelaccio wrote: > I'm not

Review Request 125628: KTempDir: Make sense out of s_umask initialization

2015-10-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125628/ --- Review request for KDE Frameworks. Repository: kdelibs4support Descript

Re: Policy for Dependencies

2015-10-13 Thread Jaroslaw Staniek
Hi, Just wanted to say I'd like to minimize dependencies for Kexi on Windows too, among other things. With my realistic hat on, risky ideas are like: - depending on kdecoration to just have default icons - build-time depending on xml/docbook processing tools to just have core KF5 libs built - depe

Re: Policy for Dependencies

2015-10-13 Thread Sune Vuorela
On 2015-10-13, Martin Graesslin wrote: > I'm not sure whether it's the best solution. The problem you try to fix with > it is distros breaking packaging. I agree with Martin K that this is a huge > problem and that it will happen - since the automation of packages I also > experienced that nobo

Re: Review Request 125483: [KDBusService] Don't exit after calling Activate if user specified NoExitOnFailure flag

2015-10-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125483/ --- (Updated Oct. 13, 2015, 9:12 p.m.) Status -- This change has been di

Re: Review Request 125483: [KDBusService] Don't exit after calling Activate if user specified NoExitOnFailure flag

2015-10-13 Thread Martin Klapetek
> On Oct. 2, 2015, 10:35 p.m., David Faure wrote: > > Sending Activate to a running Unique process is not a failure, so > > NoExitOnFailure should not affect it. > > > > If you need a "no exit, ever" flag, then I would recommend adding a > > separate flag for that. I'm not sure I understand th

Re: Policy for Dependencies

2015-10-13 Thread Christoph Cullmann
Hi, >> I'm not sure whether it's the best solution. The problem you try to fix with >> it is distros breaking packaging. I agree with Martin K that this is a huge >> problem and that it will happen - since the automation of packages I also >> experienced that nobody looks at the output of optional

Re: Review Request 125619: Refactor KNewPasswordDialog class

2015-10-13 Thread Elvis Angelaccio
> On Oct. 13, 2015, 1:33 p.m., Aleix Pol Gonzalez wrote: > > File Attachment: knewpassworddialog4.png - knewpassworddialog4.png > > > > > > Shouldn't it have a red background when empty as well? I'm not sure honestly. Wouldn't be a litt

Re: Review Request 125619: Refactor KNewPasswordDialog class

2015-10-13 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/#review86807 --- Nice work. I would add information where the request comes fro

Review Request 125621: Missing color initialization in KNewPasswordWidget

2015-10-13 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125621/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidget

Re: Policy for Dependencies

2015-10-13 Thread Christoph Cullmann
Hi, >> Ok, after the reasonable criticisms of making the sound stuff optional in >> knotifications per default: >> >> Could we have some ECM switch like (name is just an example): >> >> option(KDE_ENABLE_MINIMAL_DEPENDENCIES "Will switch as many dependencies >> from required to optional as possi

Review Request 125619: Refactor KNewPasswordDialog class

2015-10-13 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/ --- Review request for KDE Frameworks, Christoph Feck and David Faure. Reposi

Re: Review Request 125619: Refactor KNewPasswordDialog class

2015-10-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/#review86806 --- File Attachment: knewpassworddialog4.png - knewpassworddialog

Re: Policy for Dependencies

2015-10-13 Thread Martin Graesslin
On Tuesday, October 13, 2015 2:20:31 PM CEST Christoph Cullmann wrote: > Hi, > > different take on that below: > > Hi, > > > >> On Tuesday, October 13, 2015 8:42:43 AM CEST Christoph Cullmann wrote: > >>> Hi, > >> > >> thanks for raising this topic. I think it's very important that we have a > >

Re: Policy for Dependencies

2015-10-13 Thread Christoph Cullmann
Hi, >> Ok, after the reasonable criticisms of making the sound stuff optional in >> knotifications per default: >> >> Could we have some ECM switch like (name is just an example): >> >> option(KDE_ENABLE_MINIMAL_DEPENDENCIES "Will switch as many dependencies from >> required to optional as possibl

Re: Policy for Dependencies

2015-10-13 Thread Aleix Pol
On Tue, Oct 13, 2015 at 2:20 PM, Christoph Cullmann wrote: > Hi, > > different take on that below: > >> Hi, >> >>> On Tuesday, October 13, 2015 8:42:43 AM CEST Christoph Cullmann wrote: Hi, >>> >>> thanks for raising this topic. I think it's very important that we have a >>> general strategy

Re: Review Request 125616: Make doctools + wallet optional

2015-10-13 Thread Christoph Cullmann
> On Oct. 12, 2015, 10:01 p.m., Albert Astals Cid wrote: > > People should known what they are missing when building without the > > dependencies, please specify so at the summary > > Christoph Cullmann wrote: > Yes, that is true, will update the patch tomorrow. > > Christoph Cullmann wrot

Re: phonon dep in knotifications

2015-10-13 Thread Christoph Cullmann
Hi, > On Mon, Oct 12, 2015 at 4:05 PM, Christoph Cullmann < cullm...@absint.com > > wrote: > > >> On 2015-10-12, Christoph Cullmann < cullm...@absint.com > wrote: >>> Hi, >>> >>> I would like to make this dependency optional. >>> Would that be ok? Is not that much work, but if it is not wanted,

Re: Policy for Dependencies

2015-10-13 Thread Christoph Cullmann
Hi, different take on that below: > Hi, > >> On Tuesday, October 13, 2015 8:42:43 AM CEST Christoph Cullmann wrote: >>> Hi, >> >> thanks for raising this topic. I think it's very important that we have a >> general strategy for frameworks and not have thousands of micro-fixes in >> various fram

Re: phonon dep in knotifications

2015-10-13 Thread Martin Klapetek
On Mon, Oct 12, 2015 at 4:05 PM, Christoph Cullmann wrote: > > On 2015-10-12, Christoph Cullmann wrote: > >> Hi, > >> > >> I would like to make this dependency optional. > >> Would that be ok? Is not that much work, but if it is not wanted, don't > want to > >> waste my time. > >> E.g. on Win/Ma

Re: [KDE/Mac] [OS X] adding a link module to all KF5 targets

2015-10-13 Thread René J . V . Bertin
Jeremy Whiting wrote: > That does sound like a bit more interesting question. Browsing through Bump ... I think I'll try a simpler approach, where I'd have to patch each toplevel CMake file (including of the frameworks themselves, to be exhaustive) to add a module in the find_package(Qt5 ${R

Re: Review Request 125615: Make phonon dependency optional

2015-10-13 Thread Martin Klapetek
> On Oct. 13, 2015, 4:26 a.m., Martin Klapetek wrote: > > As a maintainer, I would be much much more happy if it actually had a check > > for win/mac rather than making audio notifications optional always. Also > > speaking as someone who deals with knotifications bug reports. > > Martin Klape

Re: Review Request 125614: Enable normal rpath handling on Mac

2015-10-13 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125614/ --- (Updated Oct. 13, 2015, 11:39 a.m.) Status -- This change has been m

Re: Review Request 125614: Enable normal rpath handling on Mac

2015-10-13 Thread Christoph Cullmann
> On Oct. 12, 2015, 8:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > > a

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-10-13 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/ --- (Updated Oct. 13, 2015, 11:26 a.m.) Status -- This change has been m

Re: Review Request 125614: Enable normal rpath handling on Mac

2015-10-13 Thread René J . V . Bertin
> On Oct. 12, 2015, 10:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > >

Re: Review Request 125614: Enable normal rpath handling on Mac

2015-10-13 Thread Christoph Cullmann
> On Oct. 12, 2015, 8:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > > a

Re: Review Request 125614: Enable normal rpath handling on Mac

2015-10-13 Thread René J . V . Bertin
> On Oct. 12, 2015, 10:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > >

Re: Review Request 125614: Enable normal rpath handling on Mac

2015-10-13 Thread Christoph Cullmann
> On Oct. 12, 2015, 8:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > > a

Re: Review Request 125614: Enable normal rpath handling on Mac

2015-10-13 Thread René J . V . Bertin
> On Oct. 12, 2015, 10:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > >

Re: Policy for Dependencies

2015-10-13 Thread Christoph Cullmann
Hi, > On Tuesday, October 13, 2015 8:42:43 AM CEST Christoph Cullmann wrote: >> Hi, > > thanks for raising this topic. I think it's very important that we have a > general strategy for frameworks and not have thousands of micro-fixes in > various frameworks. ;=) > >> 1) "Normal" deployment like

Re: Review Request 125615: Make phonon dependency optional

2015-10-13 Thread Christoph Cullmann
> On Oct. 13, 2015, 7:05 a.m., Albert Astals Cid wrote: > > Does this take care of removing the audio section from the config > > notifications dialog? No, it doesn't. But actually that section won't be removed either if you have no matching phonon backend installed. - Christoph --

Re: Review Request 125615: Make phonon dependency optional

2015-10-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/#review86787 --- Does this take care of removing the audio section from the con

Re: Review Request 125615: Make phonon dependency optional

2015-10-13 Thread Christoph Cullmann
> On Oct. 13, 2015, 2:26 a.m., Martin Klapetek wrote: > > As a maintainer, I would be much much more happy if it actually had a check > > for win/mac rather than making audio notifications optional always. Also > > speaking as someone who deals with knotifications bug reports. > > Martin Klape

Re: Review Request 125615: Make phonon dependency optional

2015-10-13 Thread Albert Astals Cid
> On oct. 13, 2015, 2:26 a.m., Martin Klapetek wrote: > > As a maintainer, I would be much much more happy if it actually had a check > > for win/mac rather than making audio notifications optional always. Also > > speaking as someone who deals with knotifications bug reports. > > Martin Klape