Re: Review Request 125514: Add a web shortcut manager

2015-10-09 Thread Laurent Montel
> On oct. 7, 2015, 5:27 matin, Laurent Montel wrote: > > What about rename class ? No news so I will rename it to KUriFilterSearchProviderActions - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.revi

Re: Review Request 125575: Make program logo non-pixelated on HiDPI

2015-10-09 Thread Christoph Cullmann
> On Oct. 9, 2015, 6:42 p.m., David Edmundson wrote: > > src/kaboutapplicationdialog.cpp, line 94 > > > > > > This doesn't seem right. Sorry. > > > > setDevicePixelRatio should really only be done when lo

Re: Review Request 125575: Make program logo non-pixelated on HiDPI

2015-10-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125575/#review86566 --- src/kaboutapplicationdialog.cpp (line 94)

Review Request 125575: Make program logo non-pixelated on HiDPI

2015-10-09 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125575/ --- Review request for KDE Frameworks and David Edmundson. Repository: kxmlgu

kservice failures with Qt 5.4

2015-10-09 Thread Jonathan Riddell
kservice 5.15 and git master is failing a test with Qt 5.4 which passes with 5.5 with Qt 5.4 https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/89/console with Qt 5.5 https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/94/console

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 116 - Fixed!

2015-10-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/116/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 09 Oct 2015 12:24:29 + Build duration: 6 min 37 sec CHANGE SET Revision 7552ac73f55de0b383dd7904ad9

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 116 - Fixed!

2015-10-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/116/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 09 Oct 2015 12:24:29 + Build duration: 6 min 37 sec CHANGE SET Revision 7552ac73f55de0b383dd7904ad9

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 110 - Fixed!

2015-10-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/110/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 09 Oct 2015 12:17:01 + Build duration: 14 min CHANGE SET Revision 7552ac73f55de0b383dd7904ad98eaf19dae0ae9

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 110 - Fixed!

2015-10-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/110/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 09 Oct 2015 12:17:01 + Build duration: 14 min CHANGE SET Revision 7552ac73f55de0b383dd7904ad98eaf19dae0ae9

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 127 - Still Unstable!

2015-10-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/127/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 09 Oct 2015 11:45:41 + Build duration: 16 min CHANGE SET Revision e94d7823ceb783836e75baf1ad873432f4de3c2f by scr

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 119 - Still Unstable!

2015-10-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/119/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 09 Oct 2015 11:45:41 + Build duration: 7 min 13 sec CHANGE SET Revision e94d7823ceb783836e75baf1ad873432f4

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

2015-10-09 Thread R.Harish Navnit
> On Oct. 9, 2015, 5:51 p.m., Daniel Vrátil wrote: > > kf5/convert-kabc-to-kcontacts.pl, line 6 > > > > > > you could use `$gi` at the end to make the match case-insensitive, thus > > saving one regexp per each fi

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 115 - Still Unstable!

2015-10-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/115/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 09 Oct 2015 11:45:03 + Build duration: 6 min 35 sec CHANGE SET Revision dbbdb0ae38e9f4923a5bd33ca6

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

2015-10-09 Thread Daniel Vrátil
> On Oct. 9, 2015, 2:21 p.m., Daniel Vrátil wrote: > > kf5/convert-kabc-to-kcontacts.pl, line 78 > > > > > > This will still break build (as expected): > > > > `KABC::Addressbook a()` -> `a()`. >

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

2015-10-09 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/#review86546 --- kf5/convert-kabc-to-kcontacts.pl (line 6)

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

2015-10-09 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/ --- (Updated Oct. 9, 2015, 5:39 p.m.) Review request for KDE Frameworks and K

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 109 - Still Unstable!

2015-10-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/109/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 09 Oct 2015 11:32:36 + Build duration: 7 min 9 sec CHANGE SET Revision f71a6cdff3f7755efca7db3a1f17a1bde6

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 114 - Still Unstable!

2015-10-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/114/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 09 Oct 2015 11:24:23 + Build duration: 6 min 29 sec CHANGE SET Revision f71a6cdff3f7755efca7db3a1f

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 108 - Still Unstable!

2015-10-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/108/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 09 Oct 2015 11:05:51 + Build duration: 15 min CHANGE SET Revision 34e23d5d728cdc53b21a6dbfbcce530e629afe6

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 113 - Still Unstable!

2015-10-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/113/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 09 Oct 2015 11:05:51 + Build duration: 6 min 50 sec CHANGE SET Revision 34e23d5d728cdc53b21a6dbfbc