Re: KTabWidget vs QTabWidget

2015-09-21 Thread Jeremy Whiting
David, I've been considering what you mean. I think I understand, but wanted to check before I spend a bit of time trying to implement what you described. Does the class below fit what you are considering? class KDropWidgetDecorator: public QObject { Q_OBJECT public: void installEventFilter(QW

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 93 - Still Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/93/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 23:17:59 + Build duration: 5 min 43 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 79 - Still Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/79/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 23:17:50 + Build duration: 4 min 9 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 95 - Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/95/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 23:15:15 + Build duration: 4 min 47 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 46 - Failure!

2015-09-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/46/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 23:12:24 + Build duration: 34 sec CHANGE SET No changes

Jenkins-kde-ci: kdesignerplugin master stable-kf5-qt5 » Linux,gcc - Build # 17 - Failure!

2015-09-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdesignerplugin%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 23:12:45 + Build duration: 19 sec CHANGE SET No changes

Jenkins-kde-ci: kded master stable-kf5-qt5 » Linux,gcc - Build # 20 - Failure!

2015-09-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kded%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/20/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 23:12:15 + Build duration: 18 sec CHANGE SET No changes ___

Jenkins-kde-ci: kconfigwidgets master stable-kf5-qt5 » Linux,gcc - Build # 18 - Failure!

2015-09-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kconfigwidgets%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 23:11:29 + Build duration: 15 sec CHANGE SET No changes _

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 88 - Still Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/88/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 23:05:17 + Build duration: 6 min 12 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 84 - Still Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/84/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 23:05:08 + Build duration: 1 min 44 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 103 - Still Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/103/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 23:02:33 + Build duration: 4 min 45 sec CHANGE SET No changes JUNIT RESULTS Name: (root) F

Jenkins-kde-ci: kcodecs master kf5-qt5 » Linux,gcc - Build # 17 - Still Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kcodecs%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 22:57:36 + Build duration: 2 min 5 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Jenkins-kde-ci: kcrash master kf5-qt5 » Linux, gcc - Build # 13 - Unstable!

2015-09-21 Thread Albert Astals Cid
El Dilluns, 21 de setembre de 2015, a les 21:21:46, David Faure va escriure: > On Monday 21 September 2015 18:45:30 no-re...@kde.org wrote: > > GENERAL INFO > > > > BUILD UNSTABLE > > Build URL: > > https://build.kde.org/job/kcrash%20master%20kf5-qt5/PLATFORM=Linux,compil > > er=gcc/13/ > LOL you'

Jenkins-kde-ci: kcrash master kf5-qt5 » Linux,gcc - Build # 16 - Fixed!

2015-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcrash%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 22:04:28 + Build duration: 1 min 52 sec CHANGE SET Revision f3b95e1e4ccd66061fec8ed02d6ea22a7bb08916

Jenkins-kde-ci: kcrash master kf5-qt5 » Linux,gcc - Build # 16 - Fixed!

2015-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcrash%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 22:04:28 + Build duration: 1 min 52 sec CHANGE SET Revision f3b95e1e4ccd66061fec8ed02d6ea22a7bb08916

Re: Review Request 125332: Use the more advanced version of uriencode.cmake from kdoctools which supports Windows.

2015-09-21 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125332/#review85729 --- So basically this is: * "synchronization" with the last change

Re: Review Request 125332: Use the more advanced version of uriencode.cmake from kdoctools which supports Windows.

2015-09-21 Thread Luigi Toscano
> On Set. 21, 2015, 2:54 p.m., Aleix Pol Gonzalez wrote: > > src/CMakeLists.txt, line 645 > > > > > > That doesn't seem to make a lot of sense... > > Patrick von Reth wrote: > This is needed as the cmake mo

Jenkins-kde-ci: kcrash master kf5-qt5 » Linux,gcc - Build # 15 - Still Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kcrash%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/15/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 21:43:06 + Build duration: 1 min 33 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kcrash master kf5-qt5 » Linux,gcc - Build # 14 - Still Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kcrash%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/14/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 21:39:18 + Build duration: 1 min 40 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Review Request 124983: Move the desktop files and file templates for the "Create New..." menu from kde-baseapps to kio

2015-09-21 Thread Albert Astals Cid
> On set. 21, 2015, 7:38 a.m., David Faure wrote: > > Hi, thanks for that. Some feedback (sorry for the delay) > > > > 1) kio is fine. kio-extras exists because some things in there bring > > additional dependencies. > > > > 2) I think we should remove all devices. Not just floppy ;) but in ge

Re: Review Request 125337: Mark kconfig-compiler as non-gui tool

2015-09-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125337/#review85727 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 21, 2015,

Re: Review Request 124983: Move the desktop files and file templates for the "Create New..." menu from kde-baseapps to kio

2015-09-21 Thread Luigi Toscano
> On Set. 21, 2015, 9:38 a.m., David Faure wrote: > > Hi, thanks for that. Some feedback (sorry for the delay) > > > > 1) kio is fine. kio-extras exists because some things in there bring > > additional dependencies. > > > > 2) I think we should remove all devices. Not just floppy ;) but in ge

Review Request 125340: Fix crash in UnicodeGroupProber::HandleData with short strings

2015-09-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125340/ --- Review request for KDE Frameworks. Repository: kcodecs Description

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 46 - Fixed!

2015-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/46/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 19:58:29 + Build duration: 12 min CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 46 - Fixed!

2015-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/46/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 19:58:29 + Build duration: 12 min CHANGE SET No changes JUNIT RESULTS Name: (roo

kcodecs failing test

2015-09-21 Thread Albert Astals Cid
This seems like Qt regressed? Cheers, Albert El Dilluns, 21 de setembre de 2015, a les 18:41:05, no-re...@kde.org va escriure: > GENERAL INFO > > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/kcodecs%20master%20kf5-qt5/PLATFORM=Linux,compile > r=gcc/16/ Project: PLATFORM=Linux,compi

Jenkins-kde-ci: kdesignerplugin master kf5-qt5 » Linux,gcc - Build # 19 - Fixed!

2015-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdesignerplugin%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 19:58:31 + Build duration: 50 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kdesignerplugin master kf5-qt5 » Linux,gcc - Build # 19 - Fixed!

2015-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdesignerplugin%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 19:58:31 + Build duration: 50 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kded master kf5-qt5 » Linux,gcc - Build # 22 - Fixed!

2015-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kded%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 19:57:45 + Build duration: 24 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Jenkins-kde-ci: kded master kf5-qt5 » Linux,gcc - Build # 22 - Fixed!

2015-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kded%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 19:57:45 + Build duration: 24 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Review Request 125338: Fix out of bounds memory access in KNTLM::getAuth

2015-09-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125338/ --- Review request for KDE Frameworks and Dawit Alemayehu. Repository: kio

Jenkins-kde-ci: kconfigwidgets master kf5-qt5 » Linux,gcc - Build # 19 - Fixed!

2015-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kconfigwidgets%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 19:26:51 + Build duration: 54 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kconfigwidgets master kf5-qt5 » Linux,gcc - Build # 19 - Fixed!

2015-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kconfigwidgets%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 19:26:51 + Build duration: 54 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 83 - Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/83/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 19:17:13 + Build duration: 2 min 36 sec CHANGE SET Revision ad3d90d4f695cb409abefae3a806bcb84bda7

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 78 - Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/78/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 18:42:45 + Build duration: 2 min 29 sec CHANGE SET Revision ad3d90d4f695cb409abefae3a806bc

Re: Jenkins-kde-ci: kcrash master kf5-qt5 » Linux, gcc - Build # 13 - Unstable!

2015-09-21 Thread David Faure
On Monday 21 September 2015 18:45:30 no-re...@kde.org wrote: > > GENERAL INFO > > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/kcrash%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/13/ LOL you'll have to disable ASAN for this module, it's trying to crash on purpose, to test KCrash :

Re: Review Request 125337: Mark kconfig-compiler as non-gui tool

2015-09-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125337/#review85724 --- Ship it! Ship It! - David Faure On Sept. 21, 2015, 6:42 p.

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 87 - Still Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/87/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 18:42:04 + Build duration: 5 min 49 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 82 - Fixed!

2015-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/82/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 18:41:50 + Build duration: 3 min 32 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 82 - Fixed!

2015-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/82/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 18:41:50 + Build duration: 3 min 32 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 102 - Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/102/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 18:38:26 + Build duration: 4 min 45 sec CHANGE SET No changes JUNIT RESULTS Name: (root) F

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 45 - Failure!

2015-09-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/45/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 18:35:53 + Build duration: 2 min 42 sec CHANGE SET No changes _

Jenkins-kde-ci: kdesignerplugin master kf5-qt5 » Linux,gcc - Build # 18 - Failure!

2015-09-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdesignerplugin%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 18:36:02 + Build duration: 21 sec CHANGE SET No changes ___

Jenkins-kde-ci: kded master kf5-qt5 » Linux,gcc - Build # 21 - Failure!

2015-09-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kded%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 18:35:41 + Build duration: 20 sec CHANGE SET No changes __

Jenkins-kde-ci: kcrash master kf5-qt5 » Linux,gcc - Build # 13 - Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kcrash%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/13/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 18:35:14 + Build duration: 1 min 42 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kconfigwidgets master kf5-qt5 » Linux,gcc - Build # 18 - Failure!

2015-09-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kconfigwidgets%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 18:34:56 + Build duration: 1 min 2 sec CHANGE SET No changes ___

Review Request 125337: Mark kconfig-compiler as non-gui tool

2015-09-21 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125337/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig

Jenkins-kde-ci: kcodecs master kf5-qt5 » Linux,gcc - Build # 16 - Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kcodecs%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 18:34:26 + Build duration: 55 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fail

Re: RFC: Enabling -DECM_ENABLE_SANITIZERS='address' in jenkins

2015-09-21 Thread Albert Astals Cid
El Dijous, 10 de setembre de 2015, a les 22:36:10, Albert Astals Cid va escriure: > We have this nice ECM module that gives us the option to compile with ASAN. > > I'd like to propose that we enable it by default in jenkins. > > This way we get all the autotests run with ASAN and potentially cat

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 81 - Unstable!

2015-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/81/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 18:24:30 + Build duration: 2 min 15 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Re: Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

2015-09-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125336/ --- (Updated Sept. 21, 2015, 6:11 p.m.) Review request for KDE Frameworks and

Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

2015-09-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125336/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Review Request 125334: Small improvements in ColumnProxyModel

2015-09-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125334/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Re: Review Request 124563: Make it possible to import/export shortcut schemes symmetrically

2015-09-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124563/ --- (Updated Sept. 21, 2015, 2:40 p.m.) Status -- This change has been m

Re: Review Request 125021: Fix uninitialized value valgrind error

2015-09-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125021/ --- (Updated Sept. 21, 2015, 2:36 p.m.) Status -- This change has been m

Re: kiconloader/qbuffer device not open puzzle?

2015-09-21 Thread Boudewijn Rempt
Aw, no... It doesn't seem to have helped me. On Sun, 20 Sep 2015, Boudewijn Rempt wrote: Okay! I'll update tomorrow morning :-) On Sun, 20 Sep 2015, David Faure wrote: On Thursday 17 September 2015 16:40:48 Boudewijn Rempt wrote: On Thu, 17 Sep 2015, David Faure wrote: Sounds like the pi

Re: Review Request 125300: Fix lock in KProtocolManager

2015-09-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125300/ --- (Updated Sept. 21, 2015, 4:34 p.m.) Status -- This change has been d

Re: Review Request 125316: KProtocolManager: fix deadlock when using EnvVarProxy.

2015-09-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125316/#review85717 --- Ship it! Looks good to me, seems to fix the issue. I'll disca

Re: Review Request 125332: Use the more advanced version of uriencode.cmake from kdoctools which supports Windows.

2015-09-21 Thread Patrick von Reth
> On Sept. 21, 2015, 12:54 nachm., Aleix Pol Gonzalez wrote: > > cmake/FindPerlModules.cmake, line 2 > > > > > > How is that new file related? The change is based on the current version of kdoctools which makes su

Re: Review Request 125316: KProtocolManager: fix deadlock when using EnvVarProxy.

2015-09-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125316/ --- (Updated Sept. 21, 2015, 3:23 p.m.) Review request for KDE Frameworks and

Re: Review Request 125332: Use the more advanced version of uriencode.cmake from kdoctools which supports Windows.

2015-09-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125332/#review85715 --- cmake/FindPerlModules.cmake (line 2)

Review Request 125332: Use the more advanced version of uriencode.cmake from kdoctools which supports Windows.

2015-09-21 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125332/ --- Review request for KDE Frameworks. Repository: kdelibs4support Descript

Re: Review Request 125284: make install name of applications.menu file a cached cmake variable

2015-09-21 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125284/ --- (Updated Sept. 21, 2015, 11:35 a.m.) Review request for KDE Frameworks, D

Re: Review Request 125284: make install name of applications.menu file a cached cmake variable

2015-09-21 Thread Harald Sitter
> On Sept. 20, 2015, 6:37 p.m., David Faure wrote: > > CMakeLists.txt, line 33 > > > > > > I'm surprised that this compiles, the double-quotes here usually don't > > end up in the C++ code, (they get eaten by cma

Re: Review Request 124983: Move the desktop files and file templates for the "Create New..." menu from kde-baseapps to kio

2015-09-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124983/#review85711 --- Hi, thanks for that. Some feedback (sorry for the delay) 1) k

Re: Review Request 125158: add logic to use icons for default xdg user dirs

2015-09-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/#review85710 --- src/core/kfileitem.cpp (line 905)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 79 - Fixed!

2015-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/79/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 06:53:59 + Build duration: 3 min 40 sec CHANGE SET Revision a0328b2f91d5fdc6d6df47b55f744e903d178d

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 79 - Fixed!

2015-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/79/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 21 Sep 2015 06:53:59 + Build duration: 3 min 40 sec CHANGE SET Revision a0328b2f91d5fdc6d6df47b55f744e903d178d