Re: Review Request 124684: Cmake fail to parse proper taglib version - kdelibs4support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124684/ --- (Updated Sept. 18, 2015, 2:14 a.m.) Status -- This change has been m

Re: Review Request 125275: KSycoca: remove all self() methods for factories, store them in KSycoca instead.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125275/#review85600 --- Ship it! Ship It! - Albert Astals Cid On set. 16, 2015, 11

Re: Review Request 125272: KSycoca: rebuild sycoca in-process in most unittests as well.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125272/#review85599 --- Ship it! Ship It! - Albert Astals Cid On set. 16, 2015, 10

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85597 --- src/sycoca/ksycoca.cpp (line 683)

Re: Review Request 125278: KSycoca: add a q pointer to remove more singleton usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125278/#review85596 --- Ship it! Ship It! - Albert Astals Cid On set. 16, 2015, 11

Re: Review Request 125274: KBuildSycoca: remove writing of the ksycoca5stamp file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125274/#review85594 --- Ship it! Ship It! - Albert Astals Cid On set. 17, 2015, 12

Re: Review Request 125284: make install name of applications.menu file a cached cmake variable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125284/#review85585 --- +1 This will save a lot of patch rebasing :D (i'm assuming eve

Review Request 125290: Refresh Solid's device list before querying in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125290/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: kiconloader/qbuffer device not open puzzle?

On Thu, 17 Sep 2015, David Faure wrote: Sounds like the pixmap loading reaches the end of the stream, maybe. Did you try moving out the cache, so it gets recreated? In order to find out if this is cache corruption or something else. Yes, removing the cache 'fixes' the issue -- the icon isn't

Re: kiconloader/qbuffer device not open puzzle?

On Thu, 17 Sep 2015, Boudewijn Rempt wrote: On Thu, 17 Sep 2015, David Faure wrote: Sounds like the pixmap loading reaches the end of the stream, maybe. Did you try moving out the cache, so it gets recreated? In order to find out if this is cache corruption or something else. Yes, removi

Re: Review Request 125289: Use Q_SLOTS/Q_SIGNALS instead of slots/signals in all headers from include dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125289/#review85582 --- Ship it! Ship It! - David Faure On Sept. 17, 2015, 2:14 p.

Re: kiconloader/qbuffer device not open puzzle?

On Thursday 17 September 2015 14:25:27 Boudewijn Rempt wrote: > I'm wondering if others see this as well and if there's something simple > that I've missed that fixes it... For me, right now, with an up-to-date > home-grown Qt 5.5 and kdesrc-build-built frameworks, icons don't get > loaded once the

Re: Review Request 125289: Use Q_SLOTS/Q_SIGNALS instead of slots/signals in all headers from include dir

> On Sept. 17, 2015, 4:13 p.m., Andrea Scarpino wrote: > > Inviala! > > Andrea Scarpino wrote: > And in Choqok too, thanks! > > (please do not consider my "Ship It" :-) Oops... xD - Aleix --- This is an automatically gener

Re: Review Request 125289: Use Q_SLOTS/Q_SIGNALS instead of slots/signals in all headers from include dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125289/ --- (Updated Sept. 17, 2015, 2:14 p.m.) Status -- This change has been m

Re: Review Request 125289: Use Q_SLOTS/Q_SIGNALS instead of slots/signals in all headers from include dir

> On Set. 17, 2015, 4:13 p.m., Andrea Scarpino wrote: > > Inviala! And in Choqok too, thanks! (please do not consider my "Ship It" :-) - Andrea --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde

Re: Review Request 125289: Use Q_SLOTS/Q_SIGNALS instead of slots/signals in all headers from include dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125289/#review85579 --- Ship it! Inviala! - Andrea Scarpino On Set. 17, 2015, 2:26

Re: Review Request 125289: Use Q_SLOTS/Q_SIGNALS instead of slots/signals in all headers from include dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125289/#review85574 --- +1 this was a problem in KDE Connect as well. - Aleix Pol Gon

Re: Review Request 125259: Support multiple X servers in the NETWM classes

> On Sept. 16, 2015, 4:23 nachm., Thomas Lübking wrote: > > would one want to use the occasion to get rid of the bazillion variables > > mapped to a struct array and have atom(Atom a) and atomString(Atom a) for > > an array of atoms a matching string - maybe including some namespaces so > > th

Review Request 125289: Use Q_SLOTS/Q_SIGNALS instead of slots/signals in all headers from include dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125289/ --- Review request for KDE Frameworks and Ivan Romanov. Repository: qca Des

kiconloader/qbuffer device not open puzzle?

I'm wondering if others see this as well and if there's something simple that I've missed that fixes it... For me, right now, with an up-to-date home-grown Qt 5.5 and kdesrc-build-built frameworks, icons don't get loaded once the cache exists. In bool KIconLoaderPrivate::findCachedPixmapWithPath(

Re: Review Request 125274: KBuildSycoca: remove writing of the ksycoca5stamp file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125274/ --- (Updated Sept. 17, 2015, 12:01 p.m.) Review request for KDE Frameworks an

Re: Review Request 125259: Support multiple X servers in the NETWM classes

> On Sept. 16, 2015, 6:23 p.m., Thomas Lübking wrote: > > would one want to use the occasion to get rid of the bazillion variables > > mapped to a struct array and have atom(Atom a) and atomString(Atom a) for > > an array of atoms a matching string - maybe including some namespaces so > > that

Re: Review Request 125270: KBuildSycoca: use qCWarning rather than fprintf(stderr, ...) or qWarning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125270/ --- (Updated Sept. 17, 2015, 11:53 a.m.) Status -- This change has been

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 17, 2015, 10:40 a.m.) Status -- This change has been

Re: Review Request 125270: KBuildSycoca: use qCWarning rather than fprintf(stderr, ...) or qWarning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125270/#review85554 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 17, 2015,

Re: Review Request 125259: Support multiple X servers in the NETWM classes

> On Sept. 16, 2015, 4:23 p.m., Thomas Lübking wrote: > > would one want to use the occasion to get rid of the bazillion variables > > mapped to a struct array and have atom(Atom a) and atomString(Atom a) for > > an array of atoms a matching string - maybe including some namespaces so > > that

Re: Review Request 125259: Support multiple X servers in the NETWM classes

> On Sept. 16, 2015, 6:23 p.m., Thomas Lübking wrote: > > would one want to use the occasion to get rid of the bazillion variables > > mapped to a struct array and have atom(Atom a) and atomString(Atom a) for > > an array of atoms a matching string - maybe including some namespaces so > > that

Re: Review Request 125274: KBuildSycoca: remove writing of the ksycoca5stamp file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125274/#review85551 --- docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook (lines 27 - 28

Review Request 125284: make install name of applications.menu file a cached cmake variable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125284/ --- Review request for KDE Frameworks, David Faure, Jonathan Riddell, and Rex

Re: Review Request 125259: Support multiple X servers in the NETWM classes

> On Sept. 16, 2015, 4:23 nachm., Thomas Lübking wrote: > > would one want to use the occasion to get rid of the bazillion variables > > mapped to a struct array and have atom(Atom a) and atomString(Atom a) for > > an array of atoms a matching string - maybe including some namespaces so > > th

Re: Review Request 125259: Support multiple X servers in the NETWM classes

> On Sept. 16, 2015, 6:23 p.m., Thomas Lübking wrote: > > would one want to use the occasion to get rid of the bazillion variables > > mapped to a struct array and have atom(Atom a) and atomString(Atom a) for > > an array of atoms a matching string - maybe including some namespaces so > > that

Re: Review Request 125259: Support multiple X servers in the NETWM classes

> On Sept. 16, 2015, 4:23 nachm., Thomas Lübking wrote: > > would one want to use the occasion to get rid of the bazillion variables > > mapped to a struct array and have atom(Atom a) and atomString(Atom a) for > > an array of atoms a matching string - maybe including some namespaces so > > th