Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 62 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/62/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 06:55:08 + Build duration: 3 min 0 sec CHANGE SET Revision 19b1ba1a0ef765615d3d5182b5f291665d4a5c

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 61 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/61/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 06:55:08 + Build duration: 2 min 37 sec CHANGE SET Revision 19b1ba1a0ef765615d3d5182b5f2916

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 61 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/61/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 06:55:08 + Build duration: 2 min 37 sec CHANGE SET Revision 19b1ba1a0ef765615d3d5182b5f2916

Re: Review Request 125218: Fix memory leaks in the KBuildSycoca class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125218/ --- (Updated Sept. 14, 2015, 6:54 a.m.) Status -- This change has been m

Re: Review Request 125220: KService: use a real global static for QThreadStorage rather than Q_GLOBAL_STATIC.

> On Sept. 14, 2015, 12:11 a.m., Thiago Macieira wrote: > > Aye, QThreadStorage isn't meant to be used in a Q_GLOBAL_STATIC. I don't > > understand what you meant by id: QThreadStorageData::get can only be called > > once the construction has finished, in which case there aren't multiple > > t

Re: Review Request 125217: KDirWatch: fix thread safety

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125217/#review85340 --- I had one comment/suggestion but the improvement itself looks

Re: Review Request 125220: KService: use a real global static for QThreadStorage rather than Q_GLOBAL_STATIC.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125220/#review85338 --- Aye, QThreadStorage isn't meant to be used in a Q_GLOBAL_STATI

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

> On Sep 13, 2015, at 5:43 PM, Marko Käning wrote: > > Hi devs, > > the other day I had built version 5.13 successfully on a OSX/MacPorts-based > VM. > And so I wanted to try the same with the newest 5.14 just now, but failed! :( > > Any idea why those three interfaces are undefined? > Hi,

Re: Review Request 125218: Fix memory leaks in the KBuildSycoca class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125218/#review85337 --- Ship it! Ship It! - Albert Astals Cid On set. 13, 2015, 8:

Re: Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/ --- (Updated Sept. 14, 2015, 12:19 a.m.) Review request for KDE Frameworks an

Review Request 125220: KService: use a real global static for QThreadStorage rather than Q_GLOBAL_STATIC.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125220/ --- Review request for KDE Frameworks and Thiago Macieira. Repository: kservi

Re: Review Request 125218: Fix memory leaks in the KBuildSycoca class

> On Sept. 13, 2015, 9:34 p.m., Albert Astals Cid wrote: > > src/kbuildsycoca/kbuildsycoca.cpp, line 482 > > > > > > Worth resetting to 0? It's set to 0 (or to something) at the beginning of recreate(), so if we

Building KF in version 5.14 on OSX fails for framework kdesignerplugin

Hi devs, the other day I had built version 5.13 successfully on a OSX/MacPorts-based VM. And so I wanted to try the same with the newest 5.14 just now, but failed! :( Any idea why those three interfaces are undefined? Greets, Marko --- :info:build [ 85%] Generating qrc_testplugin.cpp :info:b

Re: Review Request 125218: Fix memory leaks in the KBuildSycoca class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125218/#review85335 --- src/kbuildsycoca/kbuildsycoca.cpp (line 482)

Re: Review Request 125214: Add support for network shares in kio_trash

> On Sept. 13, 2015, 8:48 p.m., David Faure wrote: > > Thanks for the patch! > > > > Protecting write access to a file is better done with QLockFile (which I > > added to Qt 5.0) than with a DBus based mechanism. > > > > (btw I just noticed that KInterProcessLock is now unused in kio_trash, we

Re: Review Request 125217: KDirWatch: fix thread safety

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125217/#review85331 --- +1 i can confirm that the threaded kservice tests are more sta

Re: Review Request 125214: Add support for network shares in kio_trash

> On Sept. 13, 2015, 10:48 p.m., David Faure wrote: > > Thanks for the patch! > > > > Protecting write access to a file is better done with QLockFile (which I > > added to Qt 5.0) than with a DBus based mechanism. > > > > (btw I just noticed that KInterProcessLock is now unused in kio_trash, w

Review Request 125218: Fix memory leaks in the KBuildSycoca class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125218/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository: kser

Re: Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/#review85328 --- Thanks for the patch! Protecting write access to a file is be

Review Request 125217: KDirWatch: fix thread safety

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125217/ --- Review request for KDE Frameworks, Albert Astals Cid and Michael Pyne. Re

Re: Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/ --- (Updated Sept. 13, 2015, 9:59 p.m.) Review request for KDE Frameworks and

Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/ --- Review request for KDE Frameworks and David Faure. Bugs: 177023 https

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 60 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/60/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 13 Sep 2015 18:01:36 + Build duration: 2 min 47 sec CHANGE SET Revision c7d4b69044c12394e1136d095674b0

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 61 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/61/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 13 Sep 2015 18:01:36 + Build duration: 1 min 9 sec CHANGE SET Revision c7d4b69044c12394e1136d095674b0a30d03f9f

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 61 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/61/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 13 Sep 2015 18:01:36 + Build duration: 1 min 9 sec CHANGE SET Revision c7d4b69044c12394e1136d095674b0a30d03f9f

Re: Review Request 125185: KSycoca: replace DBus notification with file watching using KDirWatch.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125185/ --- (Updated Sept. 13, 2015, 6:01 p.m.) Status -- This change has been m

Re: Review Request 125185: KSycoca: replace DBus notification with file watching using KDirWatch.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125185/#review85326 --- Ship it! Ship It! - Albert Astals Cid On set. 13, 2015, 4:

Re: Review Request 124856: Call newInstance from the child on first invocation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124856/#review85325 --- Personnally, I don't like very much the idea of modifying kdel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 60 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/60/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 13 Sep 2015 17:46:11 + Build duration: 1 min 19 sec CHANGE SET Revision 736f06302ec5b4f633b0c9f0fd7ca98754883

Re: Review Request 125211: [autotests] don't delete in one thread a service that another thread is querying.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125211/ --- (Updated Sept. 13, 2015, 5:45 p.m.) Status -- This change has been m

Re: Review Request 125185: KSycoca: replace DBus notification with file watching using KDirWatch.

> On Sept. 13, 2015, 5:24 p.m., Albert Astals Cid wrote: > > > KDirWatch beats QFileSystemWatcher once again, after much fighting with > > > QFSW > > > with one failing unittest (KServiceTest::testThreads), I switched to > > > KDirWatch > > > and it worked immediately... > > > > Is that a pro

Re: Review Request 125212: [autotests] simplify code using QTRY_COMPARE and clean up spying

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125212/ --- (Updated Sept. 13, 2015, 5:45 p.m.) Status -- This change has been m

Re: Review Request 125212: [autotests] simplify code using QTRY_COMPARE and clean up spying

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125212/#review85323 --- autotests/kservicetest.cpp (line 270)

Re: Review Request 125185: KSycoca: replace DBus notification with file watching using KDirWatch.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125185/#review85322 --- > KDirWatch beats QFileSystemWatcher once again, after much fi

Re: Review Request 125211: [autotests] don't delete in one thread a service that another thread is querying.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125211/#review85321 --- Ship it! Ship It! - Albert Astals Cid On set. 13, 2015, 4:

Re: Review Request 125212: [autotests] simplify code using QTRY_COMPARE and clean up spying

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125212/#review85320 --- autotests/kservicetest.cpp (line 270)

Re: Review Request 125185: KSycoca: replace DBus notification with file watching using KDirWatch.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125185/ --- (Updated Sept. 13, 2015, 4:26 p.m.) Review request for KDE Frameworks, Al

Review Request 125212: [autotests] simplify code using QTRY_COMPARE and clean up spying

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125212/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository: kser

Review Request 125211: [autotests] don't delete in one thread a service that another thread is querying.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125211/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository: kser

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 40 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 13 Sep 2015 13:51:44 + Build duration: 2 min 59 sec CHANGE SET No changes _

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 40 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 13 Sep 2015 13:51:53 + Build duration: 1 min 24 sec CHANGE SET No changes __

Jenkins-kde-ci: knotifications master stable-kf5-qt5 » Linux,gcc - Build # 30 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knotifications%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/30/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 13 Sep 2015 13:47:43 + Build duration: 54 sec CHANGE SET No changes _

Re: SIC/BIC in Frameworks (NOT)

This is clearly a CI issue, not a SIC/BIC, as both our investigations prove. On Sunday 13 September 2015 23:43:19 Ben Cooksley wrote: > This then causes KNotification to fail to build (as it depends on > netwm.h) which then leads to the rest of the failures we see. This > itself is probably a bug?

Re: SIC/BIC in Frameworks

On Sun, Sep 13, 2015 at 11:07 PM, Ben Cooksley wrote: > Hi all, > > As you may have seen a series of Frameworks have recently failed to > build on the CI system. > This appears to be due to either binary incompatibility, or changes in > the build system which have changed the visibility of symbols

SIC/BIC in Frameworks

Hi all, As you may have seen a series of Frameworks have recently failed to build on the CI system. This appears to be due to either binary incompatibility, or changes in the build system which have changed the visibility of symbols in linked libraries. In any event, these changes have introduced

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

On Sunday, September 13, 2015 11:55:22 AM CEST David Faure wrote: > On Tuesday 08 September 2015 07:25:14 Martin Gräßlin wrote: > > From our CI system: > > cmake -DCMAKE_DISABLE_FIND_PACKAGE_X11=TRUE > > I was just looking at problems in the CI right now, and it seems this was > set for kwindowsys

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

On Tuesday 08 September 2015 07:25:14 Martin Gräßlin wrote: > > From our CI system: > cmake -DCMAKE_DISABLE_FIND_PACKAGE_X11=TRUE I was just looking at problems in the CI right now, and it seems this was set for kwindowsystem even on Linux ? I found CMakeCache.txt:CMAKE_DISABLE_FIND_PACKAGE_X11:

Jenkins-kde-ci: knotifications master stable-kf5-qt5 » Linux,gcc - Build # 29 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knotifications%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/29/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 13 Sep 2015 09:38:01 + Build duration: 39 sec CHANGE SET No changes _

Jenkins-kde-ci: knotifications master kf5-qt5 » Linux,gcc - Build # 30 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knotifications%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/30/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 13 Sep 2015 09:37:15 + Build duration: 41 sec CHANGE SET No changes

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 16 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 13 Sep 2015 08:59:50 + Build duration: 2 min 56 sec CHANGE SET Revision bb03e02fa18743bed27f85c6258c21cfe9

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 15 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/15/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 13 Sep 2015 08:59:50 + Build duration: 2 min 35 sec CHANGE SET Revision bb03e02fa18743bed27f85c6258c21cfe913d7e0