Re: Review Request 125083: Move X11 related find_package under X11_FOUND

2015-09-07 Thread Martin Gräßlin
> On Sept. 7, 2015, 9:17 a.m., Martin Gräßlin wrote: > > hey OSX-devs: we need to find a better solution for this things. I didn't > > notice the review before it was pushed, but I would not have given a shipit > > for it. > > > > The solution is sementically wrong. We are now binding finding

Re: KService, ksycoca and translations

2015-09-07 Thread Albert Astals Cid
El Dilluns, 7 de setembre de 2015, a les 23:28:40, Albert Astals Cid va escriure: > Running >LANGUAGE=de kcmshell5 --list > > in my catalan based system gives me almost everything in catalan. > > That is because most of the strings come from kservice and my sycoca is in > catalan. > > KSyco

KService, ksycoca and translations

2015-09-07 Thread Albert Astals Cid
Running LANGUAGE=de kcmshell5 --list in my catalan based system gives me almost everything in catalan. That is because most of the strings come from kservice and my sycoca is in catalan. KSycoca does not check the language is the one we want when opening the database so it does not recreate

Re: Review Request 124746: [KDesktopFile] add readMimeType

2015-09-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124746/ --- (Updated Sept. 7, 2015, 6:45 p.m.) Status -- This change has been ma

Re: QIcon::fromTheme(xxx, someFallback)

2015-09-07 Thread Olivier Goffart
On Sunday 23. August 2015 12:01:38 David Faure wrote: > On Sunday 23 August 2015 10:30:13 Olivier Goffart wrote: > > On Friday 21. August 2015 22:30:37 David Faure wrote: > > > > I would also approve a change to Qt to add an overload of > > > > QIcon::fromTheme > > > > with only one argument withou

Re: [kglobalaccel/kglobalaccel-master] /: Add missing licenses

2015-09-07 Thread Yasen Pramatarov
On Fri, 10 Jul 2015 15:46:08 +0200 Maximiliano Curia wrote: >The po/bg files are distributed with the kglobalaccel's tarballs and >are under the GPL license, adding a copy of this license is only a >formality required by most licenses, but changes nothing to the >licensing state of the library/fra

Re: ksycoca and kbuildsycoca, the next step

2015-09-07 Thread David Faure
On Sunday 06 September 2015 18:15:47 Matthew Dawson wrote: > On September 7, 2015 12:03:59 AM you wrote: > > On Sunday 06 September 2015 17:59:13 Matthew Dawson wrote: > > > On September 6, 2015 01:52:37 PM David Faure wrote: > > > > As a followup to recent discussions, I'm now looking into moving

Re: Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux, All, gcc - Build # 29 - Unstable!

2015-09-07 Thread David Faure
On Monday 07 September 2015 07:21:50 no-re...@kde.org wrote: > > GENERAL INFO > > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/29/ > Project: PLATFORM=Linux,Variation=All,compiler=gcc > Date of build: Mon, 07 S

Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

2015-09-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125048/#review84942 --- Ship it! Ah! Very good, then ;) - David Faure On Sept. 4,

Re: Review Request 125051: KFileWidget: multiple files with ":" in filename recognized as directories

2015-09-07 Thread Jean-Baptiste Mardelle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125051/ --- (Updated Sept. 7, 2015, 7:48 a.m.) Status -- This change has been ma

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

2015-09-07 Thread Samuel Gaist
> On Sept. 7, 2015, 7:17 a.m., Martin Gräßlin wrote: > > hey OSX-devs: we need to find a better solution for this things. I didn't > > notice the review before it was pushed, but I would not have given a shipit > > for it. > > > > The solution is sementically wrong. We are now binding finding

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

2015-09-07 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125083/ --- (Updated Sept. 7, 2015, 9:25 a.m.) Status -- This change has been ma

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 29 - Unstable!

2015-09-07 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/29/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 07 Sep 2015 07:12:19 + Build duration: 3 min 6 sec CHANGE SET Revision 0ea86

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

2015-09-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125083/#review84937 --- hey OSX-devs: we need to find a better solution for this thing